public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Robert Lee <lerobert@google.com>
Cc: vkoul@kernel.org, perex@perex.cz, tiwai@suse.com,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: compress: add opus codec define
Date: Tue, 25 Jul 2023 12:05:39 +0200	[thread overview]
Message-ID: <87sf9ctifg.wl-tiwai@suse.de> (raw)
In-Reply-To: <20230725093005.3499455-1-lerobert@google.com>

On Tue, 25 Jul 2023 11:30:05 +0200,
Robert Lee wrote:
> 
> Add to support decode Opus codec in Ogg container.
> 
> Signed-off-by: Robert Lee <lerobert@google.com>

The change makes sense only when it's really used.  So usually it's
better to put into a series that actually implements its usage.


thanks,

Takashi

> ---
>  include/uapi/sound/compress_params.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/uapi/sound/compress_params.h b/include/uapi/sound/compress_params.h
> index ddc77322d571..bac5797bcb02 100644
> --- a/include/uapi/sound/compress_params.h
> +++ b/include/uapi/sound/compress_params.h
> @@ -43,7 +43,8 @@
>  #define SND_AUDIOCODEC_BESPOKE               ((__u32) 0x0000000E)
>  #define SND_AUDIOCODEC_ALAC                  ((__u32) 0x0000000F)
>  #define SND_AUDIOCODEC_APE                   ((__u32) 0x00000010)
> -#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_APE
> +#define SND_AUDIOCODEC_OPUS                  ((__u32) 0x00000011)
> +#define SND_AUDIOCODEC_MAX                   SND_AUDIOCODEC_OPUS
>  
>  /*
>   * Profile and modes are listed with bit masks. This allows for a
> -- 
> 2.41.0.487.g6d72f3e995-goog
> 

  reply	other threads:[~2023-07-25 10:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-25  9:30 [PATCH] ALSA: compress: add opus codec define Robert Lee
2023-07-25 10:05 ` Takashi Iwai [this message]
2023-07-25 10:14   ` Robert Lee
2023-07-25 10:25     ` Takashi Iwai
2023-07-26  1:47       ` Robert Lee
2023-07-26  4:55         ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf9ctifg.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=lerobert@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox