public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: "Íñigo Huguet" <ihuguet@redhat.com>, ojeda@kernel.org, danny@kdrag0n.dev
Cc: masahiroy@kernel.org, jgg@nvidia.com, mic@digikod.net,
	linux-kernel@vger.kernel.org, joe@perches.com,
	linux@rasmusvillemoes.dk, willy@infradead.org,
	mailhol.vincent@wanadoo.fr, "Íñigo Huguet" <ihuguet@redhat.com>
Subject: Re: [PATCH v4] Add .editorconfig file for basic formatting
Date: Fri, 09 Jun 2023 01:50:00 -0600	[thread overview]
Message-ID: <87sfb1oz13.fsf@meer.lwn.net> (raw)
In-Reply-To: <20230601075333.14021-1-ihuguet@redhat.com>

Íñigo Huguet <ihuguet@redhat.com> writes:

> EditorConfig is a specification to define the most basic code formatting
> stuff, and it's supported by many editors and IDEs, either directly or
> via plugins, including VSCode/VSCodium, Vim, emacs and more.
>
> It allows to define formatting style related to indentation, charset,
> end of lines and trailing whitespaces. It also allows to apply different
> formats for different files based on wildcards, so for example it is
> possible to apply different configs to *.{c,h}, *.py and *.rs.
>
> In linux project, defining a .editorconfig might help to those people
> that work on different projects with different indentation styles, so
> they cannot define a global style. Now they will directly see the
> correct indentation on every fresh clone of the project.
>
> See https://editorconfig.org
>
> Co-developed-by: Danny Lin <danny@kdrag0n.dev>
> Signed-off-by: Danny Lin <danny@kdrag0n.dev>
> Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>

So I must confess to still being really nervous about installing a file
that will silently reconfigure the editors of everybody working on the
kernel source; I wish there were a straightforward way to do this as an
opt-in thing.  We're talking about creating a flag-day behavioral change
for, potentially, thousands of kernel developers.  Something tells me
that we might just hear from a few of them.

I wonder if we should, instead, ship a file like this as something like
Documentation/process/editorconfig, then provide a "make editorconfig"
command that installs it in the top-level directory for those who want
it?

Or perhaps I'm worrying too much?

Thanks,

jon

  parent reply	other threads:[~2023-06-09  7:51 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01  7:53 [PATCH v4] Add .editorconfig file for basic formatting Íñigo Huguet
2023-06-02 15:37 ` Mickaël Salaün
2023-06-04 20:49   ` Miguel Ojeda
2023-06-09  7:50 ` Jonathan Corbet [this message]
2023-06-09  8:23   ` Miguel Ojeda
2023-06-09  8:49   ` Íñigo Huguet
2023-06-09  8:50     ` Íñigo Huguet
2023-06-09 10:49     ` Miguel Ojeda
2023-06-14 11:33       ` Íñigo Huguet
2023-06-09 13:23   ` Mickaël Salaün
2023-06-14 11:40     ` Íñigo Huguet
2023-06-14 12:08       ` Rasmus Villemoes
2023-06-14 12:53       ` Vincent MAILHOL
2023-06-14 13:04         ` Íñigo Huguet
2023-06-15  2:40           ` Vincent MAILHOL
2023-06-15  6:35             ` Íñigo Huguet
2023-10-11  7:36 ` Vincent MAILHOL
2023-10-23  2:28   ` Jonathan Corbet
2023-10-23  6:18     ` Vincent MAILHOL
2023-10-23  6:26       ` Íñigo Huguet
2023-12-11 17:50         ` Masahiro Yamada
2024-06-02 15:30           ` Mateusz Guzik
2024-06-02 16:28             ` Miguel Ojeda
2024-06-02 18:17               ` Joe Perches
2024-06-03 12:18             ` Jason Gunthorpe
2024-06-03 12:52               ` Mateusz Guzik
2024-06-03 13:38                 ` Miguel Ojeda
2024-06-03 15:09                   ` Mateusz Guzik
2024-06-11  6:44               ` Greg KH
2024-01-23 20:03 ` andy.shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfb1oz13.fsf@meer.lwn.net \
    --to=corbet@lwn.net \
    --cc=danny@kdrag0n.dev \
    --cc=ihuguet@redhat.com \
    --cc=jgg@nvidia.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=masahiroy@kernel.org \
    --cc=mic@digikod.net \
    --cc=ojeda@kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox