From: Jani Nikula <jani.nikula@linux.intel.com>
To: Jingyu Wang <jingyuwang_vip@163.com>,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@linux.ie, daniel@ffwll.ch,
Joe Perches <joe@perches.com>
Cc: Jingyu Wang <jingyuwang_vip@163.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/print: cleanup coding style in drm_print.h
Date: Mon, 05 Sep 2022 11:49:28 +0300 [thread overview]
Message-ID: <87sfl6b3zb.fsf@intel.com> (raw)
In-Reply-To: <87wnaib45t.fsf@intel.com>
On Mon, 05 Sep 2022, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> On Mon, 05 Sep 2022, Jingyu Wang <jingyuwang_vip@163.com> wrote:
>> Fix everything checkpatch.pl complained about in drm_print.h
[...]
>> static inline void
>> -drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)
>> +drm_vprintf(struct drm_printer *p, const char *fmt, va_list * va)
>
> Checkpatch is just confused here. Look at all the other params, why
> would you add an extra space here?
Joe, can you help me out here please, I can't figure out why checkpatch
is complaining here:
include/drm/drm_print.h:106: CHECK:SPACING: spaces preferred around that '*' (ctx:WxV)
#106: FILE: include/drm/drm_print.h:106:
+drm_vprintf(struct drm_printer *p, const char *fmt, va_list *va)
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2022-09-05 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-04 20:38 [PATCH] drm/print: cleanup coding style in drm_print.h Jingyu Wang
2022-09-05 8:45 ` Jani Nikula
2022-09-05 8:49 ` Jani Nikula [this message]
2022-09-05 10:05 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfl6b3zb.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingyuwang_vip@163.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox