From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 610C3CCA47F for ; Fri, 22 Jul 2022 07:42:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234429AbiGVHmA (ORCPT ); Fri, 22 Jul 2022 03:42:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233842AbiGVHl6 (ORCPT ); Fri, 22 Jul 2022 03:41:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF9D17061 for ; Fri, 22 Jul 2022 00:41:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 9D726621CB for ; Fri, 22 Jul 2022 07:41:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E154C341C6; Fri, 22 Jul 2022 07:41:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1658475716; bh=cuOw9xEcYaKOoUU5seBi4R98UTaU1G74wM+EIHt9rFY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=lj0WWWF9DOSZaPgqMPGbqjVG3KamL+LLC3UHl08ncuCV3jg1i0O80R5UOqWeS5ut6 JSV4C3r1/eSvIAycezuLoHrU+x6OMjZyOBrVkUxUfEak/KeaB8PTb3L+ne3CwAztTP nmrMLA1hpH1w38GfpyyaqKO6uxxkr8lw2NWAVlt3UIjStUjeBjUCFrRJeDQ0eXbmKz tq1fHI1vYUlfl6vHnKnYDcE9wjioGOFPsTYPn7nWWccbzx5QBPBpKTJr5wI4aCEbeK 7BFEnLAXxnzFjrnFkHgqYDCS/X6kx12YgXBwnLpoU3Xgs/4ffUN5ZZt4kyr2Kk34Jp b+xYH19qoy7Hw== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oEnIH-009Gh2-P4; Fri, 22 Jul 2022 08:41:53 +0100 Date: Fri, 22 Jul 2022 08:41:53 +0100 Message-ID: <87sfmty4ou.wl-maz@kernel.org> From: Marc Zyngier To: Ben Dooks Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH] irqchip/mmp: fix missing extern init code In-Reply-To: <20220721215147.468971-1-ben-linux@fluff.org> References: <20220721215147.468971-1-ben-linux@fluff.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: ben-linux@fluff.org, linux-kernel@vger.kernel.org, tglx@linutronix.de X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jul 2022 22:51:47 +0100, Ben Dooks wrote: > > The functions icu_init_irq and mmp2_init_icu are exported > from this code, so declare them in the header file to avoid > the following sparse warnings: > > drivers/irqchip/irq-mmp.c:248:13: warning: symbol 'icu_init_irq' was not declared. Should it be static? > drivers/irqchip/irq-mmp.c:271:13: warning: symbol 'mmp2_init_icu' was not declared. Should it be static? > > Signed-off-by: Ben Dooks > --- > include/linux/irqchip/mmp.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/linux/irqchip/mmp.h b/include/linux/irqchip/mmp.h > index cb8455c87c8a..aa1813749a4f 100644 > --- a/include/linux/irqchip/mmp.h > +++ b/include/linux/irqchip/mmp.h > @@ -4,4 +4,7 @@ > > extern struct irq_chip icu_irq_chip; > > +extern void icu_init_irq(void); > +extern void mmp2_init_icu(void); > + > #endif /* __IRQCHIP_MMP_H */ > -- > 2.35.1 > > $ git grep -E "icu_init_irq|mmp2_init_icu" arch/arm/mach-mmp/mmp2.c: mmp2_init_icu(); arch/arm/mach-mmp/mmp2.h:extern void __init mmp2_init_icu(void); arch/arm/mach-mmp/pxa168.c: icu_init_irq(); arch/arm/mach-mmp/pxa168.h:extern void __init icu_init_irq(void); arch/arm/mach-mmp/pxa910.c: icu_init_irq(); arch/arm/mach-mmp/pxa910.h:extern void __init icu_init_irq(void); drivers/irqchip/irq-mmp.c:void __init icu_init_irq(void) drivers/irqchip/irq-mmp.c:void __init mmp2_init_icu(void) If you are going to fix this, please fix it sensibly. Thanks, M. -- Without deviation from the norm, progress is not possible.