From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF181C433EF for ; Sat, 16 Jul 2022 09:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232182AbiGPJmK (ORCPT ); Sat, 16 Jul 2022 05:42:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229776AbiGPJmI (ORCPT ); Sat, 16 Jul 2022 05:42:08 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E425718E for ; Sat, 16 Jul 2022 02:42:07 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0F3BFB8252D for ; Sat, 16 Jul 2022 09:42:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 82B13C34114; Sat, 16 Jul 2022 09:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657964524; bh=G7vrycS8jIH6nYlm9Kst7bOhdSSjtay89I3eNL5Em8E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DA8Mi6XiF5qTUvt4BGv/G+aleDLA4akgFnwjL/PYvGzxeVz43L5NNiAJsFyJltZl3 y4FtmGYe8pKMAaodrU3WY7dorT+Eax8bPm9E7qm3BTaXnXkkeWwd9GX6Z08gESmFdt J3IVyHaHxqZnmNF6PFAZ7gZvHXq9kcvDdsb9DKzDOpH/bUpo2DGCCryDZ+vZOT2XDa CJIs7hnYqUF4zqYirqODcrlrVggUBlSQqZOtyYnzkw3J8NEALn2qDP8dLFNVnQrTpN Q7xqxCWdrLN8/t/g29zlemXdgD+0z+zPlUt99ebWxyjgUP8tvNfwfB8wV7wTN6m/Pl rhUDdugLckOZQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oCeJG-007quR-7a; Sat, 16 Jul 2022 10:42:02 +0100 Date: Sat, 16 Jul 2022 10:41:59 +0100 Message-ID: <87sfn14cns.wl-maz@kernel.org> From: Marc Zyngier To: Andy Shevchenko Cc: Antonio Borneo , linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Maxime Coquelin , Alexandre Torgue Subject: Re: [PATCH v1 1/1] irqchip/stm32-exti: Use INVALID_HWIRQ definition In-Reply-To: <20220715205203.82591-1-andriy.shevchenko@linux.intel.com> References: <20220715205203.82591-1-andriy.shevchenko@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: andriy.shevchenko@linux.intel.com, antonio.borneo@foss.st.com, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, tglx@linutronix.de, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Jul 2022 21:52:03 +0100, Andy Shevchenko wrote: > > Use specific definition for invalid IRQ. It makes the > code uniform in respect to the constant used for that. > No functional change intended. > > Signed-off-by: Andy Shevchenko > --- > drivers/irqchip/irq-stm32-exti.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/irqchip/irq-stm32-exti.c b/drivers/irqchip/irq-stm32-exti.c > index a73763d475f0..a6ae9f38aaf0 100644 > --- a/drivers/irqchip/irq-stm32-exti.c > +++ b/drivers/irqchip/irq-stm32-exti.c > @@ -170,7 +170,7 @@ static const struct stm32_exti_bank *stm32mp1_exti_banks[] = { > static struct irq_chip stm32_exti_h_chip; > static struct irq_chip stm32_exti_h_chip_direct; > > -#define EXTI_INVALID_IRQ U8_MAX > +#define EXTI_INVALID_IRQ ((u8)INVALID_HWIRQ) This looks like a terrible idea. It gives the impression that you can now rely on comparing the internal data structure field to INVALID_HWIRQ. Which is of course bound to fail. To be honest, I'd rather *kill* INVALID_HWIRQ, because apart from cherryview, nobody even *checks* for this value by that name. So much for the "code uniformity"... M. -- Without deviation from the norm, progress is not possible.