From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29092C433F5 for ; Tue, 28 Sep 2021 14:30:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 130F76120C for ; Tue, 28 Sep 2021 14:30:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241296AbhI1OcR (ORCPT ); Tue, 28 Sep 2021 10:32:17 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:36036 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241265AbhI1OcH (ORCPT ); Tue, 28 Sep 2021 10:32:07 -0400 From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1632839426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=cRzCqfRi39bCLXCOKbAa6ygzqRXl17QXnGvNdRp1Xlw=; b=y8U+/g+L1NrYNPkt2L+6Quiy1ooZHDUSke0RlJXylYWUTIVREjHe1400Uf3U5QIS3vjiDT KWS/WOmhQwqHUFMFCSoD71alBh7NH5hPgNgy/vVXzWoQoqHywucVV0Hn+D6VYmVpPCkSdH lmeMu2SiN2ElvaG3yL+lGYZ1LRLj9haojYsj2PWZwTWiwHigx7s0xYaI3Va59tr7bmzk+j sMFKXF4lnZKnS2nco6YL4oinkNqXwpdz5m+cDflxltgBRGgMqvzACYOwFmdzMr1dAGe05q 83iEe0E6Jtoy+mq0yfVC6QSfYirWoT18iTtNWWb1zzOH2ag2tl04jE1HuPt52g== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1632839426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=cRzCqfRi39bCLXCOKbAa6ygzqRXl17QXnGvNdRp1Xlw=; b=fqC6yKP/yzXrljCV7mr0aCvBS3tf0BhKmzLSk/9iDuN4jVuuGxEYzjwLYFw8hT5Dv8CGpE WmvIv5yF1+i+bBCg== To: LKML Cc: Peter Zijlstra , Ingo Molnar , Peter Oskolkov , Tejun Heo , Jens Axboe Subject: sched: Remove pointless preemption disable in sched_submit_work() Date: Tue, 28 Sep 2021 16:30:26 +0200 Message-ID: <87sfxoai2l.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Neither wq_worker_sleeping() nor io_wq_worker_sleeping() require to be invoked with preemption disabled: - The worker flag checks operations only need to be serialized against the worker thread itself. - The accounting and worker pool operations are serialized with locks. which means that disabling preemption has neither a reason nor a value. Remove it. Signed-off-by: Thomas Gleixner --- kernel/sched/core.c | 2 -- 1 file changed, 2 deletions(-) --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -6327,12 +6327,10 @@ static inline void sched_submit_work(str * requires it. */ if (task_flags & (PF_WQ_WORKER | PF_IO_WORKER)) { - preempt_disable(); if (task_flags & PF_WQ_WORKER) wq_worker_sleeping(tsk); else io_wq_worker_sleeping(tsk); - preempt_enable_no_resched(); } if (tsk_is_pi_blocked(tsk))