From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AD1BC43215 for ; Wed, 20 Nov 2019 13:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B55C22506 for ; Wed, 20 Nov 2019 13:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730681AbfKTNoi (ORCPT ); Wed, 20 Nov 2019 08:44:38 -0500 Received: from mga04.intel.com ([192.55.52.120]:18835 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729025AbfKTNoi (ORCPT ); Wed, 20 Nov 2019 08:44:38 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Nov 2019 05:44:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,222,1571727600"; d="scan'208";a="196856611" Received: from um.fi.intel.com (HELO um) ([10.237.72.57]) by orsmga007.jf.intel.com with ESMTP; 20 Nov 2019 05:44:35 -0800 From: Alexander Shishkin To: Wen Yang , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Andy Shevchenko , stable@vger.kernel.org, alexander.shishkin@linux.intel.com Subject: Re: [GIT PULL 1/3] intel_th: Fix a double put_device() in error path In-Reply-To: <2e648871-b7f7-c77e-6a22-3c26ad90633b@linux.alibaba.com> References: <20191120130806.44028-1-alexander.shishkin@linux.intel.com> <20191120130806.44028-2-alexander.shishkin@linux.intel.com> <2e648871-b7f7-c77e-6a22-3c26ad90633b@linux.alibaba.com> Date: Wed, 20 Nov 2019 15:44:34 +0200 Message-ID: <87sgmid5ml.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wen Yang writes: > device_add() has increased the reference count, > > so when it returns an error, an additional call to put_device() > > is needed here to reduce the reference count. No, in case of error it also drops its reference. Regards, -- Alex