* [PATCH -next] drm: Remove set but not used variable 'gem'
@ 2019-02-15 3:35 YueHaibing
2019-02-16 0:53 ` Eric Anholt
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2019-02-15 3:35 UTC (permalink / raw)
To: Eric Anholt, David Airlie, Daniel Vetter
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/gpu/drm/vc4/vc4_txp.c: In function 'vc4_txp_connector_atomic_check':
drivers/gpu/drm/vc4/vc4_txp.c:252:29: warning:
variable 'gem' set but not used [-Wunused-but-set-variable]
struct drm_gem_cma_object *gem;
^
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/vc4/vc4_txp.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_txp.c b/drivers/gpu/drm/vc4/vc4_txp.c
index aa279b5b0de7..afb1c4ec4f18 100644
--- a/drivers/gpu/drm/vc4/vc4_txp.c
+++ b/drivers/gpu/drm/vc4/vc4_txp.c
@@ -249,7 +249,6 @@ static int vc4_txp_connector_atomic_check(struct drm_connector *conn,
struct drm_connector_state *conn_state)
{
struct drm_crtc_state *crtc_state;
- struct drm_gem_cma_object *gem;
struct drm_framebuffer *fb;
int i;
@@ -275,8 +274,6 @@ static int vc4_txp_connector_atomic_check(struct drm_connector *conn,
if (i == ARRAY_SIZE(drm_fmts))
return -EINVAL;
- gem = drm_fb_cma_get_gem_obj(fb, 0);
-
/* Pitch must be aligned on 16 bytes. */
if (fb->pitches[0] & GENMASK(3, 0))
return -EINVAL;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] drm: Remove set but not used variable 'gem'
2019-02-15 3:35 [PATCH -next] drm: Remove set but not used variable 'gem' YueHaibing
@ 2019-02-16 0:53 ` Eric Anholt
0 siblings, 0 replies; 2+ messages in thread
From: Eric Anholt @ 2019-02-16 0:53 UTC (permalink / raw)
To: YueHaibing, David Airlie, Daniel Vetter
Cc: YueHaibing, dri-devel, linux-kernel, kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 443 bytes --]
YueHaibing <yuehaibing@huawei.com> writes:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vc4/vc4_txp.c: In function 'vc4_txp_connector_atomic_check':
> drivers/gpu/drm/vc4/vc4_txp.c:252:29: warning:
> variable 'gem' set but not used [-Wunused-but-set-variable]
> struct drm_gem_cma_object *gem;
> ^
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Pushed to drm-misc-next. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-16 0:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-15 3:35 [PATCH -next] drm: Remove set but not used variable 'gem' YueHaibing
2019-02-16 0:53 ` Eric Anholt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox