From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Joe Perches <joe@perches.com>
Cc: Carmeli Tamir <carmeli.tamir@gmail.com>,
jthumshirn@suse.de, sergey.senozhatsky@gmail.com,
akpm@linux-foundation.org, axboe@kernel.dk,
martin.petersen@oracle.com, bvanassche@acm.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12)
Date: Fri, 14 Dec 2018 12:16:07 +0900 [thread overview]
Message-ID: <87sgz0dci0.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <906167f7ca975d437ff9868333d8bf1e86b934a7.camel@perches.com> (Joe Perches's message of "Mon, 10 Dec 2018 12:09:31 -0800")
Joe Perches <joe@perches.com> writes:
>>
>> -#define FAT_FIRST_ENT(s, x) ((MSDOS_SB(s)->fat_bits == 32 ? 0x0FFFFF00 : \
>> - MSDOS_SB(s)->fat_bits == 16 ? 0xFF00 : 0xF00) | (x))
>> +#define IS_FAT12(sbi) (sbi->fat_bits == 12)
>> +#define IS_FAT16(sbi) (sbi->fat_bits == 16)
>> +#define IS_FAT32(sbi) (sbi->fat_bits == 32)
>
> sbi should be parenthesized or perhaps better these should be
> static inline bool functions
Right, rather this is the bug (not hit yet though) that should be fixed.
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2018-12-14 3:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 19:41 [PATCH 0/2] fat: Added macros to determine the FAT FS variant (12/16/32bit) Carmeli Tamir
2018-12-10 19:41 ` [PATCH 1/2] fat: Moved macros that won't work without fat.h Carmeli Tamir
2018-12-10 19:41 ` [PATCH 2/2] fat: New macros to determine the FAT variant (32, 16 or 12) Carmeli Tamir
2018-12-10 20:09 ` Joe Perches
2018-12-14 3:16 ` OGAWA Hirofumi [this message]
2018-12-14 8:14 ` Tamir Carmeli
2018-12-14 9:49 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgz0dci0.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=carmeli.tamir@gmail.com \
--cc=joe@perches.com \
--cc=jthumshirn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox