From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936625AbdADRYC (ORCPT ); Wed, 4 Jan 2017 12:24:02 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:59811 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752704AbdADRX5 (ORCPT ); Wed, 4 Jan 2017 12:23:57 -0500 From: Gregory CLEMENT To: Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, vivien.didelot@savoirfairelinux.com, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Rob Herring , Mark Rutland , Russell King , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH 3/8] ARM: dts: armada-388-clearfog: Utilize new DSA binding References: <20170102022249.10657-1-f.fainelli@gmail.com> <20170102022249.10657-4-f.fainelli@gmail.com> Date: Wed, 04 Jan 2017 18:23:48 +0100 In-Reply-To: <20170102022249.10657-4-f.fainelli@gmail.com> (Florian Fainelli's message of "Sun, 1 Jan 2017 18:22:44 -0800") Message-ID: <87shoyeo2j.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On lun., janv. 02 2017, Florian Fainelli wrote: > Utilize the new DSA binding, introduced with commit 8c5ad1d6179d ("net: > dsa: Document new binding"). The legacy binding node is kept included, but is > marked disabled. > I tested this patch on mvebu/dt (I needed to reduce the context to apply the patch due to the changes made by Russell King on this file). I also set the status of the old binding to "disable" (instead of "okay"). It seems to work with the limited test did: ifconfig eth1 up udhcpc -i lan1 iperf -c mylaptop (same for lan4) However is there a way to be sure that the new binding is used? Gregory > Signed-off-by: Florian Fainelli > --- > arch/arm/boot/dts/armada-388-clearfog.dts | 65 +++++++++++++++++++++++++++++++ > 1 file changed, 65 insertions(+) > > diff --git a/arch/arm/boot/dts/armada-388-clearfog.dts b/arch/arm/boot/dts/armada-388-clearfog.dts > index 71ce201c903e..35207aa1f4ec 100644 > --- a/arch/arm/boot/dts/armada-388-clearfog.dts > +++ b/arch/arm/boot/dts/armada-388-clearfog.dts > @@ -351,6 +351,8 @@ > }; > > dsa@0 { > + status = "okay"; > + > compatible = "marvell,dsa"; > dsa,ethernet = <ð1>; > dsa,mii-bus = <&mdio>; > @@ -444,3 +446,66 @@ > status = "disabled"; > }; > }; > + > +&mdio { > + status = "okay"; > + > + switch@4 { > + compatible = "marvell,mv88e6085"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <4>; > + pinctrl-0 = <&clearfog_dsa0_clk_pins &clearfog_dsa0_pins>; > + pinctrl-names = "default"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + label = "lan5"; > + }; > + > + port@1 { > + reg = <1>; > + label = "lan4"; > + }; > + > + port@2 { > + reg = <2>; > + label = "lan3"; > + }; > + > + port@3 { > + reg = <3>; > + label = "lan2"; > + }; > + > + port@4 { > + reg = <4>; > + label = "lan1"; > + }; > + > + port@5 { > + reg = <5>; > + label = "cpu"; > + ethernet = <ð1>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + > + port@6 { > + /* 88E1512 external phy */ > + reg = <6>; > + label = "lan6"; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + }; > + }; > +}; > -- > 2.9.3 > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com