From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH] clk: pxa: Use __iomem properly and staticize lock variable
Date: Wed, 09 Nov 2016 21:18:03 +0100 [thread overview]
Message-ID: <87shr0v24k.fsf@belgarion.home> (raw)
In-Reply-To: <20161108224756.25842-1-sboyd@codeaurora.org> (Stephen Boyd's message of "Tue, 8 Nov 2016 14:47:56 -0800")
Stephen Boyd <sboyd@codeaurora.org> writes:
> This function is passed an __iomem pointer but we use a u32
> pointer instead which makes checkers like spare complain.
> Furthermore, "lock" is a pretty poor variable name for a string
> that will go into lockdep reports and the symbol isn't marked
> static. Cleanup all this.
>
> Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Most certainly.
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Cheers.
--
Robert
next prev parent reply other threads:[~2016-11-09 20:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 22:47 [PATCH] clk: pxa: Use __iomem properly and staticize lock variable Stephen Boyd
2016-11-09 20:18 ` Robert Jarzmik [this message]
2016-11-09 20:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shr0v24k.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox