From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
Sergey Yanovich <ynvich@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
James Cameron <quozl@laptop.org>,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core
Date: Thu, 06 Oct 2016 08:25:35 +0200 [thread overview]
Message-ID: <87shsa804g.fsf@belgarion.home> (raw)
In-Reply-To: <1474993396-525-1-git-send-email-robert.jarzmik@free.fr> (Robert Jarzmik's message of "Tue, 27 Sep 2016 18:23:16 +0200")
Robert Jarzmik <robert.jarzmik@free.fr> writes:
> From: Sergey Yanovich <ynvich@gmail.com>
>
> pxa2xx-uart was a separate uart platform driver. It was declaring
> the same device names and numbers as 8250 driver. As a result,
> it was impossible to use 8250 driver on PXA SoCs.
>
> Upon closer examination pxa2xx-uart turned out to be a clone of
> 8250_core driver.
>
> Workaround for Erratum #19 according to Marvel(R) PXA270M Processor
> Specification Update (April 19, 2010) is dropped. 8250_core reads
> from FIFO immediately after checking DR bit in LSR.
>
> The patch leaves the original SERIAL_PXA driver around. The original
> driver is just marked DEPRECATED in Kconfig and C source. When
> the original driver is considered safe to remove, no changes
> to SERIAL_8250 will be necessary.
>
> Compiling SERIAL_8250_CONSOLE and SERIAL_PXA_CONSOLE even without
> SERIAL_8250_PXA breaks console for SERIAL_PXA. For this reasons, the new
> and the original drivers are made mutually exclusive.
>
> Signed-off-by: Sergei Ianovich <ynvich@gmail.com>
> CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> CC: James Cameron <quozl@laptop.org>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Robert Jarzmik <robert.jarzmik@free.fr>
> CC: Russell King <linux@arm.linux.org.uk>
> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> [rebased on v4.8]
> Tested-by: Robert Jarzmik <robert.jarzmik@free.fr>
> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
Greg, can you take that into you tty tree please ?
Cheers.
--
Robert
next prev parent reply other threads:[~2016-10-06 6:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:23 [PATCH v6 RESEND] serial: rewrite pxa2xx-uart to use 8250_core Robert Jarzmik
2016-10-06 6:25 ` Robert Jarzmik [this message]
2016-10-06 7:15 ` Greg Kroah-Hartman
2016-10-26 19:49 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shsa804g.fsf@belgarion.home \
--to=robert.jarzmik@free.fr \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=quozl@laptop.org \
--cc=ynvich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox