From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753377AbcEZK3h (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 May 2016 06:29:37 -0400
Received: from mga02.intel.com ([134.134.136.20]:61921 "EHLO mga02.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751355AbcEZK3g (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 May 2016 06:29:36 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.26,367,1459839600"; 
   d="asc'?scan'208";a="110847120"
From: Felipe Balbi <balbi@kernel.org>
To: Baolin Wang <baolin.wang@linaro.org>
Cc: Greg KH <gregkh@linuxfoundation.org>, Mark Brown <broonie@kernel.org>,
        USB <linux-usb@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dwc3: gadget: Introduce dwc3_endpoint_xfer_xxx() to check endpoint type
In-Reply-To: <CAMz4kuKcL5-SHTFBiAZZOHwv_LeJC2xmxALXqBT+1iZkDFbBDQ@mail.gmail.com>
References: <7eb2c730f54f117438b6111bb63799a5d8c7249c.1464238593.git.baolin.wang@linaro.org> <87eg8pqqwx.fsf@linux.intel.com> <CAMz4kuJti6uXY6988xu-CWOr7H5hhO_=juz84LQEqLG7uFwegQ@mail.gmail.com> <8760u1qmxl.fsf@linux.intel.com> <CAMz4ku+tcaDT0MYAL2oyCbjAHUBKoy-_5ZE8LxvqkGTc1kq2LQ@mail.gmail.com> <87y46xp2yz.fsf@linux.intel.com> <CAMz4kuKcL5-SHTFBiAZZOHwv_LeJC2xmxALXqBT+1iZkDFbBDQ@mail.gmail.com>
User-Agent: Notmuch/0.22+11~g124a67e (http://notmuchmail.org) Emacs/25.0.93.2 (x86_64-pc-linux-gnu)
Date: Thu, 26 May 2016 13:27:16 +0300
Message-ID: <87shx5p117.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Baolin Wang <baolin.wang@linaro.org> writes:
> On 26 May 2016 at 17:45, Felipe Balbi <balbi@kernel.org> wrote:
>>
>> Hi,
>>
>> Baolin Wang <baolin.wang@linaro.org> writes:
>>
>> <trim>
>>
>>>> Also note that the usb_endpoint_xfer_isoc() call on line 2067 of
>>>> gadget.c (as in my testing/next from today) won't even get executed, so
>>>> we're safe there.
>>>
>>> Never will be executed? then we can remove the
>>> usb_endpoint_xfer_isoc() (line 2025) at risk?
>>>
>>> 2023         clean_busy =3D dwc3_cleanup_done_reqs(dwc, dep, event, sta=
tus);
>>> 2024         if (clean_busy && (is_xfer_complete ||
>>> 2025
>>> usb_endpoint_xfer_isoc(dep->endpoint.desc)))
>>> 2026                 dep->flags &=3D ~DWC3_EP_BUSY;
>>
>> hmm, now that I look at this again, in case of XferInProgress, we could
>> still have a problem.
>>
>> I'll fix it up in that commit I pointed you to.
>
> Great. Thanks.

fixed now:

https://git.kernel.org/cgit/linux/kernel/git/balbi/usb.git/commit/?h=3Dtest=
ing/next&id=3D983b84268656ff2686253b05097d28003bbec52f

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJXRs+EAAoJEIaOsuA1yqREEmcP/0N7ONd0OTOOU5bVURLcM70d
6fR1ereZvXYP5Upe9IUSjQkho/J4vsKVJ9kh3wESEo25F9EGmbbL0pE8YLQyCaiU
bWu8IiZL5uuE4VaiQeFkBWNAIEOh5Y/XpU0PnOrUxm1uM8hQFmThOCC9NUPt4rZ1
uUZIt8vbjAjcr1TUVvpbALx+y2Ygz6R83+YfrE380aGj/Kf9+ACvjy/jo24UvqMw
qpZQfSYx6CfidRNbD0SpFKR28e75ax33DiyAmxrLh1d2VQA0n16ThjCJ0IC9xZYb
m3RfigZ2RxVcilshRz3Yg2oykS7lGrG6vyM3MXAdHZyUXzq6++LO8emMnMnepA7P
OGBZkLjNxQv01WRHUFpsP9w6uN0HurLSspJf1DVnoxlv9FBEdgHLUmUbThqeZnMw
7cv/DIF2QLJS3moSQuSl3IEtSiNytFiNSwtUTCsWRWPdgTEbLyx8SoU/EJuAaGVl
khJYdgc2a+Ej8YXIPZmH6zwEKhOfSs0vB2HdMf1byhHLOk93tRMlFHBsi54L5LAo
jA50NA/5LR5K1RVAyHMG0Iz4KG1XY6gLuxzFT8zo7ygCZbrnX0pPjFsrLlyM3tlL
nUWb6qUZ9YZZT9TBB8I6g552RlrhHLx88S72PzUkwUOkmP6FE4uvKvrHYjoayNa2
Uy+2HI+7Vf5BQyeGNSqL
=j+Jx
-----END PGP SIGNATURE-----
--=-=-=--