From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757698AbcEDKjk (ORCPT ); Wed, 4 May 2016 06:39:40 -0400 Received: from mga14.intel.com ([192.55.52.115]:17960 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbcEDKji (ORCPT ); Wed, 4 May 2016 06:39:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,576,1455004800"; d="asc'?scan'208";a="958604407" From: Felipe Balbi To: Jim Lin Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: f_fs: Fix kernel panic for SuperSpeed In-Reply-To: <5729ADC9.3030704@nvidia.com> References: <1461321780-3226-1-git-send-email-jilin@nvidia.com> <87bn51uagb.fsf@intel.com> <571E0058.6020007@nvidia.com> <87r3dtrj7b.fsf@intel.com> <571F2BA3.6040209@nvidia.com> <871t5plya5.fsf@intel.com> <57234522.9000607@nvidia.com> <87bn4siq5c.fsf@intel.com> <5729ADC9.3030704@nvidia.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Wed, 04 May 2016 13:37:31 +0300 Message-ID: <87shxyds7o.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Jim Lin writes: >>> In f_fs.c >>> " >>> static int __ffs_data_do_os_desc(enum ffs_os_desc_type type, >>> struct usb_os_desc_header *h, void *data, >>> unsigned len, void *priv) >>> { >>> struct ffs_data *ffs =3D priv; >>> u8 length; >>> >>> ENTER(); >>> >>> switch (type) { >>> case FFS_OS_DESC_EXT_COMPAT: { >>> struct usb_ext_compat_desc *d =3D data; >>> int i; >>> >>> if (len < sizeof(*d) || >>> d->bFirstInterfaceNumber >=3D ffs->interfaces_count || >>> d->Reserved1) >>> return -EINVAL; >>> " >> that's fine, but this is only failing because something else is >> returning the wrong set of descriptors (SS vs HS). That's the bug we >> want to fix, not work around it. >> > Thanks. you're welcome, but to fix that bug we need more information. Why is composite.c using the wrong set of descriptors ? What is your setup ? Are you using an in-kernel gadget ? which one ? Using configfs or legacy gadgets ? gadgetfs ? f_fs ? How to trigger this ? Can you provide instructions and (in case of gadgetfs/ffs) code to create a gadget that hits this problem ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXKdDrAAoJEIaOsuA1yqRE3g4P/0lgS8+qB+RfdazdTfAlYBe2 4wKMpiD2x/NnwvGogZEQlPV2D5qn1cALPYA6o8kZcV/tp5Z4qVywNko4mBEYlTFB oWaXNaNHuN7OM31VOWucHW1NTYoBrQwUiQrPjJoPAmmGpSRcJEtkKv4Lwap3wkdC eimcFjwkBognRq4rhVuPsMi1/GJ4rsOcrWlUBHxT4F1Qab+mkcr4i00O5QYhgPBM rTgFcYkWcTSpSc+RBUheWB8eA7PULD2sPo3VB1OjkAsB9o/wsXPONnIcJJkTrkw6 tDIj8g8aMIz6S72IrdD5hEEpixmN+HBDSHv5LnM/QDOVDewA560iVKC5l/Atkywy 6/hDWtwshJUNRppiintExYPZoVy8xy5NJIuzpzBT2Z6MYd/WR45RFV+v1WNGRX9l UVRDKWTNeo56OIFai8e/vVJTUf09Fx3XH84BaVoYg+8z/BgEtLAg2+SlTtIwAy1C hP38DpfiFAfAD2SXDnKOJaA+0ztxqiwrD8kmvpE08D23B12FGBF9DJExG879IeAD HOH9xMIXTnQ00p49V90lDe0IZcmqTFfEtKbZ/luKxSVaw7JufYYYhpeyUbmx5m9w JwQLDpG8gj379lpLTjX7V2DuDc2NopRqE3yRSpyw3rFHEbNfdp1oEm7pvWVf34Ss Esx23yVlWkP1Gnhv489Z =Gcv0 -----END PGP SIGNATURE----- --=-=-=--