From: Kalle Valo <kvalo@codeaurora.org>
To: Lauri Kasanen <cand@gmx.com>
Cc: Christian Lamparter <chunkeey@googlemail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] carl9170: Clarify kconfig text
Date: Mon, 18 Apr 2016 18:45:09 +0300 [thread overview]
Message-ID: <87shyiyl8a.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20160416171856.1769c0e16bcc75372407e06f@gmx.com> (Lauri Kasanen's message of "Sat, 16 Apr 2016 17:18:56 +0300")
Lauri Kasanen <cand@gmx.com> writes:
> The previous text was confusing, leading readers to think this
> driver was a duplicate, and so didn't need to be enabled.
>
> After the removal of the older staging driver, this is the only
> driver in mainline for these devices.
>
> Signed-off-by: Lauri Kasanen <cand@gmx.com>
> ---
> v2: Remove the mention of the previous driver, suggested by Christian.
>
> drivers/net/wireless/ath/carl9170/Kconfig | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/Kconfig b/drivers/net/wireless/ath/carl9170/Kconfig
> index 1a796e5..2e34bae 100644
> --- a/drivers/net/wireless/ath/carl9170/Kconfig
> +++ b/drivers/net/wireless/ath/carl9170/Kconfig
> @@ -5,12 +5,10 @@ config CARL9170
> select FW_LOADER
> select CRC32
> help
> - This is another driver for the Atheros "otus" 802.11n USB devices.
> + This is the mainline driver for the Atheros "otus" 802.11n USB devices.
>
> - This driver provides more features than the original,
> - but it needs a special firmware (carl9170-1.fw) to do that.
> -
> - The firmware can be downloaded from our wiki here:
> + It needs a special firmware (carl9170-1.fw), which can be downloaded
> + from our wiki here:
> <http://wireless.kernel.org/en/users/Drivers/carl9170>
Why even mention anything about a "special firmware" as the firmware is
already available from linux-firmware.git? That's default location for
all firmware images and I think most, if not all, distros should have it
available. So wouldn't it be better not to mention anything about
firmware at all?
--
Kalle Valo
next prev parent reply other threads:[~2016-04-18 15:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-16 8:33 [PATCH] carl9170: Clarify kconfig text Lauri Kasanen
[not found] ` <1466768.7dLuLFSDol@debian64>
2016-04-16 14:18 ` [PATCH v2] " Lauri Kasanen
2016-04-16 15:32 ` Christian Lamparter
2016-04-18 15:45 ` Kalle Valo [this message]
2016-04-18 16:07 ` [PATCH v3] " Lauri Kasanen
2016-04-18 16:24 ` Christian Lamparter
2016-04-18 16:20 ` [PATCH v2] " Christian Lamparter
2016-04-18 16:42 ` Kalle Valo
2016-04-18 17:07 ` Christian Lamparter
2016-04-20 7:59 ` Kalle Valo
2016-04-20 21:11 ` [RESEND] Re: updating carl9170-1.fw in linux-firmware.git Christian Lamparter
2016-05-25 14:51 ` Ben Hutchings
2016-06-04 14:58 ` [v2] carl9170: Clarify kconfig text Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2016-04-18 16:47 [PATCH v2] " Xose Vazquez Perez
2016-04-18 17:10 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shyiyl8a.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=cand@gmx.com \
--cc=chunkeey@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox