From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756010AbcDLICk (ORCPT ); Tue, 12 Apr 2016 04:02:40 -0400 Received: from mga09.intel.com ([134.134.136.24]:40446 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbcDLICh (ORCPT ); Tue, 12 Apr 2016 04:02:37 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,472,1455004800"; d="asc'?scan'208";a="953124259" From: Felipe Balbi To: Roger Quadros Cc: tony@atomide.com, Joao.Pinto@synopsys.com, sergei.shtylyov@cogentembedded.com, peter.chen@freescale.com, jun.li@freescale.com, grygorii.strashko@ti.com, yoshihiro.shimoda.uh@renesas.com, nsekhar@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v6 07/10] usb: dwc3: gadget: Fix suspend/resume during dual-role mode In-Reply-To: <570BAC4D.8010209@ti.com> References: <1460374506-9779-1-git-send-email-rogerq@ti.com> <1460374506-9779-8-git-send-email-rogerq@ti.com> <878u0knxkp.fsf@intel.com> <570BA2AA.8030308@ti.com> <87oa9gmg2k.fsf@intel.com> <570BAC4D.8010209@ti.com> User-Agent: Notmuch/0.21+96~g9bbc54b (http://notmuchmail.org) Emacs/25.0.90.3 (x86_64-pc-linux-gnu) Date: Tue, 12 Apr 2016 11:00:23 +0300 Message-ID: <87shyrl0iw.fsf@intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Roger Quadros writes: > On 11/04/16 16:26, Felipe Balbi wrote: >>=20 >> Hi, >>=20 >> Roger Quadros writes: >>> On 11/04/16 15:23, Felipe Balbi wrote: >>>> >>>> Hi, >>>> >>>> Roger Quadros writes: >>>>> Gadget controller might not be always active during suspend/ >>>>> resume when we are operating in dual-role/otg mode. >>>>> Check if we're active and only if we are then perform >>>>> necessary actions during suspend/resume. >>>> >>>> I don't get this. If we're operating in OTG, we should have a gadget >>>> driver loaded, no ? >>>> >>> At boot gadget driver is not automatically loaded. We're still in OTG m= ode >>> but OTG state machine hasn't started. >>> System suspend/resume can still happen. >>> >>> User might also load/unload the gadget driver prior to system suspend. >>=20 >> good point, this should go in the -rc too. >>=20 > But there is no dual-role mode currently so it won't fix any bug yet :). this should be a problem even for device-only, right ? i) boot-up ii) modprobe dwc3 iii) echo mem > /sys/power/state =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXDKsYAAoJEIaOsuA1yqRE6M4P/j2sBryLB5qYW8JvrpF0zbZ9 t7OCSuiKp1/3x6aD6H8LUbKvVdcPvnn4jS7knpM2h6TBYTeN+QdEYkJ2ek76bsQN Yy8044y/gq5mr6pzQx0zcarFStuDJPELUa5TkjRaVfokjMQIUG/oVJPPL7VlxaBp 33gZ4RDpRktPnoreb96ffZ6Gbh7dwE+Hi+pfTvXwybdnea01kXsK6iqn+Gwj7DQ5 txQfnCDrLQIq9l9B8c0QK3hT0hzn+iLJB1tlu/+znhuRXOsi6h8i0gPHCDBxPinr DTP7MBI7cRJbVFlWoJCp71z2zu1sfvahqRJSdRU+aZR21IP8yKHE/aInHgrKxGZr XGZ7cHL6iPy968BRkcuaRpoxd/LHTxjJnx97fyO+AwNVjFi40mEAomsskzhhzsrY ja0hQg1iv+PyEAEiGSteP9hzdUkhKFz7yZTTyh9NBbXAgVNc0MsBzfTBF6A6pmal xy/38oHGxMMfWgITWFhD3+9IbPnAMdbTy+9wezYLCdlwYgUL582hX573ziQYv8tC HdY4UC/J2FXvoyIU/7QVmg82LR3CVM/+dthg90Hioh4VM2DpZ1AT70bJMw9fmstk OgVMPC0UvsoTxecvvtoLr/QkDuuzrFn6QCuouJ6gyOu2++BRzJnc3vV5MyucaG0v 5IMkMcMF3O5fZylW+DcB =Ln3c -----END PGP SIGNATURE----- --=-=-=--