From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753503AbcBVHRs (ORCPT ); Mon, 22 Feb 2016 02:17:48 -0500 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:26285 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbcBVHRp convert rfc822-to-8bit (ORCPT ); Mon, 22 Feb 2016 02:17:45 -0500 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Mon, 22 Feb 2016 08:17:44 +0100 X-ME-IP: 109.220.219.11 From: Robert Jarzmik To: Greg Kroah-Hartman , Sergei Ianovich Cc: linux-kernel@vger.kernel.org, Heikki Krogerus , James Cameron , Russell King , Jiri Slaby , Andy Shevchenko , Arnd Bergmann , Joachim Eastwood , Sebastian Andrzej Siewior , Scott Wood , Paul Gortmaker , Paul Burton , Mans Rullgard , Ralf Baechle , Masahiro Yamada , Peter Hurley , "open list\:SERIAL DRIVERS" Subject: Re: [PATCH v6] serial: rewrite pxa2xx-uart to use 8250_core References: <1450897204-6839-1-git-send-email-ynvich@gmail.com> <1450970122-12869-1-git-send-email-ynvich@gmail.com> <20160207062206.GB16270@kroah.com> <1456106191.2386.13.camel@gmail.com> X-URL: http://belgarath.falguerolles.org/ Date: Mon, 22 Feb 2016 08:17:33 +0100 In-Reply-To: <1456106191.2386.13.camel@gmail.com> (Sergei Ianovich's message of "Mon, 22 Feb 2016 04:56:31 +0300") Message-ID: <87si0lw6wi.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sergei Ianovich writes: > On Sat, 2016-02-06 at 22:22 -0800, Greg Kroah-Hartman wrote: >> On Thu, Dec 24, 2015 at 06:15:14PM +0300, Sergei Ianovich wrote: >> > pxa2xx-uart was a separate uart platform driver. It was declaring >> > the same device names and numbers as 8250 driver. As a result, >> > it was impossible to use 8250 driver on PXA SoCs. >> > >> > Upon closer examination pxa2xx-uart turned out to be a clone of >> > 8250_core driver. >> > >> > Workaround for Erratum #19 according to Marvel(R) PXA270M Processor >> > Specification Update (April 19, 2010) is dropped. 8250_core reads >> > from FIFO immediately after checking DR bit in LSR. >> > >> > The patch leaves the original SERIAL_PXA driver around. The >> > original >> > driver is just marked DEPRECATED in Kconfig and C source. When >> > the original driver is considered safe to remove, no changes >> > to SERIAL_8250 will be necessary. >> >> But, you just broke existing configurations, right?  The serial port is >> a different name now, are you willing to handle the angry users? > > No, the port name remains /dev/ttyS0. In fact, this conflict (both > drivers use the same name and char major) is the reason for the patch. > Noone should notice the change at runtime. There will be a warning at > compile time which should make the transition to the new driver faster. > >> If so, great, get the platform maintainer to sign off on this please and >> then resend it. If you're talking about the PXA maintainer, then : Acked-by: Robert Jarzmik I'm happy with the patch, all pxa board maintainers have been warned, and there exists a fallback solution. So let's go forward, and if people complain, let them complain and forward them to me. Cheers. -- Robert