From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752900AbbIPSuN (ORCPT ); Wed, 16 Sep 2015 14:50:13 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58632 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752486AbbIPSuL (ORCPT ); Wed, 16 Sep 2015 14:50:11 -0400 X-Sasl-enc: aW3h327YBd0atZIoSiFKGA52rzMywR+ZXx8uLjZvb3LR 1442429407 References: <87si6pfwz4.fsf@secretsauce.net> From: Dima Kogan To: linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] perf: we can now read separate debug-info files based on a build ID In-reply-to: <87si6pfwz4.fsf@secretsauce.net> Date: Wed, 16 Sep 2015 11:50:06 -0700 Message-ID: <87si6exkpt.fsf@secretsauce.net> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi. This is a gentle ping. This patch fixes a real bug, and it'd be great if it was merged. Here's a demo. This is on a recent Debian/sid box, tracing malloc() calls in emacs. The debug symbols for libc and emacs are split into separate (installed) packages, as is the norm. $ perf probe -x /lib/x86_64-linux-gnu/libc-2.19.so --add malloc $ perf record -g -eprobe_libc:malloc -p `pidof emacs` Before patch: $ perf script | head -n 10 emacs 7750 [001] 353845.297868: probe_libc:malloc: (7f4fbde59020) 7c020 malloc (/lib/x86_64-linux-gnu/libc-2.19.so) 144877 [unknown] (/usr/bin/emacs-snapshot-lucid) 144989 [unknown] (/usr/bin/emacs-snapshot-lucid) 144bcc [unknown] (/usr/bin/emacs-snapshot-lucid) 15a91b [unknown] (/usr/bin/emacs-snapshot-lucid) 99f25 [unknown] (/usr/bin/emacs-snapshot-lucid) 199211 [unknown] (/usr/bin/emacs-snapshot-lucid) 1a0c6b [unknown] (/usr/bin/emacs-snapshot-lucid) 1ed86 [unknown] (/usr/bin/emacs-snapshot-lucid) After patch: $ perf script | head -n 10 emacs 7750 [001] 353845.297868: probe_libc:malloc: (7f4fbde59020) 7c020 malloc (/lib/x86_64-linux-gnu/libc-2.19.so) 144877 allocate_string_data (/usr/bin/emacs-snapshot-lucid) 144989 make_uninit_multibyte_string (/usr/bin/emacs-snapshot-lucid) 144bcc make_uninit_string.part.18 (/usr/bin/emacs-snapshot-lucid) 15a91b make_buffer_string_both (/usr/bin/emacs-snapshot-lucid) 99f25 decode_coding_object (/usr/bin/emacs-snapshot-lucid) 199211 read_process_output (/usr/bin/emacs-snapshot-lucid) 1a0c6b wait_reading_process_output (/usr/bin/emacs-snapshot-lucid) 1ed86 sit_for (/usr/bin/emacs-snapshot-lucid)