From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758666AbbGQPeA (ORCPT ); Fri, 17 Jul 2015 11:34:00 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:33468 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757964AbbGQPd6 (ORCPT ); Fri, 17 Jul 2015 11:33:58 -0400 References: <1437046092-16363-1-git-send-email-sudipm.mukherjee@gmail.com> <1437046092-16363-5-git-send-email-sudipm.mukherjee@gmail.com> From: Jakub Sitnicki To: Sudip Mukherjee Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 5/6] staging: rtl8188eu: stop using DBG_88E In-reply-to: <1437046092-16363-5-git-send-email-sudipm.mukherjee@gmail.com> Date: Fri, 17 Jul 2015 17:33:55 +0200 Message-ID: <87si8m94t8.fsf@frog.home> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 16, 2015 at 01:28 PM CEST, Sudip Mukherjee wrote: > Stop using DBG_88E which is a custom macro for printing debugging > messages. Instead start using pr_debug and in the process define > pr_fmt. In the end, don't we want to use netdev_dbg() everywhere where we work with a struct net_device? And use dev_dbg() everywhere where we work with a struct device (or a struct usb_interface)? At least that's how I understand commit 8f26b8376faa ("checkpatch: update suggested printk conversions") description: Direct conversion of printk(KERN_... to pr_ isn't the preferred conversion when a struct net_device or struct device is available. Do you think it is worth going straight for netdev_dbg()/dev_dbg() to avoid redoing it later? > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/rtl8188eu/os_dep/usb_intf.c | 39 +++++++++++++++-------------- > 1 file changed, 20 insertions(+), 19 deletions(-) > > diff --git a/drivers/staging/rtl8188eu/os_dep/usb_intf.c b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > index 2d75c77..b245e9c 100644 > --- a/drivers/staging/rtl8188eu/os_dep/usb_intf.c > +++ b/drivers/staging/rtl8188eu/os_dep/usb_intf.c > @@ -19,6 +19,7 @@ > ******************************************************************************/ > #define _HCI_INTF_C_ > > +#define pr_fmt(fmt) "R8188EU: " fmt > #include > #include > #include If we're going to stay with pr_debug(), using KBUILD_MODNAME seems to be the convention among drivers when defining pr_fmt(): #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt Cheers, Jakub