From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Conrad Meyer <cse.cem@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes
Date: Mon, 21 Apr 2014 16:26:37 +0900 [thread overview]
Message-ID: <87sip7dtxu.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <1397526957-11471-1-git-send-email-cse.cem@gmail.com> (Conrad Meyer's message of "Mon, 14 Apr 2014 18:55:57 -0700")
Conrad Meyer <cse.cem@gmail.com> writes:
> +/*
> + * A deserialized copy of the on-disk structure laid out in struct
> + * fat_boot_sector.
> + */
> +struct fat_bios_param_block {
> + u16 fat_sector_size;
> + u8 fat_sec_per_clus;
> + u16 fat_reserved;
> + u8 fat_fats;
> + u16 fat_dir_entries;
> + u16 fat_sectors;
> + u16 fat_fat_length;
> + u32 fat_total_sect;
> +
> + u8 fat16_state;
> + u32 fat16_vol_id;
> +
> + u32 fat32_length;
> + u32 fat32_root_cluster;
> + u16 fat32_info_sector;
> + u8 fat32_state;
> + u32 fat32_vol_id;
> +
> +};
Looks good. But nobody use this structure except fat_fill_inode(). So,
please move this into inode.c.
With above last change,
Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2014-04-21 7:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-15 1:55 [PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes Conrad Meyer
2014-04-21 7:26 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sip7dtxu.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=cse.cem@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox