[PATCH] There should have a warn/log when out-of-tree module is loaded

[PATCH] There should have a warn/log when out-of-tree module is loaded

[Xudong Zhang]

I can not get any hint when I found that my kernel is tainted (out of
tree module is loaded). And I checked all loaded and loadable modules
but it showed that all of them are intree modules.
I think we need a warn when out of tree module is loaded.

Signed-off-by: Xudong Zhang <xdzhang@suse.com>
---
 kernel/module.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/kernel/module.c b/kernel/module.c
index efa1e60..f80739f 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2681,8 +2681,11 @@ static int check_modinfo(struct module *mod, struct load_info *info, int flags)
 		return -ENOEXEC;
 	}
 
-	if (!get_modinfo(info, "intree"))
+	if (!get_modinfo(info, "intree")) {
 		add_taint_module(mod, TAINT_OOT_MODULE, LOCKDEP_STILL_OK);
+		pr_warn("%s: out-of-tree module is loaded, kernel tainted.\n",
+				mod->name);
+	}
 
 	if (get_modinfo(info, "staging")) {
 		add_taint_module(mod, TAINT_CRAP, LOCKDEP_STILL_OK);
-- 
1.8.4.5

Re: [PATCH] There should have a warn/log when out-of-tree module is loaded

[Rusty Russell]

Xudong Zhang <xdzhang@suse.com> writes:
> I can not get any hint when I found that my kernel is tainted (out of
> tree module is loaded). And I checked all loaded and loadable modules
> but it showed that all of them are intree modules.
> I think we need a warn when out of tree module is loaded.
>
> Signed-off-by: Xudong Zhang <xdzhang@suse.com>

This would be an escalation.

This taint only has an effect on oops messages, and
/proc/sys/kernel/tainted.

Cheers,
Rusty.