Re: [PATCHv3 20/29] tools lib traceevent: Remove malloc_or_die from plugin_function.c

Namhyung Kim
2013-11-29T10:54:43Z

> Removing malloc_or_die calls from plugin_function.c,
> replacing them and factoring the code with standard
> realloc and error path.

[SNIP]
>
> if (cpu > cpus) {
> - if (fstack)
> - fstack = realloc(fstack, sizeof(*fstack) * (cpu + 1));
> - else
> - fstack = malloc_or_die(sizeof(*fstack) * (cpu + 1));
> + fstack = realloc(fstack, sizeof(*fstack) * (cpu + 1));

This code also has same problem..

Thanks,
Namhyung

> + if (!fstack) {
> + warning("could not allocate plugin memory\n");
> + return 0;
> + }
>
> /* Account for holes in the cpu count */
> for (i = cpus + 1; i <= cpu; i++)
> --
> 1.8.3.1
>