From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755527Ab3GYKUl (ORCPT ); Thu, 25 Jul 2013 06:20:41 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:44685 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753121Ab3GYKUj (ORCPT ); Thu, 25 Jul 2013 06:20:39 -0400 From: Luis Henriques To: Gu Zheng Cc: plagnioj@jcrosoft.com, tomi.valkeinen@ti.com, linux-fbdev@vger.kernel.org, linux-kernel Subject: Re: [PATCH] driver/vga16fb.c: remove the unused variable "dev" of function vga16fb_destroy() References: <51F09D5E.70304@cn.fujitsu.com> Date: Thu, 25 Jul 2013 11:20:34 +0100 In-Reply-To: <51F09D5E.70304@cn.fujitsu.com> (Gu Zheng's message of "Thu, 25 Jul 2013 11:37:02 +0800") Message-ID: <87siz3uej1.fsf@canonical.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Gu Zheng writes: > Commit e21d2170f36602ae2708 removed the unnecessary platform_set_drvdata(), > but left the variable "dev" unused, delete it. > > Signed-off-by: Gu Zheng > --- > drivers/video/vga16fb.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > > diff --git a/drivers/video/vga16fb.c b/drivers/video/vga16fb.c > index 830ded4..2827333 100644 > --- a/drivers/video/vga16fb.c > +++ b/drivers/video/vga16fb.c > @@ -1265,7 +1265,6 @@ static void vga16fb_imageblit(struct fb_info *info, const struct fb_image *image > > static void vga16fb_destroy(struct fb_info *info) > { > - struct platform_device *dev = container_of(info->device, struct platform_device, dev); > iounmap(info->screen_base); > fb_dealloc_cmap(&info->cmap); > /* XXX unshare VGA regions */ I'm not sure if this fix isn't already queued as I sent a similar patch a few days ago: https://lkml.org/lkml/2013/7/10/524 Cheers, -- Luis