public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, CAI Qian <caiqian@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: NULL pointer at kset_find_obj
Date: Thu, 04 Apr 2013 11:17:37 +1030	[thread overview]
Message-ID: <87sj373yvq.fsf@rustcorp.com.au> (raw)
In-Reply-To: <10041.1364984307@warthog.procyon.org.uk>

David Howells <dhowells@redhat.com> writes:
> Btw, one thing I've noticed is that sysfs appears to be able to execute code
> in the module by way of parameter alterations before the module is completely
> set up.

It's preceeded by the module parameter parsing, which can do the same
thing, so I don't think it's an issue.

> I'm not sure this is an actual problem - but it might give an
> interesting interaction with module initialisers as they might reasonably
> expect that module parameters can't change whilst they're running.

This is possible, but most changable parameters are very simple.  There
are a few users of kparam_block_sysfs_write(), but not many...

Cheers,
Rusty.

      reply	other threads:[~2013-04-04  3:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1539073339.442884.1364883991962.JavaMail.root@redhat.com>
2013-04-02  6:28 ` NULL pointer at kset_find_obj CAI Qian
2013-04-02 17:38   ` David Howells
2013-04-03  2:53     ` CAI Qian
2013-04-03  9:41       ` David Howells
2013-04-03  6:10     ` Rusty Russell
2013-04-03 10:18       ` David Howells
2013-04-04  0:47         ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sj373yvq.fsf@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=caiqian@redhat.com \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox