public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Bjørn Mork" <bjorn@mork.no>
To: Oliver Neukum <oneukum@suse.de>
Cc: Alexey ORISHKO <alexey.orishko@stericsson.com>,
	"Valdis.Kletnieks\@vt.edu" <Valdis.Kletnieks@vt.edu>,
	Dan Williams <dcbw@redhat.com>,
	Stefan Metzmacher <metze@samba.org>,
	Oliver Neukum <oliver@neukum.name>,
	"Greg Kroah-Hartman" <gregkh@suse.de>,
	"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN
Date: Fri, 03 Jun 2011 14:31:18 +0200	[thread overview]
Message-ID: <87sjrrxfjd.fsf@nemi.mork.no> (raw)
In-Reply-To: <201106031250.28041.oneukum@suse.de> (Oliver Neukum's message of "Fri, 3 Jun 2011 12:50:27 +0200")

Oliver Neukum <oneukum@suse.de> writes:

> Well, but cdc-ether usually means that you can start up dhcp and use the
> interface as a network card. Can the same be done with cdc-ncm or do you always
> need to establish a connection through a secondary interface?

Is there anything in the class definition that prevents either option,
for either protocol? No?

So, could we please kill the device guessing game?  Making decisions
based on absolute measures like "do we have a global mac address?" do
make some sense.  But guessing based on USB class does not.  That will
only tell you the protocol for the USB link. If you want more specific
device information, then you will have to look at the vid/pid. And I
assume you don't want to put all of those into the kernel when a class
driver will do, and whatever additional device specific information just
as well can be added by udev rules. Preferably created by whatever
application wishing to support the device.

But I do also assume you know all this already...



Bjørn

  parent reply	other threads:[~2011-06-03 12:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01 10:08 cdc_ncm: Ericsson F5521gw appears as usbX, while Ericsson F3507g as wwanX Stefan Metzmacher
2011-06-01 10:08 ` [PATCH] TODO FLAG_POINTTOPOINT => FLAG_WWAN? usbnet/cdc_ncm: mark ncm devices as "mobile broadband devices" with FLAG_WWAN Stefan Metzmacher
2011-06-01 10:20   ` Alexey ORISHKO
2011-06-01 10:47     ` Stefan (metze) Metzmacher
2011-06-01 11:39       ` Alexey ORISHKO
2011-06-01 11:54         ` Stefan (metze) Metzmacher
2011-06-01 12:27           ` Alexey ORISHKO
2011-06-03  9:35             ` Stefan (metze) Metzmacher
2011-06-02 22:29     ` Dan Williams
2011-06-02 22:35       ` Dan Williams
2011-06-03  0:58         ` Valdis.Kletnieks
2011-06-03  9:45           ` Alexey ORISHKO
2011-06-03 10:01             ` Oliver Neukum
2011-06-03 10:23               ` Alexey ORISHKO
2011-06-03 10:50                 ` Oliver Neukum
2011-06-03 11:47                   ` Alexey ORISHKO
2011-06-03 12:31                   ` Bjørn Mork [this message]
2011-06-03 19:24             ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjrrxfjd.fsf@nemi.mork.no \
    --to=bjorn@mork.no \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=alexey.orishko@stericsson.com \
    --cc=dcbw@redhat.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=metze@samba.org \
    --cc=netdev@vger.kernel.org \
    --cc=oliver@neukum.name \
    --cc=oneukum@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox