From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Lukas Czerner <lczerner@redhat.com>
Cc: Kyungmin Park <kmpark@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v6] fat: Batched discard support for fat
Date: Tue, 24 May 2011 21:19:47 +0900 [thread overview]
Message-ID: <87sjs4i93w.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <alpine.LFD.2.00.1105241319340.4028@dhcp-27-109.brq.redhat.com> (Lukas Czerner's message of "Tue, 24 May 2011 13:32:43 +0200 (CEST)")
Lukas Czerner <lczerner@redhat.com> writes:
>> Are you read my email? So, FAT adjust 2 blocks, ext* 1 block, and what
>> is other? The middle was guaranteed as continued? So, which is end of
>> blocks?
>
> I am sorry but I am not sure what you are asking for. Just grab the size
> of the file system or even better the size of underlying device (since
> the filesyste would not be bigger than that) and use that.
>
> Of course if you grab the count of filesystem blocks (and the file
> system does not account for the first data block) you'll end up with len
> smaller than first data block. So it might make sense to not to
> decrement the len and just start from first data block since it is not
> accounted for anyway. However it is not a big deal, is it ? Are you
> expecting any problems with this behaviour ?
What is size of file system or underlying devices? You force to find the
device which target FS is using? Even if you can get size of underlying
devices, you force to user to insane loop in size of devices?
Why can you guarantee it's not big deal in design? Why can't you admit
userland can't make optimized loop?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2011-05-24 12:19 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 10:34 [PATCH v6] fat: Batched discard support for fat Kyungmin Park
2011-03-29 5:04 ` OGAWA Hirofumi
2011-03-29 5:11 ` Kyungmin Park
2011-03-29 6:37 ` OGAWA Hirofumi
2011-03-29 6:42 ` Kyungmin Park
2011-03-29 7:28 ` OGAWA Hirofumi
2011-03-30 13:22 ` Arnd Bergmann
2011-03-30 13:50 ` Lukas Czerner
2011-03-30 13:58 ` Kyungmin Park
2011-03-30 14:45 ` Arnd Bergmann
2011-03-30 14:20 ` Arnd Bergmann
2011-03-30 14:44 ` Kyungmin Park
2011-03-30 15:06 ` Arnd Bergmann
2011-05-24 1:18 ` Kyungmin Park
2011-05-24 4:47 ` OGAWA Hirofumi
2011-05-24 5:21 ` Kyungmin Park
2011-05-24 6:39 ` OGAWA Hirofumi
2011-05-24 6:55 ` Kyungmin Park
2011-05-24 7:32 ` OGAWA Hirofumi
2011-05-24 8:54 ` Kyungmin Park
2011-05-24 9:44 ` OGAWA Hirofumi
2011-05-24 9:25 ` Lukas Czerner
2011-05-24 10:07 ` OGAWA Hirofumi
2011-05-24 10:44 ` Lukas Czerner
2011-05-24 11:14 ` OGAWA Hirofumi
2011-05-24 11:32 ` Lukas Czerner
2011-05-24 12:19 ` OGAWA Hirofumi [this message]
2011-05-24 13:30 ` Lukas Czerner
2011-05-24 14:19 ` OGAWA Hirofumi
2011-08-31 13:02 ` Kyungmin Park
2011-08-31 17:51 ` OGAWA Hirofumi
2011-10-05 14:38 ` Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjs4i93w.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=arnd@arndb.de \
--cc=kmpark@infradead.org \
--cc=lczerner@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox