From: Michal Nazarewicz <mina86@mina86.com>
To: Greg KH <greg@kroah.com>
Cc: Michal Nazarewicz <m.nazarewicz@samsung.com>,
linux-usb@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Viral Mehta <Viral.Mehta@lntinfotech.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: gadget: f_mass_storage: fix in error recovery
Date: Thu, 13 May 2010 00:16:00 +0200 [thread overview]
Message-ID: <87sk5wahr3.fsf@erwin.mina86.com> (raw)
In-Reply-To: <20100512213938.GA27648@kroah.com> (Greg KH's message of "Wed, 12 May 2010 14:39:38 -0700")
> On Wed, May 12, 2010 at 12:51:13PM +0200, Michal Nazarewicz wrote:
>> In to places in fsg_common_init() an unconditional call to kfree()
>> on common was performed in error recovery which is not a valid
>> behaviour since fsg_common structure is not always allocated by
>> fsg_common_init().
>>
>> To fix, the calls has been replaced with a goto to a proper error
>> recovery which does the correct thing.
>>
>> Also, refactored fsg_common_release() function.
>>
>> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Greg KH <greg@kroah.com> writes:
> Does this superseed your previous patch in this thread?
Yes.
The difference is with fsg_common_release() function which is
purely a style change.
--
Best regards, _ _
.o. | Liege of Serenly Enlightened Majesty of o' \,=./ `o
..o | Computer Science, Michal "mina86" Nazarewicz (o o)
ooo +--<mina86-tlen.pl>--<jid:mina86-jabber.org>--ooO--(_)--Ooo--
next prev parent reply other threads:[~2010-05-12 22:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:16 [PATCH] USB: gadget: f_mass_storage: fix in fsg_common_init() error recovery Michal Nazarewicz
2010-05-12 8:29 ` Viral Mehta
2010-05-12 9:02 ` Michał Nazarewicz
2010-05-12 9:28 ` Viral Mehta
2010-05-12 9:36 ` Viral Mehta
2010-05-12 9:57 ` Michał Nazarewicz
2010-05-12 10:33 ` Viral Mehta
2010-05-12 10:51 ` [PATCH] USB: gadget: f_mass_storage: fix in " Michal Nazarewicz
2010-05-12 12:03 ` Viral Mehta
2010-05-12 21:39 ` Greg KH
2010-05-12 22:16 ` Michal Nazarewicz [this message]
2010-05-12 9:53 ` [PATCH] USB: gadget: f_mass_storage: fix in fsg_common_init() " Michał Nazarewicz
2010-05-12 10:06 ` Viral Mehta
2010-05-12 10:34 ` Michał Nazarewicz
2010-05-12 10:37 ` Viral Mehta
2010-05-12 10:52 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sk5wahr3.fsf@erwin.mina86.com \
--to=mina86@mina86.com \
--cc=Viral.Mehta@lntinfotech.com \
--cc=greg@kroah.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox