From: Dmitry Monakhov <dmonakhov@openvz.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, jens.axboe@oracle.com, mkp@mkp.net
Subject: Re: [PATCH 4/5] blkdev: add discard payload flag
Date: Tue, 06 Apr 2010 12:29:37 +0400 [thread overview]
Message-ID: <87sk79vv9q.fsf@openvz.org> (raw)
In-Reply-To: <20100405200003.GB17589@infradead.org> (Christoph Hellwig's message of "Mon, 5 Apr 2010 16:00:03 -0400")
Christoph Hellwig <hch@infradead.org> writes:
> On Wed, Mar 24, 2010 at 08:33:07PM +0300, Dmitry Monakhov wrote:
>> Not all implementations require discard bio to be filled with one-sector
>> sized payload. Let's allocate payload only when necessary.
>
> Neither this nor the next one are really needed as I have some patches
> pending to move the payload allocation into the low level drivers.
Ok good to know. As soon as i understand on low level you know how
many memory you actually need to store a request range.
BTW Do you know any drivers which max_discard_sectors contains some
restricted value? Because my 5'th patch was aimed to optimize the case
where discard request must being spitted to several bio-s.
next prev parent reply other threads:[~2010-04-06 8:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 17:33 [PATCH 0/5] blkdev: discard optimizations v2 RESEND2 Dmitry Monakhov
2010-03-24 17:33 ` [PATCH 1/5] blkdev: pass gfp_mask and flags to blkdev_issue_flush Dmitry Monakhov
2010-03-24 17:33 ` [PATCH 2/5] blkdev: generalize flags for blkdev_issue functions Dmitry Monakhov
2010-03-24 17:33 ` [PATCH 3/5] blkdev: add blkdev_issue helper functions Dmitry Monakhov
2010-03-24 17:33 ` [PATCH 4/5] blkdev: add discard payload flag Dmitry Monakhov
2010-03-24 17:33 ` [PATCH 5/5] blkdev: optimize discard request logic Dmitry Monakhov
2010-04-05 20:00 ` [PATCH 4/5] blkdev: add discard payload flag Christoph Hellwig
2010-04-06 8:29 ` Dmitry Monakhov [this message]
2010-03-24 17:43 ` [PATCH 0/5] blkdev: discard optimizations v2 RESEND2 Jens Axboe
2010-03-24 18:00 ` Dmitry Monakhov
-- strict thread matches above, loose matches on Subject: below --
2010-03-24 17:29 [PATCH 0/5] blkdev: discard optimizations v2 RESEND Dmitry Monakhov
2010-03-24 17:29 ` [PATCH 1/5] blkdev: pass gfp_mask and flags to blkdev_issue_flush Dmitry Monakhov
[not found] ` <1269451792-5205-3-git-send-email-dmonakhov@openvz.org>
[not found] ` <1269451792-5205-4-git-send-email-dmonakhov@openvz.org>
2010-03-24 17:29 ` [PATCH 4/5] blkdev: add discard payload flag Dmitry Monakhov
2010-03-24 17:21 [PATCH 0/5] blkdev: discard optimizations v2 Dmitry Monakhov
2010-03-24 17:21 ` [PATCH 1/5] blkdev: pass gfp_mask and flags to blkdev_issue_flush Dmitry Monakhov
[not found] ` <1269451281-4944-3-git-send-email-dmonakhov@openvz.org>
[not found] ` <1269451281-4944-4-git-send-email-dmonakhov@openvz.org>
2010-03-24 17:21 ` [PATCH 4/5] blkdev: add discard payload flag Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sk79vv9q.fsf@openvz.org \
--to=dmonakhov@openvz.org \
--cc=hch@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkp@mkp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox