From: Ed L Cashin <ecashin@coraid.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, jmacbaine@gmail.com
Subject: Re: aoe fails on sparc64
Date: Mon, 19 Sep 2005 10:24:00 -0400 [thread overview]
Message-ID: <87slw1b0fz.fsf@coraid.com> (raw)
In-Reply-To: <20050916.163554.79765706.davem@davemloft.net> (David S. Miller's message of "Fri, 16 Sep 2005 16:35:54 -0700 (PDT)")
"David S. Miller" <davem@davemloft.net> writes:
> From: Ed L Cashin <ecashin@coraid.com>
> Date: Fri, 16 Sep 2005 09:36:51 -0400
>
>> I've been working with Jim MacBaine, and he reports that the patch
>> below gets rid of the problem. I don't know why. When I test
>> le64_to_cpup by itself, it works as expected.
>
> This patch should fix the bug.
>
> diff --git a/arch/sparc64/kernel/una_asm.S b/arch/sparc64/kernel/una_asm.S
> --- a/arch/sparc64/kernel/una_asm.S
> +++ b/arch/sparc64/kernel/una_asm.S
So it's OK to use the "...._to_cpup" macros with unaligned pointers?
I'm asking whether ...
1) Passing le64_to_cpup an unaligned pointer is "OK" and within the
intended use of the function. I'm having trouble finding whether
this is documented somewhere.
2) These new changes to the sparc64 unaligned access fault handling
will make it OK to leave the aoe driver the way it is in the
mainline kernel.
...
> diff --git a/arch/sparc64/kernel/unaligned.c b/arch/sparc64/kernel/unaligned.c
--
Ed L Cashin <ecashin@coraid.com>
next prev parent reply other threads:[~2005-09-19 14:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-31 13:30 aoe fails on sparc64 Jim MacBaine
2005-08-31 15:50 ` Ed L Cashin
2005-09-01 6:24 ` David S. Miller
2005-09-01 19:13 ` Ed L Cashin
2005-09-01 19:45 ` David S. Miller
2005-09-03 16:06 ` Jim MacBaine
2005-09-06 20:31 ` Ed L Cashin
2005-09-09 14:06 ` Ed L Cashin
2005-09-16 13:36 ` Ed L Cashin
2005-09-16 20:34 ` David S. Miller
2005-09-16 23:35 ` David S. Miller
2005-09-17 10:10 ` Jim MacBaine
2005-09-18 6:12 ` David S. Miller
2005-09-19 14:24 ` Ed L Cashin [this message]
2005-09-19 18:21 ` David S. Miller
2005-09-19 18:29 ` Roland Dreier
2005-09-19 18:38 ` Ed L Cashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87slw1b0fz.fsf@coraid.com \
--to=ecashin@coraid.com \
--cc=davem@davemloft.net \
--cc=jmacbaine@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox