Re: PATCH 2.5.4 i810_audio, bttv, working at all.

Martin Dalecki
2002-02-13T17:39:22Z

Linus Torvalds wrote:

>
>On Wed, 13 Feb 2002, Jeff Garzik wrote:
>
>>Applying a patch like s/virt_to_bus/virt_to_phys/ makes it more
>>difficult to find the right spots to change later.
>>
>
>Yes and no.
>
>The thing is, for architectures that care, you can just grep for
>"virt_to_phys()". It's basically _never_ the right thing to do on
>something like sparc.
>
>My personal preference would actually be to keep "virt_to_bus()" for x86
>for now, and undo the change to make it complain. Instead, make it
>complain on other architectures where it _is_ wrong, so that you don't
>have to fix up drivers that simply aren't an issue. What's the point of
>breaking some drivers that only exist on x86?
>
I think that the suggestion from Jeff Garzik, that there is currently
just too much of code
duplication for quite common cases in drivers is the right way to go.
Most of the
stuff doing the virt_to_phys is doing quite common things from a broader
point of view.

Well even worser, there is quite a lot of code replication there as well
... see for example the
ide and scsi midlayers ;-). The whole hostadapter/iobus/device stuff
handling could be made common
at least. There is no real need for different driver handler lookup
mechanisms between them.

HWIF(device)-> and Scsi_Host_Templ come into mind...