From: Thomas Gleixner <tglx@kernel.org>
To: Feng Tang <feng.tang@linux.alibaba.com>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Darren Hart <dvhart@infradead.org>,
Davidlohr Bueso <dave@stgolabs.net>,
andrealmeid@igalia.com, Shuah Khan <shuah@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Feng Tang <feng.tang@linux.alibaba.com>
Subject: Re: [PATCH] selftests/futex_requeue: Increase futex timeout to cover slow hardware
Date: Sun, 05 Jul 2026 22:04:50 +0200 [thread overview]
Message-ID: <87tsqdjj8d.ffs@fw13> (raw)
In-Reply-To: <20260703032113.535-1-feng.tang@linux.alibaba.com>
On Fri, Jul 03 2026 at 11:21, Feng Tang wrote:
> When running mixed stress tests (stess-ng, kernel selftests etc.)
> on a slow machine, futex 'requeue_multiple' case failed randomly,
> with message:
> "
> waiter failed errno 110
> not ok 2 futex_requeue many returned: 0 Success
> not ok 3 futex_requeue many returned: 0 Success
> # Planned tests != run tests (2 != 3)
> # Totals: pass:1 fail:2 xfail:0 xpass:0 skip:0 error:0
> "
>
> The process of 'requeue_multiple' case will:
> * create 10 pthreads with futex (timeout 30 ms)
> * wait 10 ms
> * start 'futex_cmp_requeue' case
>
> So there is an assumption that the 10 threads can be created in 20 ms,
> which is safe enough for normal platforms, while for slow platforms
> with stress workload, the creation could take more than 20 ms, and
> some futex will timeout and cause the case to fail.
>
> Increasing the timeout to 100 ms to cover slow platforms, which doesn't
> hurt normal platforms much.
That's just lame and it hurts because it makes testing slower. If you'd
had taken the time to search LKML for discusssions about this issue then
you'd have noticed that there is work in progress to solve that
properly.
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?h=locking/futex&id=157a9b22ff769e1a657aec6210df3ea896600eec
Thanks,
tglx
next prev parent reply other threads:[~2026-07-05 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 3:21 [PATCH] selftests/futex_requeue: Increase futex timeout to cover slow hardware Feng Tang
2026-07-05 20:04 ` Thomas Gleixner [this message]
2026-07-06 5:34 ` Feng Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsqdjj8d.ffs@fw13 \
--to=tglx@kernel.org \
--cc=andrealmeid@igalia.com \
--cc=dave@stgolabs.net \
--cc=dvhart@infradead.org \
--cc=feng.tang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox