From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.tkos.co.il (golan.tkos.co.il [84.110.109.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6234037B015 for ; Mon, 8 Jun 2026 05:43:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=84.110.109.230 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780897409; cv=none; b=pCw9BmpY9F/ogcg9EQ8lSOLc/OGYx0/ksi70nQS2FbpTHuoUDMMl1Ps8tgiSDuMzxHNp9HfRaUaQn4HgYx3PXalrgDmpNQXwvlBcYd78dl66HJwZdLfwyEdHfA+e301wkXFEIFdPVE8yMKq4OzyYsVbp3Nx2jISPVjekVOw7Nfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780897409; c=relaxed/simple; bh=AM1ed5M6OqCnBRwBSXfKQdAPtRlTw0sdW96OUh0Cns0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=SBKT3pCOTE8O9+s1moFAZ9nVnpXmrOyrqrelDbWnd2+5/0bm0UEUqFAzcnVeKy7gaKWPliH4CsEfJE9Iatm98YMcOXowYDVFni8urUCARVmU2OeyUmiuwOPtaMZGjmwofBecMbYJDv0GGxMd9wCWb1UasdBSzjasZV8zm6nxZQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il; spf=pass smtp.mailfrom=tkos.co.il; dkim=pass (2048-bit key) header.d=tkos.co.il header.i=@tkos.co.il header.b=YN5j0RaX; arc=none smtp.client-ip=84.110.109.230 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tkos.co.il Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tkos.co.il Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tkos.co.il header.i=@tkos.co.il header.b="YN5j0RaX" Received: from localhost (unknown [10.0.8.2]) by mail.tkos.co.il (Postfix) with ESMTP id BD0C6440887; Mon, 8 Jun 2026 08:35:28 +0300 (IDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tkos.co.il; s=default; t=1780896928; bh=AM1ed5M6OqCnBRwBSXfKQdAPtRlTw0sdW96OUh0Cns0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=YN5j0RaXM+1MDQg3HAEPqb9uS1mUCiKLf2p9IQqi+4BvB4Hdt1TCBfYtvXfvtAxNn 3H9yTBRXnoyHSZJo2MN/+4bPIBHAYAogbrN7Tb105WmKepHL/iA1dH7W7i93pqVSGR 77PDjLyWMZxZM60nQn0tMtSbWWHjp7W62lVtMzVKkhc4iNyWa9fo9KXJlGkj8LN/+G ct886T7kwSy7l1Tawyo7oLJmDvTSXtJE0OjiMCCY25KfhmHp0qMwarn0exg1HXr8NH OVxaCBfv1L8zOcbSP56qrx/lLtQ3ZkqE0PT8pbd+2wyFIhGODmMRgeUg6p+U0ozXta s9h8q5uXHwsPQ== From: Baruch Siach To: Ethan Nelson-Moore Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Arnd Bergmann , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= Subject: Re: [PATCH] ARM: arch/arm/kernel/signal.c: resolve set-but-not-used warning In-Reply-To: <20260608050926.88446-1-enelsonmoore@gmail.com> (Ethan Nelson-Moore's message of "Sun, 7 Jun 2026 22:09:24 -0700") References: <20260608050926.88446-1-enelsonmoore@gmail.com> User-Agent: mu4e 1.12.15; emacs 30.2 Date: Mon, 08 Jun 2026 08:36:30 +0300 Message-ID: <87tsrd8ug1.fsf@tarshish> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Hi Ethan, On Sun, Jun 07 2026, Ethan Nelson-Moore wrote: > If neither CONFIG_IWMMXT nor CONFIG_VFP are enabled (which is the case, > for example, in rpc_defconfig), the variable "aux" is set but not used, > which generates a warning during W=1 builds. Resolve this issue by only > defining the variable if it will be used. > > Signed-off-by: Ethan Nelson-Moore > --- > arch/arm/kernel/signal.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/kernel/signal.c b/arch/arm/kernel/signal.c > index 7be9188d83d9..1d015b696a76 100644 > --- a/arch/arm/kernel/signal.c > +++ b/arch/arm/kernel/signal.c > @@ -140,7 +140,9 @@ static int restore_vfp_context(char __user **auxp) > static int restore_sigframe(struct pt_regs *regs, struct sigframe __user *sf) > { > struct sigcontext context; > +#if defined(CONFIG_IWMMXT) || defined(CONFIG_VFP) > char __user *aux; __maybe_unused is a common attribute marking local variables that are not always used. I find it nicer than another layer of #ifdef. baruch > +#endif > sigset_t set; > int err; > > @@ -171,6 +173,7 @@ static int restore_sigframe(struct pt_regs *regs, struct sigframe __user *sf) > > err |= !valid_user_regs(regs); > > +#if defined(CONFIG_IWMMXT) || defined(CONFIG_VFP) > aux = (char __user *) sf->uc.uc_regspace; > #ifdef CONFIG_IWMMXT > if (err == 0) > @@ -180,6 +183,7 @@ static int restore_sigframe(struct pt_regs *regs, struct sigframe __user *sf) > if (err == 0) > err |= restore_vfp_context(&aux); > #endif > +#endif /* defined(CONFIG_IWMMXT) || defined(CONFIG_VFP) */ > > return err; > } -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -