From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2C77224AF7 for ; Thu, 4 Jun 2026 19:06:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780599989; cv=none; b=fjxYa/NZwlwLNzFMzAkkz+JZ23p8ATdtt7u/sIIFYHZxaO+CjqFrT/O5Y6dhB9idEWgEsrv4tpC2/VQPW8LfhSSP71ZlrNI0MPyCSRxW5QQYbPoqlE2Y3aCCykSTlEBl2Riw6oCLjaE3ewxmSY3SpUbnvmAmZkkvWyk7MftIZQk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780599989; c=relaxed/simple; bh=+W1LQJT8yhts4bxXjJdAsMgPk2e2O4Q3Tm8cCARKr4s=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=IHZUIwHBAevIEWb7ieSeFBw5zuk7BUEhMsQftJANT/INMM8l2UQH/yRCPPohW+XHNg2hFFZ3rWtabfsQTuKl5qUCofYB/m7nFGyNEM1ZE6/jgFYscAmEGvHJF7je0+v6yG1Vh7+tbaPT+b0EGMj/2tarqdAnKfkQ/1kqTw6Cd5g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=o089DLO2; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="o089DLO2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0EE11F00893; Thu, 4 Jun 2026 19:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780599988; bh=l8KHaMOhBUBgw4m0el962vAzG0ak9ovaAkYiBEDjAnc=; h=From:To:Subject:In-Reply-To:References:Date; b=o089DLO2cPs8LB9WUoCZpsOsLCQnNTjNnO7oqII5szWEp4YdQ48wJ/gLjmthOiy/c 01qqTuCNdu7J1cncbjY+PtUsiKnP/vYtmdRZkl53WPRJax8Drpi7A6o+OyqFOrfpxO Z5uNkJXGSfPS652K49nRTS7lNCpy3+n+98Ey+XHu3booHO9KDve2aKw4UseoWSpVis 8/q8UE/pVXshh4w2WuGYjmBH0HnqVbM3k+uxi58NnY6Hr6nFt0RrOcNlthtsADq8O+ +mo5IK4aTNwplgPL6FFjyOu6JllZKE6qGfgJ3tOyZZ/LXWu+3vGxTl7qDhgeRIo3n+ oZxLa77yTy66g== From: Thomas Gleixner To: Markus Stockhausen , linux-kernel@vger.kernel.org Subject: Re: AW: [PATCH v2 2/2] irqchip/irq-realtek-rtl: Add multicore support In-Reply-To: <056101dcf44f$10641360$312c3a20$@gmx.de> References: <20260604130627.184242-1-markus.stockhausen@gmx.de> <20260604130627.184242-3-markus.stockhausen@gmx.de> <874iji5mbi.ffs@fw13> <056101dcf44f$10641360$312c3a20$@gmx.de> Date: Thu, 04 Jun 2026 21:06:25 +0200 Message-ID: <87tsri3z2m.ffs@fw13> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Thu, Jun 04 2026 at 20:22, Markus Stockhausen wrote: >> Von: Thomas Gleixner =20 >> Gesendet: Donnerstag, 4. Juni 2026 17:59 >> An: Markus Stockhausen ; > linux-kernel@vger.kernel.org >> Cc: Markus Stockhausen >> Betreff: Re: [PATCH v2 2/2] irqchip/irq-realtek-rtl: Add multicore suppo= rt >> ... >> With that fixed you can drop this whole realtek_ictl_cpu_configurable >> dance as the core will never set a non-present CPU in the destination >> mask. It even guarantees that the CPUs in the mask are online unless >> @force =3D true. The latter is only for scenarios where pseudo per CPU >> interrupts have to be affined before a CPU goes online, so irrelevant >> for your use case. > > Thanks f=C3=BCr the explanation. That paved the way for a much=20 > simpler v3 series. BTW - We need those pseudo per CPU interrupts. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /drivers/irqchip/irq-mips-gic.c?id=3D2250db8628a0d8293ad2e0671138b848a185fb= a1 Fine, but that code makes no sense: if (force) cpu =3D cpumask_first(cpumask); else cpu =3D cpumask_first_and(cpumask, cpu_online_mask); because in the !force case @cpumask is guaranteed to be not empty and a subset of cpu_online mask. I missed that back then probably because the long since then fixed original core code could supply arbitrary masks to the drivers and my memory still stuck to this scheme. Thanks, tglx