From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
notify@kernel.org
Subject: Re: [PATCH] ALSA: seq: Restore created port information after insertion
Date: Tue, 02 Jun 2026 19:54:43 +0200 [thread overview]
Message-ID: <87tsrkygik.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260602-alsa-seq-create-port-info-fix-v1-1-eec0280131e9@gmail.com>
On Tue, 02 Jun 2026 12:55:46 +0200,
Cássio Gabriel wrote:
>
> Commit 2ee646353cd5 ("ALSA: seq: Register kernel port with full
> information") split sequencer port creation from list insertion so a
> port can be filled before it becomes visible.
>
> However, snd_seq_ioctl_create_port() still copies port->addr back to the
> ioctl argument before snd_seq_insert_port() assigns the final port
> number. A successful SNDRV_SEQ_IOCTL_CREATE_PORT without
> SNDRV_SEQ_PORT_FLG_GIVEN_PORT can therefore report port -1 to userspace.
>
> Move the ioctl address copy after successful insertion, and keep the
> default "port-%d" name assignment from overwriting a caller-provided port
> name. This restores the observable behavior from before the split while
> keeping the port populated before publication.
>
> Fixes: 2ee646353cd5 ("ALSA: seq: Register kernel port with full information")
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Thanks, applied now to for-next branch.
Takashi
prev parent reply other threads:[~2026-06-02 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 10:55 [PATCH] ALSA: seq: Restore created port information after insertion Cássio Gabriel
2026-06-02 17:54 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsrkygik.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=notify@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox