From: Takashi Iwai <tiwai@suse.de>
To: Zhang Heng <zhangheng@kylinos.cn>
Cc: Takashi Iwai <tiwai@suse.de>,
tiwai@suse.com, perex@perex.cz, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for CSL Unity BF24B
Date: Thu, 09 Apr 2026 08:28:42 +0200 [thread overview]
Message-ID: <87tstkk5ph.wl-tiwai@suse.de> (raw)
In-Reply-To: <84e98864-5858-4bb7-b62a-5b4928f2065b@kylinos.cn>
On Thu, 09 Apr 2026 07:58:21 +0200,
Zhang Heng wrote:
>
> hda-verb /dev/snd/hwC1D0 0x14 0xB 0x40
> I think this command is meaningless, so it was not written.
> hda-verb [ALC662_device] 0x01 SET_GPIO_MASK 0x03
> hda-verb [ALC662_device] 0x01 SET_GPIO_DIRECTION 0x03
> hda-verb [ALC662_device] 0x01 SET_GPIO_DATA 0x03
> sleep 1
> hda-verb [ALC662_device] 0x01 SET_GPIO_DATA 0x01
> sleep 1
> hda-verb [ALC662_device] 0x01 SET_GPIO_DATA 0x02
>
>
> This user actually used these commands and the audio output was normal.
>
> The last two commands clearly trigger the falling edge of gpio_data 0x03,
> Referring to these commands, my patch writing should be normal.
With your code, you're writing GPIO bits 0x03 3 times at each init or
resume call; at first in alc_auto_init_amp(), then toggling high and
low in the fixup. So the first write is obviously superfluous.
You should be aware of this behavior although the impact is rather
small.
Takashi
next prev parent reply other threads:[~2026-04-09 6:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 2:40 [PATCH] ALSA: hda/realtek: Add quirk for CSL Unity BF24B Zhang Heng
2026-04-09 5:09 ` Takashi Iwai
2026-04-09 5:58 ` Zhang Heng
2026-04-09 6:28 ` Takashi Iwai [this message]
2026-04-09 6:30 ` Takashi Iwai
2026-04-09 6:33 ` Zhang Heng
2026-04-09 6:47 ` Takashi Iwai
2026-04-09 7:00 ` Zhang Heng
2026-04-09 7:24 ` Takashi Iwai
2026-04-09 7:51 ` Zhang Heng
2026-04-09 7:59 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tstkk5ph.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=zhangheng@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox