From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F54938F934 for ; Wed, 1 Apr 2026 07:59:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775030392; cv=none; b=hnfY9FH7pHqu0EYO9gHLw/4ZcZdRs9WnhUvhhE6l2YnX0Nh0Kt9j72/YIoXC/WmTmBMIormPM7F0Bqnifr2Ok6xIdom0/F6Cp5be0TEbB1/uFoXACX4eOQXV1d4QHSCjsXJ3OFjk+DcW8HSIcuhfVhEI0tRVhs55g+6UBnnzPes= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775030392; c=relaxed/simple; bh=NncRNfImriZKtDYVfRK1DeQCSvRmxWQ067YgkONr/Zs=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=OsMYiwEwt4djrHcKNtAiBoUHNdTEKdMvXQb9nPDLd93ElGcLz+n1gzAV6HBiy1dU/gm8eO/EGJXJX2hMA5NvGRY54FD3YPb/6kkKfB0FtuN8stcnOD8vqWIZhVy8KYuhMuL8CyimYx8kKbTWDrdrpgBjo1v/g0QgEpF5QxDlr7c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=d5SGREbl; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=C/3cCp21; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=CnRd6gcU; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=E0mbtmoc; arc=none smtp.client-ip=195.135.223.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="d5SGREbl"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="C/3cCp21"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="CnRd6gcU"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="E0mbtmoc" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF0925BECC; Wed, 1 Apr 2026 07:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775030388; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EeAH21jFBw8UgE8ezbtsg9g4YlG44GxjnxeKCmI5y/M=; b=d5SGREblrM9jo5nq8LPuygMHClMYV7RIJK2FsptzMn+0MaSTcqDIOTYwjo9dLCe1hoWwFf rPfWtWWzx5rCzd2Q0LC38AKk8IdkxgCA8c+fl2NOooBkpUvJ7/4Fziz4ihLozqc8lkeq9B BgQo/qBmOGy8tyKAc8AoqQEOECS469Q= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775030388; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EeAH21jFBw8UgE8ezbtsg9g4YlG44GxjnxeKCmI5y/M=; b=C/3cCp21eb6w17K9EALSdceuEAXf9XP7aY597dahcFYrSbWjYh6HSpZcLG9kyNzyF+5YsS w2e8rTuYO/Ju06Dg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1775030387; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EeAH21jFBw8UgE8ezbtsg9g4YlG44GxjnxeKCmI5y/M=; b=CnRd6gcU+h+uToebmOkVGhBZOYRHe1Z3rNa1mO/Vx8o0nQ7iphYD5JKFk9qDgZ2KrIeAEG p9Rt4vgY78T51A7kcq6LW84NLvH0iQNXt0Hx3MnR1NuM6Ti5ESJZ3MytkmXmQr5t7paCxO kof+E2rk8esg/GBcyLGfL+C2tlf1AjM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1775030387; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EeAH21jFBw8UgE8ezbtsg9g4YlG44GxjnxeKCmI5y/M=; b=E0mbtmocF88ax3fWzvyOmzTUS/xT7bwkq0jMXu0fJzhqTxVLlvQObqdjjYRCgT9Qi0DeSY OTIcL8Q2N2io1DAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id A0CCD4A0B0; Wed, 1 Apr 2026 07:59:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id dLMLJnPQzGm8ZwAAD6G6ig (envelope-from ); Wed, 01 Apr 2026 07:59:47 +0000 Date: Wed, 01 Apr 2026 09:59:47 +0200 Message-ID: <87tstvqff0.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?C=E1ssio?= Gabriel Cc: Takashi Iwai , Jaroslav Kysela , Johannes Berg , linuxppc-dev@lists.ozlabs.org, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , stable@vger.kernel.org Subject: Re: [PATCH v2] ALSA: aoa: i2sbus: clear stale prepared state In-Reply-To: <20260331-aoa-i2sbus-clear-stale-active-v2-1-3764ae2889a1@gmail.com> References: <20260331-aoa-i2sbus-clear-stale-active-v2-1-3764ae2889a1@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_TO(0.00)[gmail.com]; FUZZY_RATELIMITED(0.00)[rspamd.com]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[intel.com:email,suse.de:mid] X-Spam-Flag: NO X-Spam-Score: -3.30 X-Spam-Level: On Tue, 31 Mar 2026 23:14:04 +0200, Cássio Gabriel wrote: > > The i2sbus PCM code uses pi->active to constrain the sibling stream to > an already prepared duplex format and rate in i2sbus_pcm_open(). > > That state is set from i2sbus_pcm_prepare(), but the current code only > clears it on close. As a result, the sibling stream can inherit stale > constraints after the prepared state has been torn down. > > Clear pi->active when hw_params() or hw_free() tears down the prepared > state, and set it again only after prepare succeeds. > > Replace the stale FIXME in the duplex constraint comment with a description > of the current driver behavior: i2sbus still programs a single shared > transport configuration for both directions, so mixed formats are not > supported in duplex mode. > > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202604010125.AvkWBYKI-lkp@intel.com/ > Fixes: f3d9478b2ce4 ("[ALSA] snd-aoa: add snd-aoa") > Cc: stable@vger.kernel.org > Signed-off-by: Cássio Gabriel Applied to for-next branch now. Thanks. Takashi