Re: [PATCH] genirq: Fix IRQ threads affinity VS cpuset isolated partitions

[Thomas Gleixner <tglx@linutronix.de>]

On Wed, Nov 12 2025 at 13:56, Frederic Weisbecker wrote:
> Le Mon, Nov 10, 2025 at 04:28:49PM -0500, Waiman Long a écrit :
>> This function seems to mirror what is done in irq_thread_check_affinity()
>> when the affinity cpumask is available.  But if affinity isn't defined, it
>> will make this irq kthread immune from changes in the set of isolated CPUs.
>> Should we use IRQD_AFFINITY_SET flag to check if affinity has been set and
>> then set PF_NO_SETAFFINITY only in this case?
>
> So IIUC, the cpumask_available() failure can't really happen because an allocation
> failure would make irq_alloc_descs() fail.

That's indeed a historical leftover.

> __irq_alloc_descs() -> alloc_descs() -> alloc_desc() -> init_desc() - > alloc_mask()
>
> The error doesn't seem as well handled in early_irq_init() but the desc is freed
> anyway if that happens.

Right, the insert should only happen when desc != NULL. OTOH if it fails
at that stage the kernel won't get far anyway and definitely not to the
point where these cpumasks are checked :)

> So this is just a sanity check at best.

I think we can just remove it. It does not make sense at all.

Thanks,

        tglx