From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id E270282D66
	for <linux-kernel@vger.kernel.org>; Wed, 27 Nov 2024 17:35:20 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1732728924; cv=none; b=larlesF1sYnr36fWFbZuCZAz5MwMTFFVPSGKutlFcprzwdOqg0SsQStZmE2wqON3a6F+Ans9hR06Ql2Ev6I/D9qTEihqDAyc7GHnAz2k/3qeE4bnAXYcXQ0w9ed1+SRCN2n0xQcg68XEQeQDwIhyTa7whyTEIe8k/tZQkDogndg=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1732728924; c=relaxed/simple;
	bh=Chf3C0xsICyQjM/lr4S2GUrWv4rK+LuzQVV7ahgEGvs=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=DF/FbODlH+g1gqSatheM3nCWJYgZo67yIg+VIqKPe5BcfnRjNBfcyGAduk1vGFl1OsOm4a9lyX7PpiTXtg1U/eY0/7fDTa0FTye7wdbS6pjkxqEg2kCUwLDexc7AEtnWXsevS3v2AXYoOgXxg7nMEkep1JkLvo1Ty0ZLvNa75ew=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=A6WFnalI; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=+8h1rzV7; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="A6WFnalI";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="+8h1rzV7"
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1732728918;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hE34aWHnGkcOc6Qbq7JSa1GKnMoIGGF7nTLsL4wquQ0=;
	b=A6WFnalI03t1ykGYz6V5DoIL3xBIKxBK7E02C88kwrqyRlwnyDRoLwHZB5uPQb2RUaD9it
	QRpINuZDndJQUUzuzRXkdvDEL3lndC6iIw8m6+xgx73uqsJuCTNVTuRbl+IhjXwBpx+IxO
	Er4c/uFopgP1pZ2y2hgmZjkxtdW2ZnUGg6uwdzsiz9AzOBRV3/P+gefrub32nsNYxwHJ7H
	dTgYqEL/Np5220qtKKpxHRuo9xjPJ+dWpt45F2KhhugFZkDlE3TTzcWN4Twx2GJs4Lr6Dq
	WGtKYaaSOeTeFMnHea8NEPCuxoBVP1zR/jqhc3RCTalANLduuxDIfHwUPVNLnw==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1732728918;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=hE34aWHnGkcOc6Qbq7JSa1GKnMoIGGF7nTLsL4wquQ0=;
	b=+8h1rzV7rfnrP+yTOx72bwzAe8dc2rko6ROrPx6lvYPEDBTan5NclpDZnhQPr6+pH8mPs0
	fGWhZRrKpZTB/aCg==
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Dalmas, Marcelo (GE Vernova)" <marcelo.dalmas@ge.com>,
 "jstultz@google.com" <jstultz@google.com>, "sboyd@kernel.org"
 <sboyd@kernel.org>, "linux-kernel@vger.kernel.org"
 <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ntp: fix bug in adjtimex reading time offset
In-Reply-To: <Z0dDOje96uI_t9sd@hoboy.vegasvil.org>
References: <SJ0P101MB03687BF7D5A10FD3C49C51E5F42E2@SJ0P101MB0368.NAMP101.PROD.OUTLOOK.COM>
 <87zflkydgp.ffs@tglx> <Z0dDOje96uI_t9sd@hoboy.vegasvil.org>
Date: Wed, 27 Nov 2024 18:35:18 +0100
Message-ID: <87ttbsy3zd.ffs@tglx>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Nov 27 2024 at 08:05, Richard Cochran wrote:
> On Wed, Nov 27, 2024 at 03:10:30PM +0100, Thomas Gleixner wrote:
>     The patch was generated by the following coccinelle script:
>
>     ...
>
> So I guess combining random other manual fixes into a patch that
> claims to be generated is a bad idea?

Indeed. I just figured out why the cast is there. txc::time_offset is of
type 'long long', so the division triggers a build fail on 32-bit.

It want's to be:

   txc->time_offset = div_s64(txc->time_offset, NSEC_PER_USEC);

....