From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Anna-Maria Behnsen <anna-maria@linutronix.de>,
John Stultz <jstultz@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Eric Biederman <ebiederm@xmission.com>,
Oleg Nesterov <oleg@redhat.com>
Subject: Re: [patch V5 05/26] posix-timers: Drop signal if timer has been deleted or reprogrammed
Date: Thu, 24 Oct 2024 10:40:08 +0200 [thread overview]
Message-ID: <87ttd16gif.ffs@tglx> (raw)
In-Reply-To: <ZxZJPnqsQygi6juI@localhost.localdomain>
On Mon, Oct 21 2024 at 14:29, Frederic Weisbecker wrote:
> Le Tue, Oct 01, 2024 at 10:42:06AM +0200, Thomas Gleixner a écrit :
>> No point in delivering a signal from the past. POSIX does not specify the
>> behaviour here:
>>
>> - "The effect of disarming or resetting a timer with pending expiration
>> notifications is unspecified."
>>
>> - "The disposition of pending signals for the deleted timer is unspecified."
>>
>> In both cases it is reasonable to expect that pending signals are
>> discarded. Especially in the reprogramming case it does not make sense to
>> account for previous overruns or to deliver a signal for a timer which has
>> been disarmed.
>
> The change below indeed checks if the timer has been deleted but not if
> it has been reprogrammed/disarmed/reset.
>
> Or am I missing something?
No. You are right. This is a change log left over from a previous
version. This rearm/disarm part is handled later in the series.
Thanks,
tglx
next prev parent reply other threads:[~2024-10-24 8:40 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 8:41 [patch V5 00/26] posix-timers: Cure the SIG_IGN mess Thomas Gleixner
2024-10-01 8:42 ` [patch V5 01/26] signal: Confine POSIX_TIMERS properly Thomas Gleixner
2024-10-18 12:50 ` Frederic Weisbecker
2024-10-18 21:49 ` Thomas Gleixner
2024-10-29 11:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 02/26] signal: Cleanup flush_sigqueue_mask() Thomas Gleixner
2024-10-18 13:05 ` Frederic Weisbecker
2024-10-29 11:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 03/26] posix-timers: Cure si_sys_private race Thomas Gleixner
2024-10-21 11:05 ` Frederic Weisbecker
2024-10-29 11:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 04/26] signal: Allow POSIX timer signals to be dropped Thomas Gleixner
2024-10-21 12:20 ` Frederic Weisbecker
2024-10-29 11:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 05/26] posix-timers: Drop signal if timer has been deleted or reprogrammed Thomas Gleixner
2024-10-21 12:29 ` Frederic Weisbecker
2024-10-24 8:40 ` Thomas Gleixner [this message]
2024-10-24 11:46 ` Frederic Weisbecker
2024-10-29 11:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 06/26] posix-timers: Rename k_itimer::it_requeue_pending Thomas Gleixner
2024-10-21 12:35 ` Frederic Weisbecker
2024-10-29 11:09 ` [tip: timers/core] posix-timers: Rename k_itimer:: It_requeue_pending tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 07/26] posix-timers: Add proper state tracking Thomas Gleixner
2024-10-21 13:19 ` Frederic Weisbecker
2024-10-24 8:45 ` Thomas Gleixner
2024-10-24 12:10 ` Frederic Weisbecker
2024-10-29 11:09 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2024-10-01 8:42 ` [patch V5 08/26] posix-timers: Make signal delivery consistent Thomas Gleixner
2024-10-21 14:40 ` Frederic Weisbecker
2024-10-24 8:52 ` Thomas Gleixner
2024-10-01 8:42 ` [patch V5 09/26] posix-timers: Make signal overrun accounting sensible Thomas Gleixner
2024-10-21 21:54 ` Frederic Weisbecker
2024-10-24 8:57 ` Thomas Gleixner
2024-10-24 9:10 ` Thomas Gleixner
2024-10-24 13:34 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 10/26] posix-cpu-timers: Use dedicated flag for CPU timer nanosleep Thomas Gleixner
2024-10-22 14:25 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 11/26] posix-timers: Add a refcount to struct k_itimer Thomas Gleixner
2024-10-28 14:42 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 12/26] signal: Split up __sigqueue_alloc() Thomas Gleixner
2024-10-28 16:41 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 13/26] signal: Provide posixtimer_sigqueue_init() Thomas Gleixner
2024-10-29 13:25 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 14/26] posix-timers: Store PID type in the timer Thomas Gleixner
2024-10-29 13:46 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 15/26] signal: Refactor send_sigqueue() Thomas Gleixner
2024-10-29 14:06 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 16/26] signal: Replace resched_timer logic Thomas Gleixner
2024-10-29 15:08 ` Frederic Weisbecker
2024-10-29 15:56 ` Frederic Weisbecker
2024-10-29 16:22 ` Thomas Gleixner
2024-10-29 16:34 ` Frederic Weisbecker
2024-10-29 16:55 ` Thomas Gleixner
2024-10-29 17:55 ` Frederic Weisbecker
2024-10-29 19:16 ` Thomas Gleixner
2024-10-29 20:18 ` Frederic Weisbecker
2024-10-29 16:36 ` Thomas Gleixner
2024-10-29 16:04 ` Frederic Weisbecker
2024-10-29 16:59 ` Thomas Gleixner
2024-10-01 8:42 ` [patch V5 17/26] posix-timers: Embed sigqueue in struct k_itimer Thomas Gleixner
2024-10-29 16:29 ` Frederic Weisbecker
2024-10-30 13:55 ` Frederic Weisbecker
2024-10-30 14:30 ` Thomas Gleixner
2024-10-01 8:42 ` [patch V5 18/26] signal: Cleanup unused posix-timer leftovers Thomas Gleixner
2024-10-30 11:16 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 19/26] posix-timers: Move sequence logic into struct k_itimer Thomas Gleixner
2024-10-30 13:45 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 20/26] signal: Provide ignored_posix_timers list Thomas Gleixner
2024-10-30 14:02 ` Frederic Weisbecker
2024-10-01 8:42 ` [patch V5 21/26] posix-timers: Handle ignored list on delete and exit Thomas Gleixner
2024-10-30 17:06 ` Frederic Weisbecker
2024-10-30 17:34 ` Thomas Gleixner
2024-10-30 20:58 ` Thomas Gleixner
2024-10-01 8:42 ` [patch V5 22/26] signal: Handle ignored signals in do_sigaction(action != SIG_IGN) Thomas Gleixner
2024-10-01 8:42 ` [patch V5 23/26] signal: Queue ignored posixtimers on ignore list Thomas Gleixner
2024-10-01 8:42 ` [patch V5 24/26] posix-timers: Cleanup SIG_IGN workaround leftovers Thomas Gleixner
2024-10-01 8:42 ` [patch V5 25/26] alarmtimers: Remove the throttle mechanism from alarm_forward_now() Thomas Gleixner
2024-10-01 8:42 ` [patch V5 26/26] alarmtimers: Remove return value from alarm functions Thomas Gleixner
2024-10-01 20:48 ` [patch V5 00/26] posix-timers: Cure the SIG_IGN mess Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttd16gif.ffs@tglx \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=ebiederm@xmission.com \
--cc=frederic@kernel.org \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox