* [PATCH] ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put
@ 2024-10-09 6:53 Zhu Jun
2024-10-10 12:22 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Zhu Jun @ 2024-10-09 6:53 UTC (permalink / raw)
To: tiwai; +Cc: perex, zhujun2, linux-sound, linux-kernel
The variable 'ovol' is never referenced in the code, just remove it.
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
sound/pci/ice1712/prodigy192.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/sound/pci/ice1712/prodigy192.c b/sound/pci/ice1712/prodigy192.c
index 096ec76f5304..a12dafbf53ab 100644
--- a/sound/pci/ice1712/prodigy192.c
+++ b/sound/pci/ice1712/prodigy192.c
@@ -170,14 +170,9 @@ static int stac9460_dac_vol_put(struct snd_kcontrol *kcontrol, struct snd_ctl_el
tmp = stac9460_get(ice, idx);
ovol = 0x7f - (tmp & 0x7f);
change = (ovol != nvol);
- if (change) {
- ovol = (0x7f - nvol) | (tmp & 0x80);
- /*
- dev_dbg(ice->card->dev, "DAC Volume: reg 0x%02x: 0x%02x\n",
- idx, ovol);
- */
+ if (change)
stac9460_put(ice, idx, (0x7f - nvol) | (tmp & 0x80));
- }
+
return change;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put
2024-10-09 6:53 [PATCH] ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put Zhu Jun
@ 2024-10-10 12:22 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-10-10 12:22 UTC (permalink / raw)
To: Zhu Jun; +Cc: tiwai, perex, linux-sound, linux-kernel
On Wed, 09 Oct 2024 08:53:45 +0200,
Zhu Jun wrote:
>
> The variable 'ovol' is never referenced in the code, just remove it.
>
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-10 12:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-09 6:53 [PATCH] ALSA: ice1712: Remove redundant code in stac9460_dac_vol_put Zhu Jun
2024-10-10 12:22 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox