* [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch warnings complete
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-25 9:53 ` Ashok Raj
2024-01-23 13:10 ` [patch V2 02/22] x86/platform/ce4100: Dont override x86_init.mpparse.setup_ioapic_ids Thomas Gleixner
` (20 subsequent siblings)
21 siblings, 1 reply; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Detect all possible combinations of mismatch right in the CPUID evaluation
code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/apic.h | 5 ++---
arch/x86/kernel/cpu/common.c | 15 ++-------------
arch/x86/kernel/cpu/topology_common.c | 12 ++++++++++++
3 files changed, 16 insertions(+), 16 deletions(-)
---
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -46,16 +46,15 @@ extern void x86_32_probe_apic(void);
static inline void x86_32_probe_apic(void) { }
#endif
-#ifdef CONFIG_X86_LOCAL_APIC
+extern u32 cpuid_to_apicid[];
+#ifdef CONFIG_X86_LOCAL_APIC
extern int apic_verbosity;
extern int local_apic_timer_c2_ok;
extern bool apic_is_disabled;
extern unsigned int lapic_timer_period;
-extern u32 cpuid_to_apicid[];
-
extern enum apic_intr_mode_id apic_intr_mode;
enum apic_intr_mode_id {
APIC_PIC,
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -1715,22 +1715,11 @@ static void generic_identify(struct cpui
#endif
}
-/*
- * Validate that ACPI/mptables have the same information about the
- * effective APIC id and update the package map.
- */
-static void validate_apic_and_package_id(struct cpuinfo_x86 *c)
+static void update_package_map(struct cpuinfo_x86 *c)
{
#ifdef CONFIG_SMP
unsigned int cpu = smp_processor_id();
- u32 apicid;
- apicid = apic->cpu_present_to_apicid(cpu);
-
- if (apicid != c->topo.apicid) {
- pr_err(FW_BUG "CPU%u: APIC id mismatch. Firmware: %x APIC: %x\n",
- cpu, apicid, c->topo.initial_apicid);
- }
BUG_ON(topology_update_package_map(c->topo.pkg_id, cpu));
BUG_ON(topology_update_die_map(c->topo.die_id, cpu));
#else
@@ -1921,7 +1910,7 @@ void identify_secondary_cpu(struct cpuin
#ifdef CONFIG_X86_32
enable_sep_cpu();
#endif
- validate_apic_and_package_id(c);
+ update_package_map(c);
x86_spec_ctrl_setup_ap();
update_srbds_msr();
if (boot_cpu_has_bug(X86_BUG_GDS))
--- a/arch/x86/kernel/cpu/topology_common.c
+++ b/arch/x86/kernel/cpu/topology_common.c
@@ -177,6 +177,18 @@ void cpu_parse_topology(struct cpuinfo_x
parse_topology(&tscan, false);
+ if (IS_ENABLED(CONFIG_X86_LOCAL_APIC)) {
+ if (c->topo.initial_apicid != c->topo.apicid) {
+ pr_err(FW_BUG "CPU%4u: APIC ID mismatch. CPUID: 0x%04x APIC: 0x%04x\n",
+ cpu, c->topo.initial_apicid, c->topo.apicid);
+ }
+
+ if (c->topo.apicid != cpuid_to_apicid[cpu]) {
+ pr_err(FW_BUG "CPU%4u: APIC ID mismatch. Firmware: 0x%04x APIC: 0x%04x\n",
+ cpu, cpuid_to_apicid[cpu], c->topo.apicid);
+ }
+ }
+
for (dom = TOPO_SMT_DOMAIN; dom < TOPO_MAX_DOMAIN; dom++) {
if (tscan.dom_shifts[dom] == x86_topo_system.dom_shifts[dom])
continue;
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch warnings complete
2024-01-23 13:10 ` [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch warnings complete Thomas Gleixner
@ 2024-01-25 9:53 ` Ashok Raj
2024-02-12 15:39 ` Thomas Gleixner
0 siblings, 1 reply; 26+ messages in thread
From: Ashok Raj @ 2024-01-25 9:53 UTC (permalink / raw)
To: Thomas Gleixner
Cc: LKML, x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven,
Huang Rui, Juergen Gross, Dimitri Sivanich, Sohil Mehta,
K Prateek Nayak, Kan Liang, Zhang Rui, Paul E. McKenney,
Feng Tang, Andy Shevchenko, Michael Kelley,
Peter Zijlstra (Intel), Andy Shevchenko, Wei Liu, Ashok Raj
On Tue, Jan 23, 2024 at 02:10:04PM +0100, Thomas Gleixner wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Detect all possible combinations of mismatch right in the CPUID evaluation
> code.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> ---
> arch/x86/include/asm/apic.h | 5 ++---
> arch/x86/kernel/cpu/common.c | 15 ++-------------
> arch/x86/kernel/cpu/topology_common.c | 12 ++++++++++++
> 3 files changed, 16 insertions(+), 16 deletions(-)
[snip]
> --- a/arch/x86/kernel/cpu/topology_common.c
> +++ b/arch/x86/kernel/cpu/topology_common.c
> @@ -177,6 +177,18 @@ void cpu_parse_topology(struct cpuinfo_x
>
> parse_topology(&tscan, false);
>
> + if (IS_ENABLED(CONFIG_X86_LOCAL_APIC)) {
> + if (c->topo.initial_apicid != c->topo.apicid) {
> + pr_err(FW_BUG "CPU%4u: APIC ID mismatch. CPUID: 0x%04x APIC: 0x%04x\n",
> + cpu, c->topo.initial_apicid, c->topo.apicid);
> + }
> +
> + if (c->topo.apicid != cpuid_to_apicid[cpu]) {
> + pr_err(FW_BUG "CPU%4u: APIC ID mismatch. Firmware: 0x%04x APIC: 0x%04x\n",
> + cpu, cpuid_to_apicid[cpu], c->topo.apicid);
> + }
Should we consider tainting the kernel when there is any mismatch?
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch warnings complete
2024-01-25 9:53 ` Ashok Raj
@ 2024-02-12 15:39 ` Thomas Gleixner
0 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-02-12 15:39 UTC (permalink / raw)
To: Ashok Raj
Cc: LKML, x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven,
Huang Rui, Juergen Gross, Dimitri Sivanich, Sohil Mehta,
K Prateek Nayak, Kan Liang, Zhang Rui, Paul E. McKenney,
Feng Tang, Andy Shevchenko, Michael Kelley,
Peter Zijlstra (Intel), Andy Shevchenko, Wei Liu, Ashok Raj
On Thu, Jan 25 2024 at 01:53, Ashok Raj wrote:
> On Tue, Jan 23, 2024 at 02:10:04PM +0100, Thomas Gleixner wrote:
>> From: Thomas Gleixner <tglx@linutronix.de>
>>
>> Detect all possible combinations of mismatch right in the CPUID evaluation
>> code.
>>
>> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>>
>> ---
>> arch/x86/include/asm/apic.h | 5 ++---
>> arch/x86/kernel/cpu/common.c | 15 ++-------------
>> arch/x86/kernel/cpu/topology_common.c | 12 ++++++++++++
>> 3 files changed, 16 insertions(+), 16 deletions(-)
>
> [snip]
>
>> --- a/arch/x86/kernel/cpu/topology_common.c
>> +++ b/arch/x86/kernel/cpu/topology_common.c
>> @@ -177,6 +177,18 @@ void cpu_parse_topology(struct cpuinfo_x
>>
>> parse_topology(&tscan, false);
>>
>> + if (IS_ENABLED(CONFIG_X86_LOCAL_APIC)) {
>> + if (c->topo.initial_apicid != c->topo.apicid) {
>> + pr_err(FW_BUG "CPU%4u: APIC ID mismatch. CPUID: 0x%04x APIC: 0x%04x\n",
>> + cpu, c->topo.initial_apicid, c->topo.apicid);
>> + }
>> +
>> + if (c->topo.apicid != cpuid_to_apicid[cpu]) {
>> + pr_err(FW_BUG "CPU%4u: APIC ID mismatch. Firmware: 0x%04x APIC: 0x%04x\n",
>> + cpu, cpuid_to_apicid[cpu], c->topo.apicid);
>> + }
>
> Should we consider tainting the kernel when there is any mismatch?
No strong opinion about that.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [patch V2 02/22] x86/platform/ce4100: Dont override x86_init.mpparse.setup_ioapic_ids
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
2024-01-23 13:10 ` [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch warnings complete Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 03/22] x86/ioapic: Replace some more set bit nonsense Thomas Gleixner
` (19 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
There is no point to do that. The ATOMs have an XAPIC for which this
function is a pointless exercise.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Shevchenko <andy@infradead.org>
---
arch/x86/include/asm/io_apic.h | 1 -
arch/x86/kernel/apic/io_apic.c | 2 +-
arch/x86/platform/ce4100/ce4100.c | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
---
--- a/arch/x86/include/asm/io_apic.h
+++ b/arch/x86/include/asm/io_apic.h
@@ -140,7 +140,6 @@ extern void mask_ioapic_entries(void);
extern int restore_ioapic_entries(void);
extern void setup_ioapic_ids_from_mpc(void);
-extern void setup_ioapic_ids_from_mpc_nocheck(void);
extern int mp_find_ioapic(u32 gsi);
extern int mp_find_ioapic_pin(int ioapic, u32 gsi);
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1458,7 +1458,7 @@ void restore_boot_irq_mode(void)
*
* by Matt Domsch <Matt_Domsch@dell.com> Tue Dec 21 12:25:05 CST 1999
*/
-void __init setup_ioapic_ids_from_mpc_nocheck(void)
+static void __init setup_ioapic_ids_from_mpc_nocheck(void)
{
union IO_APIC_reg_00 reg_00;
physid_mask_t phys_id_present_map;
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -139,7 +139,6 @@ void __init x86_ce4100_early_setup(void)
x86_init.resources.probe_roms = x86_init_noop;
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
x86_init.mpparse.find_smp_config = x86_init_noop;
- x86_init.mpparse.setup_ioapic_ids = setup_ioapic_ids_from_mpc_nocheck;
x86_init.pci.init = ce4100_pci_init;
x86_init.pci.init_irq = sdv_pci_init;
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 03/22] x86/ioapic: Replace some more set bit nonsense
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
2024-01-23 13:10 ` [patch V2 01/22] x86/cpu/topology: Make the APIC mismatch warnings complete Thomas Gleixner
2024-01-23 13:10 ` [patch V2 02/22] x86/platform/ce4100: Dont override x86_init.mpparse.setup_ioapic_ids Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast() Thomas Gleixner
` (18 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Yet another set_bit() operation wrapped in oring a mask.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/mpspec.h | 3 ---
arch/x86/kernel/apic/io_apic.c | 6 ++----
2 files changed, 2 insertions(+), 7 deletions(-)
---
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -86,9 +86,6 @@ typedef struct physid_mask physid_mask_t
#define physid_set(physid, map) set_bit(physid, (map).mask)
#define physid_isset(physid, map) test_bit(physid, (map).mask)
-#define physids_or(dst, src1, src2) \
- bitmap_or((dst).mask, (src1).mask, (src2).mask, MAX_LOCAL_APIC)
-
#define physids_clear(map) \
bitmap_zero((map).mask, MAX_LOCAL_APIC)
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2494,9 +2494,8 @@ unsigned int arch_dynirq_lower_bound(uns
#ifdef CONFIG_X86_32
static int io_apic_get_unique_id(int ioapic, int apic_id)
{
- union IO_APIC_reg_00 reg_00;
static physid_mask_t apic_id_map = PHYSID_MASK_NONE;
- physid_mask_t tmp;
+ union IO_APIC_reg_00 reg_00;
unsigned long flags;
int i = 0;
@@ -2542,8 +2541,7 @@ static int io_apic_get_unique_id(int ioa
apic_id = i;
}
- physid_set_mask_of_physid(apic_id, &tmp);
- physids_or(apic_id_map, apic_id_map, tmp);
+ physid_set(apic_id, apic_id_map);
if (reg_00.bits.ID != apic_id) {
reg_00.bits.ID = apic_id;
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast()
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (2 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 03/22] x86/ioapic: Replace some more set bit nonsense Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-02-01 22:24 ` Sohil Mehta
2024-01-23 13:10 ` [patch V2 05/22] x86/ioapic: Make io_apic_get_unique_id() simpler Thomas Gleixner
` (17 subsequent siblings)
21 siblings, 1 reply; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
There is no point for this function. The only case where this is used is
when there is no XAPIC available, which means the broadcast address is 0xF.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Shevchenko <andy@infradead.org>
---
arch/x86/kernel/apic/apic.c | 10 --------
arch/x86/kernel/apic/io_apic.c | 47 ++++++++++++++++++-----------------------
2 files changed, 21 insertions(+), 36 deletions(-)
---
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -261,16 +261,6 @@ u64 native_apic_icr_read(void)
return icr1 | ((u64)icr2 << 32);
}
-#ifdef CONFIG_X86_32
-/**
- * get_physical_broadcast - Get number of physical broadcast IDs
- */
-int get_physical_broadcast(void)
-{
- return modern_apic() ? 0xff : 0xf;
-}
-#endif
-
/**
* lapic_get_maxlvt - get the maximum number of local vector table entries
*/
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1460,12 +1460,12 @@ void restore_boot_irq_mode(void)
*/
static void __init setup_ioapic_ids_from_mpc_nocheck(void)
{
- union IO_APIC_reg_00 reg_00;
physid_mask_t phys_id_present_map;
- int ioapic_idx;
- int i;
+ const u32 broadcast_id = 0xF;
+ union IO_APIC_reg_00 reg_00;
unsigned char old_id;
unsigned long flags;
+ int ioapic_idx, i;
/*
* This is broken; anything with a real cpu count has to
@@ -1484,11 +1484,10 @@ static void __init setup_ioapic_ids_from
old_id = mpc_ioapic_id(ioapic_idx);
- if (mpc_ioapic_id(ioapic_idx) >= get_physical_broadcast()) {
- printk(KERN_ERR "BIOS bug, IO-APIC#%d ID is %d in the MPC table!...\n",
- ioapic_idx, mpc_ioapic_id(ioapic_idx));
- printk(KERN_ERR "... fixing up to %d. (tell your hw vendor)\n",
- reg_00.bits.ID);
+ if (mpc_ioapic_id(ioapic_idx) >= broadcast_id) {
+ pr_err(FW_BUG "IO-APIC#%d ID is %d in the MPC table!...\n",
+ ioapic_idx, mpc_ioapic_id(ioapic_idx));
+ pr_err("... fixing up to %d. (tell your hw vendor)\n", reg_00.bits.ID);
ioapics[ioapic_idx].mp_config.apicid = reg_00.bits.ID;
}
@@ -1499,15 +1498,14 @@ static void __init setup_ioapic_ids_from
*/
if (apic->check_apicid_used(&phys_id_present_map,
mpc_ioapic_id(ioapic_idx))) {
- printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
+ pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
ioapic_idx, mpc_ioapic_id(ioapic_idx));
- for (i = 0; i < get_physical_broadcast(); i++)
+ for (i = 0; i < broadcast_id; i++)
if (!physid_isset(i, phys_id_present_map))
break;
- if (i >= get_physical_broadcast())
+ if (i >= broadcast_id)
panic("Max APIC ID exceeded!\n");
- printk(KERN_ERR "... fixing up to %d. (tell your hw vendor)\n",
- i);
+ pr_err("... fixing up to %d. (tell your hw vendor)\n", i);
physid_set(i, phys_id_present_map);
ioapics[ioapic_idx].mp_config.apicid = i;
} else {
@@ -2209,7 +2207,7 @@ static inline void __init check_timer(vo
* 8259A.
*/
if (pin1 == -1) {
- panic_if_irq_remap("BIOS bug: timer not connected to IO-APIC");
+ panic_if_irq_remap(FW_BUG "Timer not connected to IO-APIC");
pin1 = pin2;
apic1 = apic2;
no_pin1 = 1;
@@ -2495,6 +2493,7 @@ unsigned int arch_dynirq_lower_bound(uns
static int io_apic_get_unique_id(int ioapic, int apic_id)
{
static physid_mask_t apic_id_map = PHYSID_MASK_NONE;
+ const u32 broadcast_id = 0xF;
union IO_APIC_reg_00 reg_00;
unsigned long flags;
int i = 0;
@@ -2515,9 +2514,9 @@ static int io_apic_get_unique_id(int ioa
reg_00.raw = io_apic_read(ioapic, 0);
raw_spin_unlock_irqrestore(&ioapic_lock, flags);
- if (apic_id >= get_physical_broadcast()) {
- printk(KERN_WARNING "IOAPIC[%d]: Invalid apic_id %d, trying "
- "%d\n", ioapic, apic_id, reg_00.bits.ID);
+ if (apic_id >= broadcast_id) {
+ pr_warn("IOAPIC[%d]: Invalid apic_id %d, trying %d\n",
+ ioapic, apic_id, reg_00.bits.ID);
apic_id = reg_00.bits.ID;
}
@@ -2527,17 +2526,15 @@ static int io_apic_get_unique_id(int ioa
*/
if (apic->check_apicid_used(&apic_id_map, apic_id)) {
- for (i = 0; i < get_physical_broadcast(); i++) {
+ for (i = 0; i < broadcast_id; i++) {
if (!apic->check_apicid_used(&apic_id_map, i))
break;
}
- if (i == get_physical_broadcast())
+ if (i == broadcast_id)
panic("Max apic_id exceeded!\n");
- printk(KERN_WARNING "IOAPIC[%d]: apic_id %d already used, "
- "trying %d\n", ioapic, apic_id, i);
-
+ pr_warn("IOAPIC[%d]: apic_id %d already used, trying %d\n", ioapic, apic_id, i);
apic_id = i;
}
@@ -2567,11 +2564,9 @@ static int io_apic_get_unique_id(int ioa
static u8 io_apic_unique_id(int idx, u8 id)
{
- if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) &&
- !APIC_XAPIC(boot_cpu_apic_version))
+ if ((boot_cpu_data.x86_vendor == X86_VENDOR_INTEL) && !APIC_XAPIC(boot_cpu_apic_version))
return io_apic_get_unique_id(idx, id);
- else
- return id;
+ return id;
}
#else
static u8 io_apic_unique_id(int idx, u8 id)
^ permalink raw reply [flat|nested] 26+ messages in thread* Re: [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast()
2024-01-23 13:10 ` [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast() Thomas Gleixner
@ 2024-02-01 22:24 ` Sohil Mehta
0 siblings, 0 replies; 26+ messages in thread
From: Sohil Mehta @ 2024-02-01 22:24 UTC (permalink / raw)
To: Thomas Gleixner, LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, K Prateek Nayak, Kan Liang,
Zhang Rui, Paul E. McKenney, Feng Tang, Andy Shevchenko,
Michael Kelley, Peter Zijlstra (Intel), Andy Shevchenko, Wei Liu
On 1/23/2024 5:10 AM, Thomas Gleixner wrote:
> --- a/arch/x86/kernel/apic/io_apic.c
> +++ b/arch/x86/kernel/apic/io_apic.c
> @@ -1499,15 +1498,14 @@ static void __init setup_ioapic_ids_from
> */
> if (apic->check_apicid_used(&phys_id_present_map,
> mpc_ioapic_id(ioapic_idx))) {
> - printk(KERN_ERR "BIOS bug, IO-APIC#%d ID %d is already used!...\n",
> + pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
> ioapic_idx, mpc_ioapic_id(ioapic_idx));
The second line could be aligned to match the open parenthesis.
^ permalink raw reply [flat|nested] 26+ messages in thread
* [patch V2 05/22] x86/ioapic: Make io_apic_get_unique_id() simpler
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (3 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 04/22] x86/apic: Get rid of get_physical_broadcast() Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 06/22] x86/ioapic: Simplify setup_ioapic_ids_from_mpc_nocheck() Thomas Gleixner
` (16 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
No need to go through APIC callbacks. It's already established that this is
an ancient APIC. So just copy the present mask and use the direct physid*
functions all over the place.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/apic/io_apic.c | 22 +++++-----------------
1 file changed, 5 insertions(+), 17 deletions(-)
---
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -2498,17 +2498,9 @@ static int io_apic_get_unique_id(int ioa
unsigned long flags;
int i = 0;
- /*
- * The P4 platform supports up to 256 APIC IDs on two separate APIC
- * buses (one for LAPICs, one for IOAPICs), where predecessors only
- * supports up to 16 on one shared APIC bus.
- *
- * TBD: Expand LAPIC/IOAPIC support on P4-class systems to take full
- * advantage of new APIC bus architecture.
- */
-
+ /* Initialize the ID map */
if (physids_empty(apic_id_map))
- apic->ioapic_phys_id_map(&phys_cpu_present_map, &apic_id_map);
+ apic_id_map = phys_cpu_present_map;
raw_spin_lock_irqsave(&ioapic_lock, flags);
reg_00.raw = io_apic_read(ioapic, 0);
@@ -2520,14 +2512,10 @@ static int io_apic_get_unique_id(int ioa
apic_id = reg_00.bits.ID;
}
- /*
- * Every APIC in a system must have a unique ID or we get lots of nice
- * 'stuck on smp_invalidate_needed IPI wait' messages.
- */
- if (apic->check_apicid_used(&apic_id_map, apic_id)) {
-
+ /* Every APIC in a system must have a unique ID */
+ if (physid_isset(apic_id, apic_id_map)) {
for (i = 0; i < broadcast_id; i++) {
- if (!apic->check_apicid_used(&apic_id_map, i))
+ if (!physid_isset(i, apic_id_map))
break;
}
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 06/22] x86/ioapic: Simplify setup_ioapic_ids_from_mpc_nocheck()
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (4 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 05/22] x86/ioapic: Make io_apic_get_unique_id() simpler Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 07/22] x86/apic: Remove check_apicid_used() and ioapic_phys_id_map() Thomas Gleixner
` (15 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
No need to go through APIC callbacks. It's already established that this is
an ancient APIC. So just copy the present mask and use the direct physid*
functions all over the place.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/apic/io_apic.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
---
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1471,7 +1471,7 @@ static void __init setup_ioapic_ids_from
* This is broken; anything with a real cpu count has to
* circumvent this idiocy regardless.
*/
- apic->ioapic_phys_id_map(&phys_cpu_present_map, &phys_id_present_map);
+ phys_id_present_map = phys_cpu_present_map;
/*
* Set the IOAPIC ID to the value stored in the MPC table.
@@ -1496,8 +1496,7 @@ static void __init setup_ioapic_ids_from
* system must have a unique ID or we get lots of nice
* 'stuck on smp_invalidate_needed IPI wait' messages.
*/
- if (apic->check_apicid_used(&phys_id_present_map,
- mpc_ioapic_id(ioapic_idx))) {
+ if (physid_isset(mpc_ioapic_id(ioapic_idx), phys_id_present_map)) {
pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
ioapic_idx, mpc_ioapic_id(ioapic_idx));
for (i = 0; i < broadcast_id; i++)
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 07/22] x86/apic: Remove check_apicid_used() and ioapic_phys_id_map()
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (5 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 06/22] x86/ioapic: Simplify setup_ioapic_ids_from_mpc_nocheck() Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 08/22] x86/mpparse: Rename default_find_smp_config() Thomas Gleixner
` (14 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
No more users.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/apic.h | 3 ---
arch/x86/include/asm/mpspec.h | 6 ------
arch/x86/kernel/apic/apic_noop.c | 2 --
arch/x86/kernel/apic/bigsmp_32.c | 13 -------------
arch/x86/kernel/apic/probe_32.c | 2 --
arch/x86/kernel/apic/x2apic_cluster.c | 2 --
6 files changed, 28 deletions(-)
---
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -290,9 +290,7 @@ struct apic {
int (*acpi_madt_oem_check)(char *oem_id, char *oem_table_id);
bool (*apic_id_registered)(void);
- bool (*check_apicid_used)(physid_mask_t *map, u32 apicid);
void (*init_apic_ldr)(void);
- void (*ioapic_phys_id_map)(physid_mask_t *phys_map, physid_mask_t *retmap);
u32 (*cpu_present_to_apicid)(int mps_cpu);
u32 (*get_apic_id)(u32 id);
@@ -525,7 +523,6 @@ extern int default_apic_id_valid(u32 api
extern u32 apic_default_calc_apicid(unsigned int cpu);
extern u32 apic_flat_calc_apicid(unsigned int cpu);
-extern void default_ioapic_phys_id_map(physid_mask_t *phys_map, physid_mask_t *retmap);
extern u32 default_cpu_present_to_apicid(int mps_cpu);
void apic_send_nmi_to_offline_cpu(unsigned int cpu);
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -92,12 +92,6 @@ typedef struct physid_mask physid_mask_t
#define physids_empty(map) \
bitmap_empty((map).mask, MAX_LOCAL_APIC)
-static inline void physids_promote(unsigned long physids, physid_mask_t *map)
-{
- physids_clear(*map);
- map->mask[0] = physids;
-}
-
static inline void physid_set_mask_of_physid(int physid, physid_mask_t *map)
{
physids_clear(*map);
--- a/arch/x86/kernel/apic/apic_noop.c
+++ b/arch/x86/kernel/apic/apic_noop.c
@@ -50,8 +50,6 @@ struct apic apic_noop __ro_after_init =
.disable_esr = 0,
- .check_apicid_used = default_check_apicid_used,
- .ioapic_phys_id_map = default_ioapic_phys_id_map,
.cpu_present_to_apicid = default_cpu_present_to_apicid,
.max_apic_id = 0xFE,
--- a/arch/x86/kernel/apic/bigsmp_32.c
+++ b/arch/x86/kernel/apic/bigsmp_32.c
@@ -18,17 +18,6 @@ static u32 bigsmp_get_apic_id(u32 x)
return (x >> 24) & 0xFF;
}
-static bool bigsmp_check_apicid_used(physid_mask_t *map, u32 apicid)
-{
- return false;
-}
-
-static void bigsmp_ioapic_phys_id_map(physid_mask_t *phys_map, physid_mask_t *retmap)
-{
- /* For clustered we don't have a good way to do this yet - hack */
- physids_promote(0xFFL, retmap);
-}
-
static void bigsmp_send_IPI_allbutself(int vector)
{
default_send_IPI_mask_allbutself_phys(cpu_online_mask, vector);
@@ -79,8 +68,6 @@ static struct apic apic_bigsmp __ro_afte
.disable_esr = 1,
- .check_apicid_used = bigsmp_check_apicid_used,
- .ioapic_phys_id_map = bigsmp_ioapic_phys_id_map,
.cpu_present_to_apicid = default_cpu_present_to_apicid,
.max_apic_id = 0xFE,
--- a/arch/x86/kernel/apic/probe_32.c
+++ b/arch/x86/kernel/apic/probe_32.c
@@ -44,9 +44,7 @@ static struct apic apic_default __ro_aft
.disable_esr = 0,
- .check_apicid_used = default_check_apicid_used,
.init_apic_ldr = default_init_apic_ldr,
- .ioapic_phys_id_map = default_ioapic_phys_id_map,
.cpu_present_to_apicid = default_cpu_present_to_apicid,
.max_apic_id = 0xFE,
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -231,9 +231,7 @@ static struct apic apic_x2apic_cluster _
.disable_esr = 0,
- .check_apicid_used = NULL,
.init_apic_ldr = init_x2apic_ldr,
- .ioapic_phys_id_map = NULL,
.cpu_present_to_apicid = default_cpu_present_to_apicid,
.max_apic_id = UINT_MAX,
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 08/22] x86/mpparse: Rename default_find_smp_config()
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (6 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 07/22] x86/apic: Remove check_apicid_used() and ioapic_phys_id_map() Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 09/22] x86/mpparse: Provide separate early/late callbacks Thomas Gleixner
` (13 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
MPTABLE is no longer the default SMP configuration mechanism. Rename it to
mpparse_find_mptable() because that's what it does.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/mpspec.h | 13 ++++---------
arch/x86/include/asm/x86_init.h | 4 ++--
arch/x86/kernel/mpparse.c | 2 +-
arch/x86/kernel/setup.c | 6 ++----
arch/x86/kernel/x86_init.c | 2 +-
arch/x86/platform/ce4100/ce4100.c | 2 +-
arch/x86/platform/intel-mid/intel-mid.c | 2 +-
arch/x86/xen/smp_pv.c | 2 +-
8 files changed, 13 insertions(+), 20 deletions(-)
---
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -56,21 +56,16 @@ static inline void early_get_smp_config(
x86_init.mpparse.get_smp_config(1);
}
-static inline void find_smp_config(void)
-{
- x86_init.mpparse.find_smp_config();
-}
-
#ifdef CONFIG_X86_MPPARSE
extern void e820__memblock_alloc_reserved_mpc_new(void);
extern int enable_update_mptable;
-extern void default_find_smp_config(void);
+extern void mpparse_find_mptable(void);
extern void default_get_smp_config(unsigned int early);
#else
static inline void e820__memblock_alloc_reserved_mpc_new(void) { }
-#define enable_update_mptable 0
-#define default_find_smp_config x86_init_noop
-#define default_get_smp_config x86_init_uint_noop
+#define enable_update_mptable 0
+#define mpparse_find_mptable x86_init_noop
+#define default_get_smp_config x86_init_uint_noop
#endif
int generic_processor_info(int apicid);
--- a/arch/x86/include/asm/x86_init.h
+++ b/arch/x86/include/asm/x86_init.h
@@ -15,12 +15,12 @@ struct irq_domain;
/**
* struct x86_init_mpparse - platform specific mpparse ops
* @setup_ioapic_ids: platform specific ioapic id override
- * @find_smp_config: find the smp configuration
+ * @find_mptable: Find MPTABLE early to reserve the memory region
* @get_smp_config: get the smp configuration
*/
struct x86_init_mpparse {
void (*setup_ioapic_ids)(void);
- void (*find_smp_config)(void);
+ void (*find_mptable)(void);
void (*get_smp_config)(unsigned int early);
};
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -587,7 +587,7 @@ static int __init smp_scan_config(unsign
return ret;
}
-void __init default_find_smp_config(void)
+void __init mpparse_find_mptable(void)
{
unsigned int address;
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -970,10 +970,8 @@ void __init setup_arch(char **cmdline_p)
high_memory = (void *)__va(max_pfn * PAGE_SIZE - 1) + 1;
#endif
- /*
- * Find and reserve possible boot-time SMP configuration:
- */
- find_smp_config();
+ /* Find and reserve MPTABLE area */
+ x86_init.mpparse.find_mptable();
early_alloc_pgt_buf();
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -70,7 +70,7 @@ struct x86_init_ops x86_init __initdata
.mpparse = {
.setup_ioapic_ids = x86_init_noop,
- .find_smp_config = default_find_smp_config,
+ .find_mptable = mpparse_find_mptable,
.get_smp_config = default_get_smp_config,
},
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -138,7 +138,7 @@ void __init x86_ce4100_early_setup(void)
x86_init.oem.arch_setup = sdv_arch_setup;
x86_init.resources.probe_roms = x86_init_noop;
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
- x86_init.mpparse.find_smp_config = x86_init_noop;
+ x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.pci.init = ce4100_pci_init;
x86_init.pci.init_irq = sdv_pci_init;
--- a/arch/x86/platform/intel-mid/intel-mid.c
+++ b/arch/x86/platform/intel-mid/intel-mid.c
@@ -118,7 +118,7 @@ void __init x86_intel_mid_early_setup(vo
machine_ops.emergency_restart = intel_mid_reboot;
/* Avoid searching for BIOS MP tables */
- x86_init.mpparse.find_smp_config = x86_init_noop;
+ x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
set_bit(MP_BUS_ISA, mp_bus_not_pci);
}
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -455,6 +455,6 @@ void __init xen_smp_init(void)
smp_ops = xen_smp_ops;
/* Avoid searching for BIOS MP tables */
- x86_init.mpparse.find_smp_config = x86_init_noop;
+ x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.get_smp_config = _get_smp_config;
}
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 09/22] x86/mpparse: Provide separate early/late callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (7 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 08/22] x86/mpparse: Rename default_find_smp_config() Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 10/22] x86/mpparse: Prepare for callback separation Thomas Gleixner
` (12 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
The early argument of x86_init::mpparse::get_smp_config() is more than
confusing. Provide two callbacks, one for each purpose.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/x86_init.h | 4 ++++
1 file changed, 4 insertions(+)
---
--- a/arch/x86/include/asm/x86_init.h
+++ b/arch/x86/include/asm/x86_init.h
@@ -17,11 +17,15 @@ struct irq_domain;
* @setup_ioapic_ids: platform specific ioapic id override
* @find_mptable: Find MPTABLE early to reserve the memory region
* @get_smp_config: get the smp configuration
+ * @early_parse_smp_cfg: Parse the SMP configuration data early before initmem_init()
+ * @parse_smp_cfg: Parse the SMP configuration data
*/
struct x86_init_mpparse {
void (*setup_ioapic_ids)(void);
void (*find_mptable)(void);
void (*get_smp_config)(unsigned int early);
+ void (*early_parse_smp_cfg)(void);
+ void (*parse_smp_cfg)(void);
};
/**
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 10/22] x86/mpparse: Prepare for callback separation
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (8 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 09/22] x86/mpparse: Provide separate early/late callbacks Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 11/22] x86/dtb: Rename x86_dtb_init() Thomas Gleixner
` (11 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
In preparation of splitting the get_smp_config() callback, rename
default_get_smp_config() to mpparse_get_smp_config() and provide an early
and late wrapper.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/mpspec.h | 12 ++++++++----
arch/x86/kernel/mpparse.c | 12 +++++++++++-
arch/x86/kernel/x86_init.c | 2 +-
3 files changed, 20 insertions(+), 6 deletions(-)
---
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -60,12 +60,16 @@ static inline void early_get_smp_config(
extern void e820__memblock_alloc_reserved_mpc_new(void);
extern int enable_update_mptable;
extern void mpparse_find_mptable(void);
-extern void default_get_smp_config(unsigned int early);
+extern void mpparse_parse_early_smp_config(void);
+extern void mpparse_parse_smp_config(void);
+extern void mpparse_get_smp_config(unsigned int early);
#else
static inline void e820__memblock_alloc_reserved_mpc_new(void) { }
-#define enable_update_mptable 0
-#define mpparse_find_mptable x86_init_noop
-#define default_get_smp_config x86_init_uint_noop
+#define enable_update_mptable 0
+#define mpparse_find_mptable x86_init_noop
+#define mpparse_parse_early_smp_config x86_init_noop
+#define mpparse_parse_smp_config x86_init_noop
+#define mpparse_get_smp_config x86_init_uint_noop
#endif
int generic_processor_info(int apicid);
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -473,7 +473,7 @@ static int __init check_physptr(struct m
/*
* Scan the memory blocks for an SMP configuration block.
*/
-void __init default_get_smp_config(unsigned int early)
+void __init mpparse_get_smp_config(unsigned int early)
{
struct mpf_intel *mpf;
@@ -538,6 +538,16 @@ void __init default_get_smp_config(unsig
early_memunmap(mpf, sizeof(*mpf));
}
+void __init mpparse_parse_early_smp_config(void)
+{
+ mpparse_get_smp_config(true);
+}
+
+void __init mpparse_parse_smp_config(void)
+{
+ mpparse_get_smp_config(false);
+}
+
static void __init smp_reserve_memory(struct mpf_intel *mpf)
{
memblock_reserve(mpf->physptr, get_mpc_size(mpf->physptr));
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -71,7 +71,7 @@ struct x86_init_ops x86_init __initdata
.mpparse = {
.setup_ioapic_ids = x86_init_noop,
.find_mptable = mpparse_find_mptable,
- .get_smp_config = default_get_smp_config,
+ .get_smp_config = mpparse_get_smp_config,
},
.irqs = {
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 11/22] x86/dtb: Rename x86_dtb_init()
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (9 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 10/22] x86/mpparse: Prepare for callback separation Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 12/22] x86/platform/ce4100: Prepare for separate mpparse callbacks Thomas Gleixner
` (10 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
x86_dtb_init() is a misnomer and it really should be used as a SMP
configuration parser which is selected by the platform via
x86_init::mpparse:parse_smp_config().
Rename it to x86_dtb_parse_smp_config() in preparation for that.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/prom.h | 4 ++--
arch/x86/kernel/devicetree.c | 2 +-
arch/x86/kernel/setup.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
---
--- a/arch/x86/include/asm/prom.h
+++ b/arch/x86/include/asm/prom.h
@@ -23,11 +23,11 @@ extern int of_ioapic;
extern u64 initial_dtb;
extern void add_dtb(u64 data);
void x86_of_pci_init(void);
-void x86_dtb_init(void);
+void x86_dtb_parse_smp_config(void);
#else
static inline void add_dtb(u64 data) { }
static inline void x86_of_pci_init(void) { }
-static inline void x86_dtb_init(void) { }
+static inline void x86_dtb_parse_smp_config(void) { }
#define of_ioapic 0
#endif
--- a/arch/x86/kernel/devicetree.c
+++ b/arch/x86/kernel/devicetree.c
@@ -302,7 +302,7 @@ void __init x86_flattree_get_config(void
}
#endif
-void __init x86_dtb_init(void)
+void __init x86_dtb_parse_smp_config(void)
{
if (!of_have_populated_dt())
return;
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1131,7 +1131,7 @@ void __init setup_arch(char **cmdline_p)
* Read APIC and some other early information from ACPI tables.
*/
acpi_boot_init();
- x86_dtb_init();
+ x86_dtb_parse_smp_config();
/*
* get boot-time SMP configuration:
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 12/22] x86/platform/ce4100: Prepare for separate mpparse callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (10 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 11/22] x86/dtb: Rename x86_dtb_init() Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 13/22] x86/platform/intel-mid: " Thomas Gleixner
` (9 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Select x86_dtb_parse_smp_config() as SMP configuration parser in
preparation of splitting up the get_smp_config() callback.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/platform/ce4100/ce4100.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
---
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -135,12 +135,14 @@ static void sdv_pci_init(void)
*/
void __init x86_ce4100_early_setup(void)
{
- x86_init.oem.arch_setup = sdv_arch_setup;
- x86_init.resources.probe_roms = x86_init_noop;
- x86_init.mpparse.get_smp_config = x86_init_uint_noop;
- x86_init.mpparse.find_mptable = x86_init_noop;
- x86_init.pci.init = ce4100_pci_init;
- x86_init.pci.init_irq = sdv_pci_init;
+ x86_init.oem.arch_setup = sdv_arch_setup;
+ x86_init.resources.probe_roms = x86_init_noop;
+ x86_init.mpparse.find_mptable = x86_init_noop;
+ x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
+ x86_init.mpparse.parse_smp_cfg = x86_dtb_parse_smp_config;
+ x86_init.mpparse.get_smp_config = x86_init_uint_noop;
+ x86_init.pci.init = ce4100_pci_init;
+ x86_init.pci.init_irq = sdv_pci_init;
/*
* By default, the reboot method is ACPI which is supported by the
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 13/22] x86/platform/intel-mid: Prepare for separate mpparse callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (11 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 12/22] x86/platform/ce4100: Prepare for separate mpparse callbacks Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 14/22] x86/jailhouse: " Thomas Gleixner
` (8 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Initialize the split SMP configuration callbacks with NOOPs as MID is
strictly ACPI only.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
arch/x86/platform/intel-mid/intel-mid.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
---
--- a/arch/x86/platform/intel-mid/intel-mid.c
+++ b/arch/x86/platform/intel-mid/intel-mid.c
@@ -118,7 +118,9 @@ void __init x86_intel_mid_early_setup(vo
machine_ops.emergency_restart = intel_mid_reboot;
/* Avoid searching for BIOS MP tables */
- x86_init.mpparse.find_mptable = x86_init_noop;
- x86_init.mpparse.get_smp_config = x86_init_uint_noop;
+ x86_init.mpparse.find_mptable = x86_init_noop;
+ x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
+ x86_init.mpparse.parse_smp_cfg = x86_init_noop;
+ x86_init.mpparse.get_smp_config = x86_init_uint_noop;
set_bit(MP_BUS_ISA, mp_bus_not_pci);
}
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 14/22] x86/jailhouse: Prepare for separate mpparse callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (12 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 13/22] x86/platform/intel-mid: " Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 15/22] x86/xen/smp_pv: " Thomas Gleixner
` (7 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Provide a wrapper around the existing function and fill the new callbacks
in.
No functional change as the new callbacks are not yet operational.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/kernel/jailhouse.c | 34 +++++++++++++++++++++-------------
1 file changed, 21 insertions(+), 13 deletions(-)
---
--- a/arch/x86/kernel/jailhouse.c
+++ b/arch/x86/kernel/jailhouse.c
@@ -118,6 +118,11 @@ static void __init jailhouse_get_smp_con
}
}
+static void __init jailhouse_parse_smp_config(void)
+{
+ jailhouse_get_smp_config(false);
+}
+
static void jailhouse_no_restart(void)
{
pr_notice("Jailhouse: Restart not supported, halting\n");
@@ -201,21 +206,24 @@ static void __init jailhouse_init_platfo
struct setup_data header;
void *mapping;
- x86_init.irqs.pre_vector_init = x86_init_noop;
- x86_init.timers.timer_init = jailhouse_timer_init;
- x86_init.mpparse.get_smp_config = jailhouse_get_smp_config;
- x86_init.pci.arch_init = jailhouse_pci_arch_init;
-
- x86_platform.calibrate_cpu = jailhouse_get_tsc;
- x86_platform.calibrate_tsc = jailhouse_get_tsc;
- x86_platform.get_wallclock = jailhouse_get_wallclock;
- x86_platform.legacy.rtc = 0;
- x86_platform.legacy.warm_reset = 0;
- x86_platform.legacy.i8042 = X86_LEGACY_I8042_PLATFORM_ABSENT;
+ x86_init.irqs.pre_vector_init = x86_init_noop;
+ x86_init.timers.timer_init = jailhouse_timer_init;
+ x86_init.mpparse.find_mptable = x86_init_noop;
+ x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
+ x86_init.mpparse.parse_smp_cfg = jailhouse_parse_smp_config;
+ x86_init.mpparse.get_smp_config = jailhouse_get_smp_config;
+ x86_init.pci.arch_init = jailhouse_pci_arch_init;
+
+ x86_platform.calibrate_cpu = jailhouse_get_tsc;
+ x86_platform.calibrate_tsc = jailhouse_get_tsc;
+ x86_platform.get_wallclock = jailhouse_get_wallclock;
+ x86_platform.legacy.rtc = 0;
+ x86_platform.legacy.warm_reset = 0;
+ x86_platform.legacy.i8042 = X86_LEGACY_I8042_PLATFORM_ABSENT;
- legacy_pic = &null_legacy_pic;
+ legacy_pic = &null_legacy_pic;
- machine_ops.emergency_restart = jailhouse_no_restart;
+ machine_ops.emergency_restart = jailhouse_no_restart;
while (pa_data) {
mapping = early_memremap(pa_data, sizeof(header));
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 15/22] x86/xen/smp_pv: Prepare for separate mpparse callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (13 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 14/22] x86/jailhouse: " Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 16/22] x86/hyperv/vtl: " Thomas Gleixner
` (6 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Provide a wrapper around the existing function and fill the new callbacks
in.
No functional change as the new callbacks are not yet operational.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/xen/smp_pv.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
---
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -185,6 +185,11 @@ static void __init _get_smp_config(unsig
smp_found_config = 1;
}
+static void __init xen_pv_smp_config(void)
+{
+ _get_smp_config(false);
+}
+
static void __init xen_pv_smp_prepare_boot_cpu(void)
{
BUG_ON(smp_processor_id() != 0);
@@ -455,6 +460,8 @@ void __init xen_smp_init(void)
smp_ops = xen_smp_ops;
/* Avoid searching for BIOS MP tables */
- x86_init.mpparse.find_mptable = x86_init_noop;
- x86_init.mpparse.get_smp_config = _get_smp_config;
+ x86_init.mpparse.find_mptable = x86_init_noop;
+ x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
+ x86_init.mpparse.parse_smp_cfg = xen_pv_smp_config;
+ x86_init.mpparse.get_smp_config = _get_smp_config;
}
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 16/22] x86/hyperv/vtl: Prepare for separate mpparse callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (14 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 15/22] x86/xen/smp_pv: " Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 17/22] x86/mpparse: Switch to new init callbacks Thomas Gleixner
` (5 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel), Wei Liu,
Andy Shevchenko
Initialize the new callbacks in preparation for switching the core code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Wei Liu <wei.liu@kernel.org>
---
V5: New patch
---
arch/x86/hyperv/hv_vtl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- a/arch/x86/hyperv/hv_vtl.c
+++ b/arch/x86/hyperv/hv_vtl.c
@@ -26,7 +26,9 @@ void __init hv_vtl_init_platform(void)
x86_init.timers.timer_init = x86_init_noop;
/* Avoid searching for BIOS MP tables */
- x86_init.mpparse.find_smp_config = x86_init_noop;
+ x86_init.mpparse.find_mptable = x86_init_noop;
+ x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
+ x86_init.mpparse.parse_smp_cfg = x86_init_noop;
x86_init.mpparse.get_smp_config = x86_init_uint_noop;
x86_platform.get_wallclock = get_rtc_noop;
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 17/22] x86/mpparse: Switch to new init callbacks
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (15 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 16/22] x86/hyperv/vtl: " Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 18/22] x86/mm/numa: Move early mptable evaluation into common code Thomas Gleixner
` (4 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Now that all platforms have the new split SMP configuration callbacks set
up, flip the switch and remove the old callback pointer and mop up the
platform code.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/hyperv/hv_vtl.c | 1 -
arch/x86/include/asm/mpspec.h | 9 +--------
arch/x86/include/asm/x86_init.h | 2 --
arch/x86/kernel/jailhouse.c | 8 +-------
arch/x86/kernel/mpparse.c | 2 +-
arch/x86/kernel/setup.c | 10 +++-------
arch/x86/kernel/x86_init.c | 3 ++-
arch/x86/platform/ce4100/ce4100.c | 1 -
arch/x86/platform/intel-mid/intel-mid.c | 1 -
arch/x86/xen/smp_pv.c | 11 +----------
10 files changed, 9 insertions(+), 39 deletions(-)
---
--- a/arch/x86/hyperv/hv_vtl.c
+++ b/arch/x86/hyperv/hv_vtl.c
@@ -29,7 +29,6 @@ void __init hv_vtl_init_platform(void)
x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
x86_init.mpparse.parse_smp_cfg = x86_init_noop;
- x86_init.mpparse.get_smp_config = x86_init_uint_noop;
x86_platform.get_wallclock = get_rtc_noop;
x86_platform.set_wallclock = set_rtc_noop;
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -46,14 +46,9 @@ extern int smp_found_config;
# define smp_found_config 0
#endif
-static inline void get_smp_config(void)
-{
- x86_init.mpparse.get_smp_config(0);
-}
-
static inline void early_get_smp_config(void)
{
- x86_init.mpparse.get_smp_config(1);
+ x86_init.mpparse.early_parse_smp_cfg();
}
#ifdef CONFIG_X86_MPPARSE
@@ -62,14 +57,12 @@ extern int enable_update_mptable;
extern void mpparse_find_mptable(void);
extern void mpparse_parse_early_smp_config(void);
extern void mpparse_parse_smp_config(void);
-extern void mpparse_get_smp_config(unsigned int early);
#else
static inline void e820__memblock_alloc_reserved_mpc_new(void) { }
#define enable_update_mptable 0
#define mpparse_find_mptable x86_init_noop
#define mpparse_parse_early_smp_config x86_init_noop
#define mpparse_parse_smp_config x86_init_noop
-#define mpparse_get_smp_config x86_init_uint_noop
#endif
int generic_processor_info(int apicid);
--- a/arch/x86/include/asm/x86_init.h
+++ b/arch/x86/include/asm/x86_init.h
@@ -16,14 +16,12 @@ struct irq_domain;
* struct x86_init_mpparse - platform specific mpparse ops
* @setup_ioapic_ids: platform specific ioapic id override
* @find_mptable: Find MPTABLE early to reserve the memory region
- * @get_smp_config: get the smp configuration
* @early_parse_smp_cfg: Parse the SMP configuration data early before initmem_init()
* @parse_smp_cfg: Parse the SMP configuration data
*/
struct x86_init_mpparse {
void (*setup_ioapic_ids)(void);
void (*find_mptable)(void);
- void (*get_smp_config)(unsigned int early);
void (*early_parse_smp_cfg)(void);
void (*parse_smp_cfg)(void);
};
--- a/arch/x86/kernel/jailhouse.c
+++ b/arch/x86/kernel/jailhouse.c
@@ -89,7 +89,7 @@ static void __init jailhouse_x2apic_init
#endif
}
-static void __init jailhouse_get_smp_config(unsigned int early)
+static void __init jailhouse_parse_smp_config(void)
{
struct ioapic_domain_cfg ioapic_cfg = {
.type = IOAPIC_DOMAIN_STRICT,
@@ -118,11 +118,6 @@ static void __init jailhouse_get_smp_con
}
}
-static void __init jailhouse_parse_smp_config(void)
-{
- jailhouse_get_smp_config(false);
-}
-
static void jailhouse_no_restart(void)
{
pr_notice("Jailhouse: Restart not supported, halting\n");
@@ -211,7 +206,6 @@ static void __init jailhouse_init_platfo
x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
x86_init.mpparse.parse_smp_cfg = jailhouse_parse_smp_config;
- x86_init.mpparse.get_smp_config = jailhouse_get_smp_config;
x86_init.pci.arch_init = jailhouse_pci_arch_init;
x86_platform.calibrate_cpu = jailhouse_get_tsc;
--- a/arch/x86/kernel/mpparse.c
+++ b/arch/x86/kernel/mpparse.c
@@ -473,7 +473,7 @@ static int __init check_physptr(struct m
/*
* Scan the memory blocks for an SMP configuration block.
*/
-void __init mpparse_get_smp_config(unsigned int early)
+static __init void mpparse_get_smp_config(unsigned int early)
{
struct mpf_intel *mpf;
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1128,15 +1128,11 @@ void __init setup_arch(char **cmdline_p)
early_quirks();
/*
- * Read APIC and some other early information from ACPI tables.
+ * Parse SMP configuration. Try ACPI first and then the platform
+ * specific parser.
*/
acpi_boot_init();
- x86_dtb_parse_smp_config();
-
- /*
- * get boot-time SMP configuration:
- */
- get_smp_config();
+ x86_init.mpparse.parse_smp_cfg();
/*
* Systems w/o ACPI and mptables might not have it mapped the local
--- a/arch/x86/kernel/x86_init.c
+++ b/arch/x86/kernel/x86_init.c
@@ -71,7 +71,8 @@ struct x86_init_ops x86_init __initdata
.mpparse = {
.setup_ioapic_ids = x86_init_noop,
.find_mptable = mpparse_find_mptable,
- .get_smp_config = mpparse_get_smp_config,
+ .early_parse_smp_cfg = mpparse_parse_early_smp_config,
+ .parse_smp_cfg = mpparse_parse_smp_config,
},
.irqs = {
--- a/arch/x86/platform/ce4100/ce4100.c
+++ b/arch/x86/platform/ce4100/ce4100.c
@@ -140,7 +140,6 @@ void __init x86_ce4100_early_setup(void)
x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
x86_init.mpparse.parse_smp_cfg = x86_dtb_parse_smp_config;
- x86_init.mpparse.get_smp_config = x86_init_uint_noop;
x86_init.pci.init = ce4100_pci_init;
x86_init.pci.init_irq = sdv_pci_init;
--- a/arch/x86/platform/intel-mid/intel-mid.c
+++ b/arch/x86/platform/intel-mid/intel-mid.c
@@ -121,6 +121,5 @@ void __init x86_intel_mid_early_setup(vo
x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
x86_init.mpparse.parse_smp_cfg = x86_init_noop;
- x86_init.mpparse.get_smp_config = x86_init_uint_noop;
set_bit(MP_BUS_ISA, mp_bus_not_pci);
}
--- a/arch/x86/xen/smp_pv.c
+++ b/arch/x86/xen/smp_pv.c
@@ -148,14 +148,11 @@ int xen_smp_intr_init_pv(unsigned int cp
return rc;
}
-static void __init _get_smp_config(unsigned int early)
+static void __init xen_pv_smp_config(void)
{
int i, rc;
unsigned int subtract = 0;
- if (early)
- return;
-
num_processors = 0;
disabled_cpus = 0;
for (i = 0; i < nr_cpu_ids; i++) {
@@ -185,11 +182,6 @@ static void __init _get_smp_config(unsig
smp_found_config = 1;
}
-static void __init xen_pv_smp_config(void)
-{
- _get_smp_config(false);
-}
-
static void __init xen_pv_smp_prepare_boot_cpu(void)
{
BUG_ON(smp_processor_id() != 0);
@@ -463,5 +455,4 @@ void __init xen_smp_init(void)
x86_init.mpparse.find_mptable = x86_init_noop;
x86_init.mpparse.early_parse_smp_cfg = x86_init_noop;
x86_init.mpparse.parse_smp_cfg = xen_pv_smp_config;
- x86_init.mpparse.get_smp_config = _get_smp_config;
}
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 18/22] x86/mm/numa: Move early mptable evaluation into common code
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (16 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 17/22] x86/mpparse: Switch to new init callbacks Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 19/22] x86/mpparse: Remove the physid_t bitmap wrapper Thomas Gleixner
` (3 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
There is no reason to have the early mptable evaluation conditionally
invoked only from the AMD numa topology code.
Make it explicit and invoke it from setup_arch() right after the
corresponding ACPI init call. Remove the pointless wrapper and invoke
x86_init::mpparse::early_parse_smp_config() directly.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/mpspec.h | 5 -----
arch/x86/kernel/setup.c | 2 ++
arch/x86/mm/amdtopology.c | 7 -------
3 files changed, 2 insertions(+), 12 deletions(-)
---
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -46,11 +46,6 @@ extern int smp_found_config;
# define smp_found_config 0
#endif
-static inline void early_get_smp_config(void)
-{
- x86_init.mpparse.early_parse_smp_cfg();
-}
-
#ifdef CONFIG_X86_MPPARSE
extern void e820__memblock_alloc_reserved_mpc_new(void);
extern int enable_update_mptable;
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -1086,7 +1086,9 @@ void __init setup_arch(char **cmdline_p)
early_platform_quirks();
+ /* Some platforms need the APIC registered for NUMA configuration */
early_acpi_boot_init();
+ x86_init.mpparse.early_parse_smp_cfg();
x86_flattree_get_config();
--- a/arch/x86/mm/amdtopology.c
+++ b/arch/x86/mm/amdtopology.c
@@ -161,13 +161,6 @@ int __init amd_numa_init(void)
*/
cores = topology_get_domain_size(TOPO_CORE_DOMAIN);
- /*
- * Scan MPTABLE to map the local APIC and ensure that the boot CPU
- * APIC ID is valid. This is required because on pre ACPI/SRAT
- * systems IO-APICs are mapped before the boot CPU.
- */
- early_get_smp_config();
-
apicid = boot_cpu_physical_apicid;
if (apicid > 0)
pr_info("BSP APIC ID: %02x\n", apicid);
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 19/22] x86/mpparse: Remove the physid_t bitmap wrapper
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (17 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 18/22] x86/mm/numa: Move early mptable evaluation into common code Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 20/22] x86/apic: Remove the pointless writeback of boot_cpu_physical_apicid Thomas Gleixner
` (2 subsequent siblings)
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
physid_t is a wrapper around bitmap. Just remove the onion layer and use
bitmap functionality directly.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/mpspec.h | 32 +++++++++-----------------------
arch/x86/kernel/apic/apic.c | 11 +++++------
arch/x86/kernel/apic/apic_common.c | 12 +-----------
arch/x86/kernel/apic/io_apic.c | 24 ++++++++++++------------
arch/x86/kernel/apic/local.h | 1 -
arch/x86/kernel/smpboot.c | 8 +++-----
6 files changed, 30 insertions(+), 58 deletions(-)
---
--- a/arch/x86/include/asm/mpspec.h
+++ b/arch/x86/include/asm/mpspec.h
@@ -2,6 +2,7 @@
#ifndef _ASM_X86_MPSPEC_H
#define _ASM_X86_MPSPEC_H
+#include <linux/types.h>
#include <asm/mpspec_def.h>
#include <asm/x86_init.h>
@@ -62,32 +63,17 @@ static inline void e820__memblock_alloc_
int generic_processor_info(int apicid);
-#define PHYSID_ARRAY_SIZE BITS_TO_LONGS(MAX_LOCAL_APIC)
+extern DECLARE_BITMAP(phys_cpu_present_map, MAX_LOCAL_APIC);
-struct physid_mask {
- unsigned long mask[PHYSID_ARRAY_SIZE];
-};
-
-typedef struct physid_mask physid_mask_t;
-
-#define physid_set(physid, map) set_bit(physid, (map).mask)
-#define physid_isset(physid, map) test_bit(physid, (map).mask)
-
-#define physids_clear(map) \
- bitmap_zero((map).mask, MAX_LOCAL_APIC)
-
-#define physids_empty(map) \
- bitmap_empty((map).mask, MAX_LOCAL_APIC)
-
-static inline void physid_set_mask_of_physid(int physid, physid_mask_t *map)
+static inline void reset_phys_cpu_present_map(u32 apicid)
{
- physids_clear(*map);
- physid_set(physid, *map);
+ bitmap_zero(phys_cpu_present_map, MAX_LOCAL_APIC);
+ set_bit(apicid, phys_cpu_present_map);
}
-#define PHYSID_MASK_ALL { {[0 ... PHYSID_ARRAY_SIZE-1] = ~0UL} }
-#define PHYSID_MASK_NONE { {[0 ... PHYSID_ARRAY_SIZE-1] = 0UL} }
-
-extern physid_mask_t phys_cpu_present_map;
+static inline void copy_phys_cpu_present_map(unsigned long *dst)
+{
+ bitmap_copy(dst, phys_cpu_present_map, MAX_LOCAL_APIC);
+}
#endif /* _ASM_X86_MPSPEC_H */
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -19,6 +19,7 @@
#include <linux/kernel_stat.h>
#include <linux/mc146818rtc.h>
#include <linux/acpi_pmtmr.h>
+#include <linux/bitmap.h>
#include <linux/clockchips.h>
#include <linux/interrupt.h>
#include <linux/memblock.h>
@@ -77,10 +78,8 @@ EXPORT_SYMBOL_GPL(boot_cpu_physical_apic
u8 boot_cpu_apic_version __ro_after_init;
-/*
- * Bitmask of physically existing CPUs:
- */
-physid_mask_t phys_cpu_present_map;
+/* Bitmap of physically present CPUs. */
+DECLARE_BITMAP(phys_cpu_present_map, MAX_LOCAL_APIC);
/*
* Processor to be disabled specified by kernel parameter
@@ -2387,7 +2386,7 @@ static void cpu_update_apic(int cpu, u32
early_per_cpu(x86_cpu_to_apicid, cpu) = apicid;
#endif
set_cpu_possible(cpu, true);
- physid_set(apicid, phys_cpu_present_map);
+ set_bit(apicid, phys_cpu_present_map);
set_cpu_present(cpu, true);
num_processors++;
@@ -2489,7 +2488,7 @@ static void __init apic_bsp_up_setup(voi
#ifdef CONFIG_X86_64
apic_write(APIC_ID, apic->set_apic_id(boot_cpu_physical_apicid));
#endif
- physid_set_mask_of_physid(boot_cpu_physical_apicid, &phys_cpu_present_map);
+ reset_phys_cpu_present_map(boot_cpu_physical_apicid);
}
/**
--- a/arch/x86/kernel/apic/apic_common.c
+++ b/arch/x86/kernel/apic/apic_common.c
@@ -18,16 +18,6 @@ u32 apic_flat_calc_apicid(unsigned int c
return 1U << cpu;
}
-bool default_check_apicid_used(physid_mask_t *map, u32 apicid)
-{
- return physid_isset(apicid, *map);
-}
-
-void default_ioapic_phys_id_map(physid_mask_t *phys_map, physid_mask_t *retmap)
-{
- *retmap = *phys_map;
-}
-
u32 default_cpu_present_to_apicid(int mps_cpu)
{
if (mps_cpu < nr_cpu_ids && cpu_present(mps_cpu))
@@ -39,7 +29,7 @@ EXPORT_SYMBOL_GPL(default_cpu_present_to
bool default_apic_id_registered(void)
{
- return physid_isset(read_apic_id(), phys_cpu_present_map);
+ return test_bit(read_apic_id(), phys_cpu_present_map);
}
/*
--- a/arch/x86/kernel/apic/io_apic.c
+++ b/arch/x86/kernel/apic/io_apic.c
@@ -1460,7 +1460,7 @@ void restore_boot_irq_mode(void)
*/
static void __init setup_ioapic_ids_from_mpc_nocheck(void)
{
- physid_mask_t phys_id_present_map;
+ DECLARE_BITMAP(phys_id_present_map, MAX_LOCAL_APIC);
const u32 broadcast_id = 0xF;
union IO_APIC_reg_00 reg_00;
unsigned char old_id;
@@ -1471,7 +1471,7 @@ static void __init setup_ioapic_ids_from
* This is broken; anything with a real cpu count has to
* circumvent this idiocy regardless.
*/
- phys_id_present_map = phys_cpu_present_map;
+ copy_phys_cpu_present_map(phys_id_present_map);
/*
* Set the IOAPIC ID to the value stored in the MPC table.
@@ -1496,21 +1496,21 @@ static void __init setup_ioapic_ids_from
* system must have a unique ID or we get lots of nice
* 'stuck on smp_invalidate_needed IPI wait' messages.
*/
- if (physid_isset(mpc_ioapic_id(ioapic_idx), phys_id_present_map)) {
+ if (test_bit(mpc_ioapic_id(ioapic_idx), phys_id_present_map)) {
pr_err(FW_BUG "IO-APIC#%d ID %d is already used!...\n",
ioapic_idx, mpc_ioapic_id(ioapic_idx));
for (i = 0; i < broadcast_id; i++)
- if (!physid_isset(i, phys_id_present_map))
+ if (!test_bit(i, phys_id_present_map))
break;
if (i >= broadcast_id)
panic("Max APIC ID exceeded!\n");
pr_err("... fixing up to %d. (tell your hw vendor)\n", i);
- physid_set(i, phys_id_present_map);
+ set_bit(i, phys_id_present_map);
ioapics[ioapic_idx].mp_config.apicid = i;
} else {
apic_printk(APIC_VERBOSE, "Setting %d in the phys_id_present_map\n",
mpc_ioapic_id(ioapic_idx));
- physid_set(mpc_ioapic_id(ioapic_idx), phys_id_present_map);
+ set_bit(mpc_ioapic_id(ioapic_idx), phys_id_present_map);
}
/*
@@ -2491,15 +2491,15 @@ unsigned int arch_dynirq_lower_bound(uns
#ifdef CONFIG_X86_32
static int io_apic_get_unique_id(int ioapic, int apic_id)
{
- static physid_mask_t apic_id_map = PHYSID_MASK_NONE;
+ static DECLARE_BITMAP(apic_id_map, MAX_LOCAL_APIC);
const u32 broadcast_id = 0xF;
union IO_APIC_reg_00 reg_00;
unsigned long flags;
int i = 0;
/* Initialize the ID map */
- if (physids_empty(apic_id_map))
- apic_id_map = phys_cpu_present_map;
+ if (bitmap_empty(apic_id_map, MAX_LOCAL_APIC))
+ copy_phys_cpu_present_map(apic_id_map);
raw_spin_lock_irqsave(&ioapic_lock, flags);
reg_00.raw = io_apic_read(ioapic, 0);
@@ -2512,9 +2512,9 @@ static int io_apic_get_unique_id(int ioa
}
/* Every APIC in a system must have a unique ID */
- if (physid_isset(apic_id, apic_id_map)) {
+ if (test_bit(apic_id, apic_id_map)) {
for (i = 0; i < broadcast_id; i++) {
- if (!physid_isset(i, apic_id_map))
+ if (!test_bit(i, apic_id_map))
break;
}
@@ -2525,7 +2525,7 @@ static int io_apic_get_unique_id(int ioa
apic_id = i;
}
- physid_set(apic_id, apic_id_map);
+ set_bit(apic_id, apic_id_map);
if (reg_00.bits.ID != apic_id) {
reg_00.bits.ID = apic_id;
--- a/arch/x86/kernel/apic/local.h
+++ b/arch/x86/kernel/apic/local.h
@@ -63,7 +63,6 @@ void default_send_IPI_all(int vector);
void default_send_IPI_self(int vector);
bool default_apic_id_registered(void);
-bool default_check_apicid_used(physid_mask_t *map, u32 apicid);
#ifdef CONFIG_X86_32
void default_send_IPI_mask_sequence_logical(const struct cpumask *mask, int vector);
--- a/arch/x86/kernel/smpboot.c
+++ b/arch/x86/kernel/smpboot.c
@@ -1072,7 +1072,7 @@ int native_kick_ap(unsigned int cpu, str
pr_debug("++++++++++++++++++++=_---CPU UP %u\n", cpu);
- if (apicid == BAD_APICID || !physid_isset(apicid, phys_cpu_present_map) ||
+ if (apicid == BAD_APICID || !test_bit(apicid, phys_cpu_present_map) ||
!apic_id_valid(apicid)) {
pr_err("%s: bad cpu %d\n", __func__, cpu);
return -EINVAL;
@@ -1147,10 +1147,8 @@ static __init void disable_smp(void)
init_cpu_present(cpumask_of(0));
init_cpu_possible(cpumask_of(0));
- if (smp_found_config)
- physid_set_mask_of_physid(boot_cpu_physical_apicid, &phys_cpu_present_map);
- else
- physid_set_mask_of_physid(0, &phys_cpu_present_map);
+ reset_phys_cpu_present_map(smp_found_config ? boot_cpu_physical_apicid : 0);
+
cpumask_set_cpu(0, topology_sibling_cpumask(0));
cpumask_set_cpu(0, topology_core_cpumask(0));
cpumask_set_cpu(0, topology_die_cpumask(0));
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 20/22] x86/apic: Remove the pointless writeback of boot_cpu_physical_apicid
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (18 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 19/22] x86/mpparse: Remove the physid_t bitmap wrapper Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 21/22] x86/apic: Remove yet another dubious callback Thomas Gleixner
2024-01-23 13:10 ` [patch V2 22/22] x86/apic: Use a proper define for invalid ACPI CPU ID Thomas Gleixner
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
There is absolutely no point to write the APIC ID which was read from the
local APIC earlier, back into the local APIC for the 64-bit UP case.
Remove that along with the apic callback which is solely there for this
pointless exercise.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/apic.h | 1 -
arch/x86/kernel/apic/apic.c | 3 ---
arch/x86/kernel/apic/apic_flat_64.c | 7 -------
arch/x86/kernel/apic/apic_numachip.c | 12 ------------
arch/x86/kernel/apic/bigsmp_32.c | 1 -
arch/x86/kernel/apic/local.h | 1 -
arch/x86/kernel/apic/x2apic_cluster.c | 1 -
arch/x86/kernel/apic/x2apic_phys.c | 6 ------
arch/x86/kernel/apic/x2apic_uv_x.c | 6 ------
arch/x86/xen/apic.c | 7 -------
10 files changed, 45 deletions(-)
---
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -294,7 +294,6 @@ struct apic {
u32 (*cpu_present_to_apicid)(int mps_cpu);
u32 (*get_apic_id)(u32 id);
- u32 (*set_apic_id)(u32 apicid);
/* wakeup_secondary_cpu */
int (*wakeup_secondary_cpu)(u32 apicid, unsigned long start_eip);
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -2485,9 +2485,6 @@ EXPORT_SYMBOL_GPL(x86_msi_msg_get_destid
static void __init apic_bsp_up_setup(void)
{
-#ifdef CONFIG_X86_64
- apic_write(APIC_ID, apic->set_apic_id(boot_cpu_physical_apicid));
-#endif
reset_phys_cpu_present_map(boot_cpu_physical_apicid);
}
--- a/arch/x86/kernel/apic/apic_flat_64.c
+++ b/arch/x86/kernel/apic/apic_flat_64.c
@@ -61,11 +61,6 @@ static u32 flat_get_apic_id(u32 x)
return (x >> 24) & 0xFF;
}
-static u32 set_apic_id(u32 id)
-{
- return (id & 0xFF) << 24;
-}
-
static int flat_probe(void)
{
return 1;
@@ -86,7 +81,6 @@ static struct apic apic_flat __ro_after_
.max_apic_id = 0xFE,
.get_apic_id = flat_get_apic_id,
- .set_apic_id = set_apic_id,
.calc_dest_apicid = apic_flat_calc_apicid,
@@ -155,7 +149,6 @@ static struct apic apic_physflat __ro_af
.max_apic_id = 0xFE,
.get_apic_id = flat_get_apic_id,
- .set_apic_id = set_apic_id,
.calc_dest_apicid = apic_default_calc_apicid,
--- a/arch/x86/kernel/apic/apic_numachip.c
+++ b/arch/x86/kernel/apic/apic_numachip.c
@@ -38,11 +38,6 @@ static u32 numachip1_get_apic_id(u32 x)
return id;
}
-static u32 numachip1_set_apic_id(u32 id)
-{
- return (id & 0xff) << 24;
-}
-
static u32 numachip2_get_apic_id(u32 x)
{
u64 mcfg;
@@ -51,11 +46,6 @@ static u32 numachip2_get_apic_id(u32 x)
return ((mcfg >> (28 - 8)) & 0xfff00) | (x >> 24);
}
-static u32 numachip2_set_apic_id(u32 id)
-{
- return id << 24;
-}
-
static void numachip1_apic_icr_write(int apicid, unsigned int val)
{
write_lcsr(CSR_G3_EXT_IRQ_GEN, (apicid << 16) | val);
@@ -225,7 +215,6 @@ static const struct apic apic_numachip1
.max_apic_id = UINT_MAX,
.get_apic_id = numachip1_get_apic_id,
- .set_apic_id = numachip1_set_apic_id,
.calc_dest_apicid = apic_default_calc_apicid,
@@ -260,7 +249,6 @@ static const struct apic apic_numachip2
.max_apic_id = UINT_MAX,
.get_apic_id = numachip2_get_apic_id,
- .set_apic_id = numachip2_set_apic_id,
.calc_dest_apicid = apic_default_calc_apicid,
--- a/arch/x86/kernel/apic/bigsmp_32.c
+++ b/arch/x86/kernel/apic/bigsmp_32.c
@@ -72,7 +72,6 @@ static struct apic apic_bigsmp __ro_afte
.max_apic_id = 0xFE,
.get_apic_id = bigsmp_get_apic_id,
- .set_apic_id = NULL,
.calc_dest_apicid = apic_default_calc_apicid,
--- a/arch/x86/kernel/apic/local.h
+++ b/arch/x86/kernel/apic/local.h
@@ -16,7 +16,6 @@
/* X2APIC */
void __x2apic_send_IPI_dest(unsigned int apicid, int vector, unsigned int dest);
u32 x2apic_get_apic_id(u32 id);
-u32 x2apic_set_apic_id(u32 id);
void x2apic_send_IPI_all(int vector);
void x2apic_send_IPI_allbutself(int vector);
--- a/arch/x86/kernel/apic/x2apic_cluster.c
+++ b/arch/x86/kernel/apic/x2apic_cluster.c
@@ -237,7 +237,6 @@ static struct apic apic_x2apic_cluster _
.max_apic_id = UINT_MAX,
.x2apic_set_max_apicid = true,
.get_apic_id = x2apic_get_apic_id,
- .set_apic_id = x2apic_set_apic_id,
.calc_dest_apicid = x2apic_calc_apicid,
--- a/arch/x86/kernel/apic/x2apic_phys.c
+++ b/arch/x86/kernel/apic/x2apic_phys.c
@@ -129,11 +129,6 @@ u32 x2apic_get_apic_id(u32 id)
return id;
}
-u32 x2apic_set_apic_id(u32 id)
-{
- return id;
-}
-
static struct apic apic_x2apic_phys __ro_after_init = {
.name = "physical x2apic",
@@ -149,7 +144,6 @@ static struct apic apic_x2apic_phys __ro
.max_apic_id = UINT_MAX,
.x2apic_set_max_apicid = true,
.get_apic_id = x2apic_get_apic_id,
- .set_apic_id = x2apic_set_apic_id,
.calc_dest_apicid = apic_default_calc_apicid,
--- a/arch/x86/kernel/apic/x2apic_uv_x.c
+++ b/arch/x86/kernel/apic/x2apic_uv_x.c
@@ -745,11 +745,6 @@ static void uv_send_IPI_all(int vector)
uv_send_IPI_mask(cpu_online_mask, vector);
}
-static u32 set_apic_id(u32 id)
-{
- return id;
-}
-
static int uv_probe(void)
{
return apic == &apic_x2apic_uv_x;
@@ -769,7 +764,6 @@ static struct apic apic_x2apic_uv_x __ro
.max_apic_id = UINT_MAX,
.get_apic_id = x2apic_get_apic_id,
- .set_apic_id = set_apic_id,
.calc_dest_apicid = apic_default_calc_apicid,
--- a/arch/x86/xen/apic.c
+++ b/arch/x86/xen/apic.c
@@ -33,12 +33,6 @@ static unsigned int xen_io_apic_read(uns
return 0xfd;
}
-static u32 xen_set_apic_id(u32 x)
-{
- WARN_ON(1);
- return x;
-}
-
static u32 xen_get_apic_id(u32 x)
{
return ((x)>>24) & 0xFFu;
@@ -131,7 +125,6 @@ static struct apic xen_pv_apic __ro_afte
.max_apic_id = UINT_MAX,
.get_apic_id = xen_get_apic_id,
- .set_apic_id = xen_set_apic_id,
.calc_dest_apicid = apic_flat_calc_apicid,
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 21/22] x86/apic: Remove yet another dubious callback
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (19 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 20/22] x86/apic: Remove the pointless writeback of boot_cpu_physical_apicid Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
2024-01-23 13:10 ` [patch V2 22/22] x86/apic: Use a proper define for invalid ACPI CPU ID Thomas Gleixner
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
Paranoia is not wrong, but having an APIC callback which is in most
implementations a complete NOOP and in one actually looking whether the
APICID of an upcoming CPU has been registered. The same APICID which was
used to bring the CPU out of wait for startup.
That's paranoia for the paranoia sake. Remove the voodoo.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/apic.h | 1 -
arch/x86/kernel/apic/apic.c | 3 ---
arch/x86/kernel/apic/apic_common.c | 5 -----
arch/x86/kernel/apic/apic_flat_64.c | 2 --
arch/x86/kernel/apic/local.h | 2 --
arch/x86/kernel/apic/probe_32.c | 1 -
6 files changed, 14 deletions(-)
---
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -288,7 +288,6 @@ struct apic {
/* Probe, setup and smpboot functions */
int (*probe)(void);
int (*acpi_madt_oem_check)(char *oem_id, char *oem_table_id);
- bool (*apic_id_registered)(void);
void (*init_apic_ldr)(void);
u32 (*cpu_present_to_apicid)(int mps_cpu);
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -1538,9 +1538,6 @@ static void setup_local_APIC(void)
apic_write(APIC_ESR, 0);
}
#endif
- /* Validate that the APIC is registered if required */
- BUG_ON(apic->apic_id_registered && !apic->apic_id_registered());
-
/*
* Intel recommends to set DFR, LDR and TPR before enabling
* an APIC. See e.g. "AP-388 82489DX User's Manual" (Intel
--- a/arch/x86/kernel/apic/apic_common.c
+++ b/arch/x86/kernel/apic/apic_common.c
@@ -27,11 +27,6 @@ u32 default_cpu_present_to_apicid(int mp
}
EXPORT_SYMBOL_GPL(default_cpu_present_to_apicid);
-bool default_apic_id_registered(void)
-{
- return test_bit(read_apic_id(), phys_cpu_present_map);
-}
-
/*
* Set up the logical destination ID when the APIC operates in logical
* destination mode.
--- a/arch/x86/kernel/apic/apic_flat_64.c
+++ b/arch/x86/kernel/apic/apic_flat_64.c
@@ -70,7 +70,6 @@ static struct apic apic_flat __ro_after_
.name = "flat",
.probe = flat_probe,
.acpi_madt_oem_check = flat_acpi_madt_oem_check,
- .apic_id_registered = default_apic_id_registered,
.dest_mode_logical = true,
@@ -139,7 +138,6 @@ static struct apic apic_physflat __ro_af
.name = "physical flat",
.probe = physflat_probe,
.acpi_madt_oem_check = physflat_acpi_madt_oem_check,
- .apic_id_registered = default_apic_id_registered,
.dest_mode_logical = false,
--- a/arch/x86/kernel/apic/local.h
+++ b/arch/x86/kernel/apic/local.h
@@ -61,8 +61,6 @@ void default_send_IPI_allbutself(int vec
void default_send_IPI_all(int vector);
void default_send_IPI_self(int vector);
-bool default_apic_id_registered(void);
-
#ifdef CONFIG_X86_32
void default_send_IPI_mask_sequence_logical(const struct cpumask *mask, int vector);
void default_send_IPI_mask_allbutself_logical(const struct cpumask *mask, int vector);
--- a/arch/x86/kernel/apic/probe_32.c
+++ b/arch/x86/kernel/apic/probe_32.c
@@ -38,7 +38,6 @@ static struct apic apic_default __ro_aft
.name = "default",
.probe = probe_default,
- .apic_id_registered = default_apic_id_registered,
.dest_mode_logical = true,
^ permalink raw reply [flat|nested] 26+ messages in thread* [patch V2 22/22] x86/apic: Use a proper define for invalid ACPI CPU ID
2024-01-23 13:10 [patch V2 00/22] x86/topology: More cleanups and preparatory work Thomas Gleixner
` (20 preceding siblings ...)
2024-01-23 13:10 ` [patch V2 21/22] x86/apic: Remove yet another dubious callback Thomas Gleixner
@ 2024-01-23 13:10 ` Thomas Gleixner
21 siblings, 0 replies; 26+ messages in thread
From: Thomas Gleixner @ 2024-01-23 13:10 UTC (permalink / raw)
To: LKML
Cc: x86, Tom Lendacky, Andrew Cooper, Arjan van de Ven, Huang Rui,
Juergen Gross, Dimitri Sivanich, Sohil Mehta, K Prateek Nayak,
Kan Liang, Zhang Rui, Paul E. McKenney, Feng Tang,
Andy Shevchenko, Michael Kelley, Peter Zijlstra (Intel),
Andy Shevchenko, Wei Liu
From: Thomas Gleixner <tglx@linutronix.de>
The ACPI ID for CPUs is preset with U32_MAX which is completely non
obvious. Use a proper define for it.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
arch/x86/include/asm/apic.h | 3 +++
arch/x86/kernel/apic/apic.c | 2 +-
arch/x86/xen/enlighten_hvm.c | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
---
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -48,7 +48,10 @@ static inline void x86_32_probe_apic(voi
extern u32 cpuid_to_apicid[];
+#define CPU_ACPIID_INVALID U32_MAX
+
#ifdef CONFIG_X86_LOCAL_APIC
+
extern int apic_verbosity;
extern int local_apic_timer_c2_ok;
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -111,7 +111,7 @@ static inline bool apic_accessible(void)
* Map cpu index to physical APIC ID
*/
DEFINE_EARLY_PER_CPU_READ_MOSTLY(u32, x86_cpu_to_apicid, BAD_APICID);
-DEFINE_EARLY_PER_CPU_READ_MOSTLY(u32, x86_cpu_to_acpiid, U32_MAX);
+DEFINE_EARLY_PER_CPU_READ_MOSTLY(u32, x86_cpu_to_acpiid, CPU_ACPIID_INVALID);
EXPORT_EARLY_PER_CPU_SYMBOL(x86_cpu_to_apicid);
EXPORT_EARLY_PER_CPU_SYMBOL(x86_cpu_to_acpiid);
--- a/arch/x86/xen/enlighten_hvm.c
+++ b/arch/x86/xen/enlighten_hvm.c
@@ -168,7 +168,7 @@ static int xen_cpu_up_prepare_hvm(unsign
*/
xen_uninit_lock_cpu(cpu);
- if (cpu_acpi_id(cpu) != U32_MAX)
+ if (cpu_acpi_id(cpu) != CPU_ACPIID_INVALID)
per_cpu(xen_vcpu_id, cpu) = cpu_acpi_id(cpu);
else
per_cpu(xen_vcpu_id, cpu) = cpu;
^ permalink raw reply [flat|nested] 26+ messages in thread