From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9991C4167B for ; Fri, 1 Dec 2023 10:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378280AbjLAKe3 (ORCPT ); Fri, 1 Dec 2023 05:34:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378239AbjLAKe1 (ORCPT ); Fri, 1 Dec 2023 05:34:27 -0500 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5456DDE; Fri, 1 Dec 2023 02:34:33 -0800 (PST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 3D85120003; Fri, 1 Dec 2023 10:34:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1701426871; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x9QLIDvjWUePyTNPo1KyKIxmABI1QYlXqcofIXZnDv4=; b=Efp+K6ppRKNmXRXC312z4I4B/6CUBUuHRLy8PLz+V/UGueyXXhjUby1z/imQlO2LUhYGLR GLCiyYckN/srl+stf7jfzn6vO8+xatIFz1FFvYGMSuvYAi3wqhfzOT3fcrulMkGFlAu1wJ 6sfsj3uvzn9oKJQUzs7Nsw2oDCTQ7M3ErnbzRY7fohDNl9k2hSPTae29J1N6eUF5QhPVDe cf/keirVpnBJrg6utYHwPH1+cFVRs0rSUSj/XvDwYB8MoeDtu35HIV2LS2XSCu2aqyWtBx zv8qYSdo+dMxNt9XMG8q/3X1Sff/mM5tgB3tImLUaHFEtH/5iGRG0Tpgo/cy/Q== From: Gregory CLEMENT To: Jiaxun Yang , "paulburton@kernel.org" , Thomas Bogendoerfer , "linux-mips@vger.kernel.org" , Rob Herring , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Vladimir Kondratiev , Tawfik Bayouk , Alexandre Belloni , =?utf-8?Q?Th=C3=A9o?= Lebrun , Thomas Petazzoni Subject: Re: [PATCH v2 20/21] MIPS: generic: Add support for Mobileye EyeQ5 In-Reply-To: References: <20231123152639.561231-1-gregory.clement@bootlin.com> <20231123152639.561231-21-gregory.clement@bootlin.com> Date: Fri, 01 Dec 2023 11:34:30 +0100 Message-ID: <87ttp2dxe1.fsf@BL-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: gregory.clement@bootlin.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Jiaxun Yang" writes: > =E5=9C=A82023=E5=B9=B411=E6=9C=8823=E6=97=A5=E5=8D=81=E4=B8=80=E6=9C=88 = =E4=B8=8B=E5=8D=883:26=EF=BC=8CGregory CLEMENT=E5=86=99=E9=81=93=EF=BC=9A >> Introduce support for the MIPS based Mobileye EyeQ5 SoCs. >> >> Signed-off-by: Gregory CLEMENT >> --- > [...] >> diff --git a/arch/mips/generic/Kconfig b/arch/mips/generic/Kconfig >> index 7dc5b3821cc6e..04e1fc6f789b5 100644 >> --- a/arch/mips/generic/Kconfig >> +++ b/arch/mips/generic/Kconfig >> @@ -48,6 +48,13 @@ config SOC_VCOREIII >> config MSCC_OCELOT >> bool >>=20 >> +config SOC_EYEQ5 >> + select ARM_AMBA >> + select WEAK_ORDERING >> + select WEAK_REORDERING_BEYOND_LLSC >> + select PHYSICAL_START_BOOL >> + bool > > ^ I believe WEAK_ORDERING is already selected by MIPS_CPS, But MIPS_CPS can be disabled: it is not selected by MIPS_GENERIC_KERNEL. > and WEAK_REORDERING_BEYOND_LLSC should be selected by MIPS_CPS as well. WEAK_REORDERING_BEYOND_LLSC is only selected by CPU_LOONGSON64 for now not by MIPS_CPS Thanks, Gregory >=20=20 > Thanks > --=20 > - Jiaxun --=20 Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com