From: Thomas Gleixner <tglx@linutronix.de>
To: Li zeming <zeming@nfschina.com>,
jstultz@google.com, sboyd@kernel.org,
linux-kernel@vger.kernel.org
Cc: Li zeming <zeming@nfschina.com>
Subject: Re: [PATCH] time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret'
Date: Mon, 12 Jun 2023 09:40:26 +0200 [thread overview]
Message-ID: <87ttvd6sd1.ffs@tglx> (raw)
In-Reply-To: <20230613193540.3177-1-zeming@nfschina.com>
Li!
On Wed, Jun 14 2023 at 03:35, Li zeming wrote:
Can you please pick the proper prefixes and not create random ones.
https://www.kernel.org/doc/html/latest/process/maintainer-tip.html#patch-subject
> ret is assigned first, so it does not need to initialize the
> assignment.
This sentence does not make sense. You cannot initialize an
assignment. What you want to say is something like this.
'ret' is always assigned before being checked, so initializing the
variable is not required.
No?
Thanks,
tglx
prev parent reply other threads:[~2023-06-12 7:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 19:35 [PATCH] time: clocksource-wdtest: Remove unnecessary initialization of variable 'ret' Li zeming
2023-06-12 7:40 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ttvd6sd1.ffs@tglx \
--to=tglx@linutronix.de \
--cc=jstultz@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=zeming@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox