From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <frederic@kernel.org>,
Zhouyi Zhou <zhouzhouyi@gmail.com>
Cc: fweisbec@gmail.com, mingo@kernel.org, paulmck@kernel.org,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next] mark access to tick_do_timer_cpu with READ_ONCE/WRITE_ONCE
Date: Wed, 11 Jan 2023 10:02:37 +0100 [thread overview]
Message-ID: <87tu0xiguq.ffs@tglx> (raw)
In-Reply-To: <Y7wN0TKU1jDyTZs5@lothringen>
On Mon, Jan 09 2023 at 13:51, Frederic Weisbecker wrote:
> On Mon, Dec 19, 2022 at 01:21:28PM +0800, Zhouyi Zhou wrote:
>> fix above bug by marking access to tick_do_timer_cpu with READ_ONCE/WRITE_ONCE
>
> This has been discussed before with passion:
>
> http://archive.lwn.net:8080/linux-kernel/1C65422C-FFA4-4651-893B-300FAF9C49DE@lca.pw/T/
>
> To me data_race() would be more appropriate but that would need a changelog with
> proper analysis of the tick_do_timer_cpu state machine.
Proper analysis and comments in the code are required independent of
READ/WRITE_ONCE() or data_race().
Thanks,
tglx
prev parent reply other threads:[~2023-01-11 9:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 5:21 [PATCH linux-next] mark access to tick_do_timer_cpu with READ_ONCE/WRITE_ONCE Zhouyi Zhou
2023-01-06 14:33 ` Paul E. McKenney
2023-01-09 12:51 ` Frederic Weisbecker
2023-01-09 13:13 ` Zhouyi Zhou
2023-01-09 15:25 ` Paul E. McKenney
2023-01-09 15:59 ` Zhouyi Zhou
2023-01-23 0:44 ` Zhouyi Zhou
2023-01-23 16:54 ` Paul E. McKenney
2023-01-11 9:02 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu0xiguq.ffs@tglx \
--to=tglx@linutronix.de \
--cc=frederic@kernel.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=zhouzhouyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox