From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11997C433FE for ; Mon, 28 Nov 2022 21:03:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233666AbiK1VDZ (ORCPT ); Mon, 28 Nov 2022 16:03:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbiK1VDY (ORCPT ); Mon, 28 Nov 2022 16:03:24 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBA20C12; Mon, 28 Nov 2022 13:03:22 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669669400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhB7JGU0+3dUf/xb6vSXZN0hUM70VXiiaFn2KBna12A=; b=zlvNwIwoHG+fU4gxnuatMPxfyVs5ZSLePNJu4/ocONdVKcLEZDqxHiVlXWATLTuFzvzVQH wvylbGYhnIJkRBfI06fvH8zrEydybvoGyJU4k6idIaEb8132jwZUwabOGcYf5ls2TUSa81 SbeW0BZ0iRRMeh23zOgiaOb0YEuMrwElmiEaTS7Nepm/GHglMgTFNCurANP6kTLFcFlxT+ S6h+mst5tidq7iJ67Vk4o2lLC31GVx0EpMSI7Jy53xj9hjy0e+Xb2TiEVK7iM0+bf272Ze 2pAQf4pFBLaQtNW95y+qQXVA9uI271Sl7FODDOKRr/856Yr93LB6VMiYkim0lQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669669400; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XhB7JGU0+3dUf/xb6vSXZN0hUM70VXiiaFn2KBna12A=; b=CWSwp1XKO4MBIhCx2CWco0lkUyqfbLhLh5RYHrL1h2GQY7cqKnAbOprHdP8gtA7ZMoKFpk LeZC3c+3eRBaziBw== To: Frank Li Cc: agross@kernel.org, ammarfaizi2@gnuweeb.org, andersson@kernel.org, andrew@lunn.ch, bhelgaas@google.com, festevam@gmail.com, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, jgg@mellanox.com, kristo@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lorenzo.pieralisi@arm.com, lpieralisi@kernel.org, mark.rutland@arm.com, maz@kernel.org, nm@ti.com, okaya@kernel.org, robin.murphy@arm.com, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shameerali.kolothum.thodi@huawei.com, shawnguo@kernel.org, ssantosh@kernel.org, vkoul@kernel.org, will@kernel.org, yuzenghui@huawei.com, imx@lists.linux.dev Subject: Re: [patch V2 33/40] irqchip/imx-mu-msi: Switch to MSI parent In-Reply-To: <20221128204710.2084706-1-Frank.Li@nxp.com> References: <20221121140050.386216606@linutronix.de> <20221128204710.2084706-1-Frank.Li@nxp.com> Date: Mon, 28 Nov 2022 22:03:20 +0100 Message-ID: <87tu2ivlk7.ffs@tglx> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Frank! On Mon, Nov 28 2022 at 15:47, Frank Li wrote: > On Mon, Nov 21, 2022 at 03:40:09PM +0100, Thomas Gleixner wrote: >> * The device MSI domain can never have a set affinity callback it >> --- a/drivers/irqchip/irq-imx-mu-msi.c >> +++ b/drivers/irqchip/irq-imx-mu-msi.c >> @@ -24,6 +24,8 @@ >> #include >> #include >> >> +#include "irq-gic-msi-lib.h" >> + > > I think irq-gic-msi-lib.h is not good name. Actually mu-msi is not arm gic. > irq-gic-msi-lib do common work, which not related arm gic at all. I realized that after a while too, but the main purpose of this series was to establish that the core design holds up to handle the gazillions of ARM variants out there and to solicit technical feedback from the involved parties. >> static int imx_mu_msi_domains_init(struct imx_mu_msi *msi_data, struct device *dev) >> { >> struct fwnode_handle *fwnodes = dev_fwnode(dev); >> struct irq_domain *parent; >> >> /* Initialize MSI domain parent */ >> - parent = irq_domain_create_linear(fwnodes, >> - IMX_MU_CHANS, >> - &imx_mu_msi_domain_ops, >> - msi_data); >> + parent = irq_domain_create_linear(fwnodes, IMX_MU_CHANS, &imx_mu_msi_domain_ops, msi_data); > > coding style change should be in sperated patch. Thanks for the thorough technical feedback! tglx