Re: [PATCH printk v2 4/7] printk: Add struct console_buffers

Petr Mladek
2022-11-24T14:53:18Z

On Thu 2022-11-24 00:19:57, John Ogness wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> Create a data structure to replace the open coded separate buffers for
> regular, extended, and dropped message formatting.
>
> A separate @ext_text buffer is needed because info_print_ext_header()
> and msg_print_ext_body() are not able to add the needed extra
> information in-place.
>
> @ext_text can be used for dropped text because they are never used at
> the same time.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>

If we agree to use the static buffers in struct console, feel free to use:

Reviewed-by: Petr Mladek <pmladek@suse.com>

Otherwise, it should get moved into some internal header.

Best Regards,
Petr