From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9904C43334 for ; Thu, 14 Jul 2022 09:06:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233738AbiGNJGV (ORCPT ); Thu, 14 Jul 2022 05:06:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229555AbiGNJGT (ORCPT ); Thu, 14 Jul 2022 05:06:19 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18F3910FEE for ; Thu, 14 Jul 2022 02:06:18 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B491B34B36; Thu, 14 Jul 2022 09:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1657789576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fY5PuKc7+fso/B1Mtp/dKY37K4gSKnVfZnobpSyBJ80=; b=bXsocT88pxEdhutkWsCRZpCrq2B90GCKFx/fyCvxgZKwPwEWFM6uDw2sx+9JAcnixmlJt7 70iO9xwaxNnSMfBilqhiSe/ZFGs0F0USURDQkHYbXdK4PFv1NEnz7LnyHV6sJSwYaEAgaG /TpoG/A3N1qplFSeGPgKo/4JFe9bLjE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1657789576; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fY5PuKc7+fso/B1Mtp/dKY37K4gSKnVfZnobpSyBJ80=; b=JD5lAmDyQpB7F0iFuhcuMvehrJhxHFBOIQg8prV79eG4N7BlYc9BQ3tMyasMcSLcWBdRGb zy6mlIK8X5fNe5Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8341B13A61; Thu, 14 Jul 2022 09:06:16 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id V2lVH4jcz2LSIAAAMHmgww (envelope-from ); Thu, 14 Jul 2022 09:06:16 +0000 Date: Thu, 14 Jul 2022 11:06:16 +0200 Message-ID: <87tu7kvzav.wl-tiwai@suse.de> From: Takashi Iwai To: Vitaly Rodionov Cc: Jaroslav Kysela , Takashi Iwai , Mark Brown , , , , Stefan Binding Subject: Re: [PATCH v8 01/14] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls In-Reply-To: <87v8s0vzfv.wl-tiwai@suse.de> References: <20220630002335.366545-1-vitalyr@opensource.cirrus.com> <20220630002335.366545-2-vitalyr@opensource.cirrus.com> <87v8s0vzfv.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 14 Jul 2022 11:03:16 +0200, Takashi Iwai wrote: > > On Thu, 30 Jun 2022 02:23:22 +0200, > Vitaly Rodionov wrote: > > --- a/sound/pci/hda/Kconfig > > +++ b/sound/pci/hda/Kconfig > > @@ -94,6 +94,10 @@ config SND_HDA_PATCH_LOADER > > config SND_HDA_SCODEC_CS35L41 > > tristate > > > > +config SND_HDA_CS_DSP_CONTROLS > > + tristate > > + depends on CS_DSP > > + > > config SND_HDA_SCODEC_CS35L41_I2C > > tristate "Build CS35L41 HD-audio side codec support for I2C Bus" > > depends on I2C > > This change alone doesn't give anything useful, unfortunately. > > The above form (without prompt) is basically only to be "selected" by > others. And when selected, the "depends" there is just ignored, so > it's useless. > > That is, a proper way would be something like: > > config SND_HDA_CS_DSP_CONTROLS > tristate > > config SND_HDA_SCODEC_CS35L41 > .... > select SND_HDA_CS_DSP_CONTROLS if CS_DSP > > ... if you want / need to enable CONFIG_SND_HDA_CS_DSP_CONTROLS > conditionally. And now I see that the patch 4 has those selects (but select both SND_HDA_CS_DSP_CONTROLS and CS_DSP). So what we need here is to drop the superfluous "depends on CS_DSP" and mention in the description that the Kconfig will be actually enabled in the later patch. thanks, Takashi