From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77CF5C433EF for ; Wed, 29 Jun 2022 13:14:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233770AbiF2NOB (ORCPT ); Wed, 29 Jun 2022 09:14:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233253AbiF2NN6 (ORCPT ); Wed, 29 Jun 2022 09:13:58 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 29E3E19C22 for ; Wed, 29 Jun 2022 06:13:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E3770B821C4 for ; Wed, 29 Jun 2022 13:13:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A33C7C34114; Wed, 29 Jun 2022 13:13:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1656508435; bh=uUbiNUjmsvlrQLS3bongCs5plDeE5Sm8soMJ2UiJ0pw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mq9EZzfGmwkHdMZtuG/cbSGlsb90DU56KsEugW4vviGxszgcGZPNAODEnAEdRmJan xWSAKmkSQ3+8SBYBrmwVSKWUGDmwhP9hUDXmFxGjeuDKv1Eg+/EtsEvPgDDHUR1E+S SPVDG2KUxVR8DZNg4nzwOWPn8y+AjFe91g7roanHezz+6gni8OmduNIHm0hHnKvVO6 qGDsriR06L5z65gfbQcqefFlVTlTLOEaU7KuVWUMNopVUFhczFOVX4cjP8ubTI2gQI 6zETsQtgg2XxY3/mxsb70r5kMyorYCn5AyBNm0mrtjFTDZpZrdUK2LUz1D/O++q/4m CVarLoMak9u+Q== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o6XVx-0044fm-Ex; Wed, 29 Jun 2022 14:13:53 +0100 Date: Wed, 29 Jun 2022 14:13:53 +0100 Message-ID: <87tu831ujy.wl-maz@kernel.org> From: Marc Zyngier To: Jianmin Lv Cc: Thomas Gleixner , linux-kernel@vger.kernel.org, Hanjun Guo , Lorenzo Pieralisi , Jiaxun Yang , Huacai Chen Subject: Re: [PATCH V13 09/13] irqchip/loongson-liointc: Add ACPI init support In-Reply-To: <1656329997-20524-10-git-send-email-lvjianmin@loongson.cn> References: <1656329997-20524-1-git-send-email-lvjianmin@loongson.cn> <1656329997-20524-10-git-send-email-lvjianmin@loongson.cn> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: lvjianmin@loongson.cn, tglx@linutronix.de, linux-kernel@vger.kernel.org, guohanjun@huawei.com, lorenzo.pieralisi@arm.com, jiaxun.yang@flygoat.com, chenhuacai@loongson.cn X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jun 2022 12:39:53 +0100, Jianmin Lv wrote: >=20 > From: Huacai Chen >=20 > We are preparing to add new Loongson (based on LoongArch, not compatible > with old MIPS-based Loongson) support. LoongArch use ACPI other than DT > as its boot protocol, so add ACPI init support. >=20 > LIOINTC stands for "Legacy I/O Interrupts" that described in Section > 11.1 of "Loongson 3A5000 Processor Reference Manual". For more > information please refer Documentation/loongarch/irq-chip-model.rst. This is what happens with this series while compiling for MIPS: drivers/irqchip/irq-loongson-liointc.c: In function =E2=80=98liointc_domain= _xlate=E2=80=99: drivers/irqchip/irq-loongson-liointc.c:170:28: error: =E2=80=98GSI_MIN_CPU_= IRQ=E2=80=99 undeclared (first use in this function) 170 | *out_hwirq =3D intspec[0] - GSI_MIN_CPU_IRQ; | ^~~~~~~~~~~~~~~ I haven't bothered reviewing more patches, as this is a waste of my time. M. --=20 Without deviation from the norm, progress is not possible.