From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF130C43334 for ; Fri, 17 Jun 2022 14:13:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1381727AbiFQONl (ORCPT ); Fri, 17 Jun 2022 10:13:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382409AbiFQONj (ORCPT ); Fri, 17 Jun 2022 10:13:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42BC93982D; Fri, 17 Jun 2022 07:13:38 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F331AB82A04; Fri, 17 Jun 2022 14:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B32ABC3411B; Fri, 17 Jun 2022 14:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655475215; bh=pgY6pJFRbTzMiMKyNxAvRDljF0tAfDbdjsgf1wsJqSg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XPxlOo7KlwiHE77eE8iKfg2EsBttTrQgQnQdgMoMioo+ASB/iyF8PnhVFZ/dlNZMd eYaBfVdhUe15uT96JV0NKrvJzEbuEiHtMDSLUF63Hxsl6hxq3fsYSGE0dndRQruWp3 tDPUJONpdsRrdPIe51sJ0hAVI199+QjYqOkEaBJ2ROi3SXLr8YppnfDPhbM1p9TSQ9 kfoz+v9rCMs2ICozr6gVJd37oZFVyCkE5HWFYJz8TSKOASew5rHUIyMBIo8jfgQ7MH HA9h59ZpofdReyndBwDD7EiQtMBdaQ6TTKjFoLC1qjcesrEQSX8ibB0/UAUXR/KkVV gd6d1J0c/EkeQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1o2Cj7-001JaH-OS; Fri, 17 Jun 2022 15:13:33 +0100 Date: Fri, 17 Jun 2022 15:13:33 +0100 Message-ID: <87tu8j2x9u.wl-maz@kernel.org> From: Marc Zyngier To: Matt Ranostay Cc: , , , Robin Murphy , Nishanth Menon Subject: Re: [PATCH v2] arm64: dts: ti: k3-j721s2: fix overlapping GICD memory region In-Reply-To: <20220617140207.444298-1-mranostay@ti.com> References: <20220617140207.444298-1-mranostay@ti.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: mranostay@ti.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, robin.murphy@arm.com, nm@ti.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Jun 2022 15:02:07 +0100, Matt Ranostay wrote: > > GICD region was overlapping with GICR causing the latter to not map > successfully, and in turn the gic-v3 driver would fail to initialize. > > This issue was hidden till commit 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources") > replaced of_iomap() calls with of_io_request_and_map() that internally > called request_mem_region(). Please correctly wrap long lines in the commit message. > > Respective console output before this patchset: > > [ 0.000000] GICv3: /bus@100000/interrupt-controller@1800000: couldn't map region 0 > > Fixes: 2b2cd74a06c3 ("irqchip/gic-v3: Claim iomem resources") No, that's the wrong target for this. Your patch fixes the *original* submission of the DT, and this should carry a: Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC") Please also consider adding a Cc: stable@vger.kernel.org Thanks, M. -- Without deviation from the norm, progress is not possible.