public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Ellerman <mpe@ellerman.id.au>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Masahiro Yamada <masahiroy@kernel.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
	Nathan Chancellor <nathan@kernel.org>,
	Sedat Dilek <sedat.dilek@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Russell Currey <ruscur@russell.cc>
Subject: Re: 5.19-rc1 build fails at scripts/check-local-export
Date: Mon, 06 Jun 2022 17:34:58 +1000	[thread overview]
Message-ID: <87tu8ynt25.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <62ba96a2-0a0c-ab8e-351d-398f31a880ae@I-love.SAKURA.ne.jp>

Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> writes:
> Hello.
>
> Commit 31cb50b5590fe911 ("kbuild: check static EXPORT_SYMBOL* by script
> instead of modpost") introduced scripts/check-local-export but it fails
> in my CentOS 7 environment.
>
> $ rpm -q binutils bash
> binutils-2.27-44.base.el7_9.1.x86_64
> bash-4.2.46-35.el7_9.x86_64

I'm also seeing this, on Ubuntu 16.04.

$ bash --version
GNU bash, version 4.3.48(1)-release (powerpc64le-unknown-linux-gnu)

> $ make
...
>   HOSTCC  scripts/mod/mk_elfconfig
>   CC      scripts/mod/empty.o
> ./scripts/check-local-export: line 54: wait: pid 17328 is not a child of this shell
> make[2]: *** [scripts/mod/empty.o] Error 127
> make[2]: *** Deleting file `scripts/mod/empty.o'
> make[1]: *** [prepare0] Error 2
> make: *** [__sub-make] Error 2
>
> Is below change OK for you?
>
> diff --git a/scripts/check-local-export b/scripts/check-local-export
> index da745e2743b7..1631c79558b7 100755
> --- a/scripts/check-local-export
> +++ b/scripts/check-local-export
> @@ -51,7 +51,7 @@ do
>  done < <(${NM} ${1} 2>/dev/null || { echo "${0}: ${NM} failed" >&2; false; } )
>  
>  # Catch error in the process substitution
> -wait $!
> +wait $! 2>/dev/null || :
>  
>  for name in "${export_symbols[@]}"
>  do

That fixes it for me.

Tested-by: Michael Ellerman <mpe@ellerman.id.au>

cheers

  reply	other threads:[~2022-06-06  7:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-06  5:49 5.19-rc1 build fails at scripts/check-local-export Tetsuo Handa
2022-06-06  7:34 ` Michael Ellerman [this message]
2022-06-06 15:26 ` [PATCH] kbuild: fix build failure by scripts/check-local-export Tetsuo Handa
2022-06-06 20:16   ` kernel test robot
2022-06-06 22:13   ` [PATCH v2] " Tetsuo Handa
2022-06-07  8:34     ` Masahiro Yamada
2022-06-07 10:11       ` Tetsuo Handa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tu8ynt25.fsf@mpe.ellerman.id.au \
    --to=mpe@ellerman.id.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=ruscur@russell.cc \
    --cc=sedat.dilek@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox